unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Michal Nazarewicz <mina86@mina86.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 26274@debbugs.gnu.org, stephen.berman@gmx.net,
	npostavs@users.sourceforge.net
Subject: bug#26274: 26.0.50; completion regression
Date: Thu, 06 Apr 2017 20:58:57 +0200	[thread overview]
Message-ID: <xa1ttw61747i.fsf@mina86.com> (raw)
In-Reply-To: <83r31e63na.fsf@gnu.org>

I’ve pushed the changes so this should be fixed now.

On Thu, Mar 30 2017, Eli Zaretskii wrote:
>> From: Michal Nazarewicz <mina86@mina86.com>
>> Cc: npostavs@users.sourceforge.net, 26274@debbugs.gnu.org
>> Date: Thu, 30 Mar 2017 18:18:42 +0200
>> 
>> Stephen, could you test Emacs at 
>> 
>> 	git fetch https://notabug.org/mina86/emacs.git ac7004999db96c7d
>> 
>> Completion behaves correctly at this commit.  Since it’s scheduled to be
>> pushed soon, I think just rolling forward is the way to go.
>
> That could be so, but if you understand how your previous patches
> caused this, it might be important to have the explanation recorded in
> this bug report.  It might be that by understanding the problem, we
> discover some issues worth being aware of.

Agreed, and I would love to add tests for this behaviour, but as I was
looking at minibuffer.el, I quickly got lost in all the dynamic
variables.  I’ll try to look at it some more over the weekend, but for
now at least HEAD is working correctly even if we’re not sure why.

-- 
Best regards
ミハウ “𝓶𝓲𝓷𝓪86” ナザレヴイツ
«If at first you don’t succeed, give up skydiving»





  reply	other threads:[~2017-04-06 18:58 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-27 10:56 bug#26274: 26.0.50; completion regression Stephen Berman
2017-03-27 16:22 ` Stephen Berman
2017-03-29 17:00   ` Stephen Berman
2017-03-29 17:27     ` Eli Zaretskii
2017-03-29 18:27       ` Stephen Berman
2017-03-29 18:33         ` Eli Zaretskii
2017-03-29 18:43           ` Stephen Berman
2017-03-29 18:49         ` Noam Postavsky
2017-03-29 20:00           ` Stephen Berman
2017-03-30  2:33             ` Eli Zaretskii
2017-03-30 13:38               ` Michal Nazarewicz
2017-03-30 14:17                 ` Michal Nazarewicz
2017-03-30 14:30                   ` Michal Nazarewicz
2017-03-30 16:18                     ` Michal Nazarewicz
2017-03-30 18:02                       ` Stephen Berman
2017-03-30 19:11                         ` Michal Nazarewicz
2017-03-30 20:14                           ` Stephen Berman
2017-03-30 18:06                       ` Eli Zaretskii
2017-04-06 18:58                         ` Michal Nazarewicz [this message]
2017-04-07  8:37                           ` Stephen Berman
2017-03-29 17:28     ` Noam Postavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xa1ttw61747i.fsf@mina86.com \
    --to=mina86@mina86.com \
    --cc=26274@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=npostavs@users.sourceforge.net \
    --cc=stephen.berman@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).