From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michal Nazarewicz Newsgroups: gmane.emacs.bugs Subject: bug#24603: [RFC 07/18] Split up casify_region function. Date: Tue, 18 Oct 2016 04:27:05 +0200 Organization: http://mina86.com/ Message-ID: References: <1475543441-10493-1-git-send-email-mina86@mina86.com> <1475543441-10493-7-git-send-email-mina86@mina86.com> <83d1jgoa5j.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1476757710 765 195.159.176.226 (18 Oct 2016 02:28:30 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 18 Oct 2016 02:28:30 +0000 (UTC) User-Agent: Notmuch/0.19+53~g2e63a09 (http://notmuchmail.org) Emacs/25.1.50.2 (x86_64-unknown-linux-gnu) Cc: 24603@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 18 04:28:26 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bwK8R-00061o-36 for geb-bug-gnu-emacs@m.gmane.org; Tue, 18 Oct 2016 04:28:11 +0200 Original-Received: from localhost ([::1]:38648 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwK8T-0007wO-6B for geb-bug-gnu-emacs@m.gmane.org; Mon, 17 Oct 2016 22:28:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55290) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwK8M-0007w7-Hz for bug-gnu-emacs@gnu.org; Mon, 17 Oct 2016 22:28:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bwK8I-0002gQ-IQ for bug-gnu-emacs@gnu.org; Mon, 17 Oct 2016 22:28:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59443) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1bwK8I-0002gJ-Ey for bug-gnu-emacs@gnu.org; Mon, 17 Oct 2016 22:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bwK8I-0006Wn-3J for bug-gnu-emacs@gnu.org; Mon, 17 Oct 2016 22:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michal Nazarewicz Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 Oct 2016 02:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24603 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24603-submit@debbugs.gnu.org id=B24603.147675763725043 (code B ref 24603); Tue, 18 Oct 2016 02:28:02 +0000 Original-Received: (at 24603) by debbugs.gnu.org; 18 Oct 2016 02:27:17 +0000 Original-Received: from localhost ([127.0.0.1]:37400 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bwK7Z-0006Vr-7y for submit@debbugs.gnu.org; Mon, 17 Oct 2016 22:27:17 -0400 Original-Received: from mail-lf0-f52.google.com ([209.85.215.52]:36570) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bwK7W-0006Vc-Mr for 24603@debbugs.gnu.org; Mon, 17 Oct 2016 22:27:15 -0400 Original-Received: by mail-lf0-f52.google.com with SMTP id b75so321538307lfg.3 for <24603@debbugs.gnu.org>; Mon, 17 Oct 2016 19:27:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:from:to:cc:subject:in-reply-to:organization:references :user-agent:face:date:message-id:mime-version :content-transfer-encoding; bh=GhTg4x6eT+vfdQ4SGPBHCHSNxu1QsBbWEiPqwt0xdxM=; b=UegO7JLnkzA3O0M+44TgG7/PSvJWxg8YyNwhv7dqHpyOqbhY7hv5EswxPMik2SjKlq nWeKsmbDmkuuQs+CiM+onHuZrFosq7gBmla4so/57DrXsxkIaJzKcZU6eCaIDEYfeInF LsxM16rKBqIHvNVSc7dlhfZuabJbL05f9POepRvbnt4v04PcTIUVmTsLWgbEwVcDP/24 Tpb2m9aHToRC7+NFJ/P5Jbodx5O0ex1sBSpBonsr4xSlHNOTtR4n56pvnDhvsg2RN+s2 87oHMPmTFGGdn2LSS693CKWkVQ4OQctzFwHLFd7Fe7pQSVRKvrwddz2IBdhUMPj6cHhZ bQ2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:in-reply-to :organization:references:user-agent:face:date:message-id :mime-version:content-transfer-encoding; bh=GhTg4x6eT+vfdQ4SGPBHCHSNxu1QsBbWEiPqwt0xdxM=; b=P/7u2Ahe9ZgV3VZrpx9bplOowOiInwiPJvWtYlVQfJHT7VQYmtaTI4L7//W+eADDGx PJnaOazAWJca4hAK0OZlexlc/IzZYOiXhuj6fJsdMhJEVIjFrtCEy1PqLSwSexCMsGE8 YeGuxZLQASUkuHYNoFq6kdXfyv8mtrr+9TU7ZJMniZHJ20Lt69qlcxa7ExB1QLTJDIoi ZGSfKLOAt9uzBcdAdZZ2hKsSBIvKnsabgZDxk93XTaFlDwL31F3iJPYAU9TTRm7uYXV6 O9o6JFsaWgWOOw6a9Xudmcyi2IsReIGR+KwVXcVyJiXwZjC2dY8aRS1Py3CfQS85I3zJ Znvw== X-Gm-Message-State: AA6/9RnsM/d+7nLUEdDrh9Ki8t38o7dkrWwh+4iwvU64GrX4qV69DTU5qo6qnxB8cWBLNXOF X-Received: by 10.28.24.80 with SMTP id 77mr10642730wmy.74.1476757628626; Mon, 17 Oct 2016 19:27:08 -0700 (PDT) Original-Received: from mpn-glaptop ([2620:0:105f:310:f02b:4d5c:2cd4:158a]) by smtp.gmail.com with ESMTPSA id h3sm58334333wjp.45.2016.10.17.19.27.06 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Mon, 17 Oct 2016 19:27:06 -0700 (PDT) In-Reply-To: <83d1jgoa5j.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACP0lEQVQ4T23Sv2vbQBQHcBk1xE6WyALX107VUEgmn6+ouUwpEQQ6uRjttkWP4CkBg2M0BQLBdPFZYPsyFYo7qEtKDQ7on+t7+nF2Ux8ahD587717OmNYrOvycHsZ+o2r051wHTHysAvGb8ygvgu4QWT0sCmkgZCIEnlV2X8BtyraazFGDuxhmKSQJMlwHQ7v5MHSNxmz78rfElwAa3ieVD9e+hBhjaPDDG6NgFo2f4wBMNIo5YmRtF0RyDgFjJjlMIWbnuM4x9MMfABGTlN4qgIQB4A1DEyA1BHWtfeWNUMwiVJKoqh97KrkOO+qzgluVYLvFCUKAX73nONeBr7BGMdM6Sg0kuep03VywLaIzRiVr+GAzKlpQIsAFnWAG2e6DT5WmWDiudZMIc6hYrMOmeMQK9WX0B+/RfjzL9DI7Y9/Iayn29Ci0r2i4f9gMimMSZLCDMalgQGU5hnUtqAN0OGvEmO1Wnl0C0wWSCEHnuHBqmygxdxA8oWXwbipoc1EoNR9DqOpBpOJrnr0criQab9ZT4LL+wI+K7GBQH30CrhUruilgP9DRTrhVWZCiAyILP+wiuLeCKGTD6r/nc8LOJcAwR6IBTUs+7CASw3QFZ0MdA2PI3zNziH4ZKVhXCRMBjeZ1DWMekKwDCASwExy+NQ86TaykaDAFHO4aP48y4 fIcDM5yOG8GcTLbOyp8A8azjJI93JFd1EA6yN8sSxMQJWoABqniRZVykYgRXErzrdqExAoUrRb0xfRp8p2A/4XmfilTtkDZ4cAAAAASUVORK5CYII= X-Face: -TR8(rDTHy/(xl?SfWd1|3:TTgDIatE^t'vop%*gVg[kn$t{EpK(P"VQ=~T2#ysNmJKN$"yTRLB4YQs$4{[.]Fc1)*O]3+XO^oXM>Q#b^ix, O)Zbn)q[y06$`e3?C)`CwR9y5riE=fv^X@x$y?D:XO6L&x4f-}}I4=VRNwiA^t1-ZrVK^07.Pi/57c_du'& X-PGP: 50751FF4 X-PGP-FP: AC1F 5F5C D418 88F8 CC84 5858 2060 4012 5075 1FF4 X-Hashcash: 1:20:161018:eliz@gnu.org::XZWlKuU+DSpHMMRq:000001EdN X-Hashcash: 1:20:161018:24603@debbugs.gnu.org::443Ax4RkDQIW4Q3T:00000000000000000000000000000000000000002i8V X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:124615 Archived-At: On Tue, Oct 04 2016, Eli Zaretskii wrote: >> From: Michal Nazarewicz >> Date: Tue, 4 Oct 2016 03:10:30 +0200 >>=20 >> No functional changes at this time but splitting casify_region into >> a function dealing with multibyte and another dealing with unibyte >> buffers will make future code changes slightly easier. >>=20 >> * src/casefiddle.c (casify_region): Move most of the code into two >> new functions: >> (do_casify_multibyte_region, do_casify_unibyte_region): new functions. > > Please make sure the multibyte version works with embedded eight-bit > characters, in both representations. Some of the code you removed > could handle those cases. In the new version of the first patch, I=E2=80=99ve added bunch of tests for unibyte and multibyte strings including byte8 characters so this all should be covered. --=20 Best regards =E3=83=9F=E3=83=8F=E3=82=A6 =E2=80=9C=F0=9D=93=B6=F0=9D=93=B2=F0=9D=93=B7= =F0=9D=93=AA86=E2=80=9D =E3=83=8A=E3=82=B6=E3=83=AC=E3=83=B4=E3=82=A4=E3=83= =84 =C2=ABIf at first you don=E2=80=99t succeed, give up skydiving=C2=BB