From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lennart Borgman Newsgroups: gmane.emacs.bugs Subject: bug#5863: defadvice in byte compiled file does not work Date: Fri, 9 Apr 2010 01:13:14 +0200 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: dough.gmane.org 1270769377 16322 80.91.229.12 (8 Apr 2010 23:29:37 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 8 Apr 2010 23:29:37 +0000 (UTC) Cc: 5863@debbugs.gnu.org To: Andreas Schwab Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 09 01:29:35 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1O01AF-0000hv-Ar for geb-bug-gnu-emacs@m.gmane.org; Fri, 09 Apr 2010 01:29:35 +0200 Original-Received: from localhost ([127.0.0.1]:45951 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O01AE-0004oi-Ac for geb-bug-gnu-emacs@m.gmane.org; Thu, 08 Apr 2010 19:29:34 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O01A6-0004nu-2J for bug-gnu-emacs@gnu.org; Thu, 08 Apr 2010 19:29:26 -0400 Original-Received: from [140.186.70.92] (port=54597 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O019v-0004n8-7z for bug-gnu-emacs@gnu.org; Thu, 08 Apr 2010 19:29:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O019I-0000Il-CY for bug-gnu-emacs@gnu.org; Thu, 08 Apr 2010 19:29:15 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53940) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O019I-0000Ih-AT for bug-gnu-emacs@gnu.org; Thu, 08 Apr 2010 19:28:36 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1O00vC-0000N1-8a; Thu, 08 Apr 2010 19:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lennart Borgman Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Apr 2010 23:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 5863 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 5863-submit@debbugs.gnu.org id=B5863.12707684211416 (code B ref 5863); Thu, 08 Apr 2010 23:14:02 +0000 Original-Received: (at 5863) by debbugs.gnu.org; 8 Apr 2010 23:13:41 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O00uq-0000Mn-Ka for submit@debbugs.gnu.org; Thu, 08 Apr 2010 19:13:40 -0400 Original-Received: from mail-fx0-f219.google.com ([209.85.220.219]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O00uo-0000Mi-OB for 5863@debbugs.gnu.org; Thu, 08 Apr 2010 19:13:39 -0400 Original-Received: by fxm19 with SMTP id 19so4687fxm.39 for <5863@debbugs.gnu.org>; Thu, 08 Apr 2010 16:13:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:received:message-id:subject:to:cc:content-type; bh=8qVE8mqsW2TP5N1nMn1HvxfBknxrJHpOlFy+RYSI4Qc=; b=s37k89R7Ie4wTAkYRFjE5Xj0SRVyWnnfWrZAnQWcorSAErODz0eCDkM9kCx6VkpkhY tDIALIbnxsJ9g85V0QC0uxCQmYJxZpgoBVC1cdnzXWxF8IIZCiSlJqcqj5CcTezLjIYk BKnLq4rdo4Sa1p+CpVOpZflLJ9hf7BdArsYd0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=SGpHXIMKk6JnaSQmFNuSXhlIdyIvDR49Z9g49ZGnu6qzDOO9vM90FVZdPsWHP4lveg WvE66vpQDkKjUuOa7SawGr1TwYCNJUZwvBBG2gc6Ar2S5ykb5BokWkGJyJ9bsFTXXjJz yVYF4G84ilR9fL3uqGBsbLGUK7YQpuEuwfdSQ= Original-Received: by 10.239.169.18 with HTTP; Thu, 8 Apr 2010 16:13:14 -0700 (PDT) In-Reply-To: Original-Received: by 10.239.166.10 with SMTP id z10mr83898hbd.80.1270768414123; Thu, 08 Apr 2010 16:13:34 -0700 (PDT) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Thu, 08 Apr 2010 19:14:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:36105 Archived-At: On Thu, Apr 8, 2010 at 11:52 PM, Andreas Schwab wrote: > Lennart Borgman writes: > >> On Thu, Apr 8, 2010 at 7:04 PM, Andreas Schwab wrote: >>> Lennart Borgman writes: >>> >>>> The info page I pointed to says that defadvice should work for >>>> primitives called from lisp code. >>> >>> The primitive is no longer called from lisp code when byte compiled. >> >> >> I think that is wrong. Can you point me to something that support your >> statement? > > See Fbyte_code. Hm, thanks, yes I can see how it is implemented now and I can see good reasons for optimizing it this way. However the manual does not say that byte compilation removes the check during execution if primitives are adviced or not. And I am a bit irritated that it doesn't since I trusted the manual.... ;-) Could we please correct the manual? And could we as soon as possible please remove the possibility to defadvice primitives at all? The kind of bugs produced by different execution paths for evaled and byte compiled code is rather difficult to nail down. (I have to do a totally different workaround instead of defadvice widen. But that is another problem.)