bug#24360: 25.1; byte-compile-error-on-warn doesn't treat all warnings as errors

bug#24360: 25.1; byte-compile-error-on-warn doesn't treat all warnings as errors

[Philipp]

Create a file /tmp/a.el with the following content:

(funcall '(lambda ()))

Then run

$ emacs -batch -Q -eval '(setq byte-compile-error-on-warn t)' -f batch-byte-compile /tmp/a.el ; echo $?

In toplevel form:
/tmp/a.el:1:1:Warning: (lambda nil ...) quoted with ' rather than with #'
0

Expected behavior: The warning is treated as an error because
byte-compile-error-on-warn is non-nil.

Actual behavior: The warning is not treated as an error.

This is because some warnings use byte-compile-log-warning instead of
byte-compile-warn.  In this case, macroexp--warn-and-return is the
culprit.  Probably byte-compile-log-warning should be made internal to
bytecomp.el, and never be called except from byte-compile-warn and
byte-compile-report-error.



In GNU Emacs 25.1.3 (x86_64-unknown-linux-gnu, GTK+ Version 3.10.8)
 of 2016-09-03 built on unknown
Repository revision: 803ad6f7e7a9c6bcf8a6cbf8eaad17501b114a33
Windowing system distributor 'The X.Org Foundation', version 11.0.11702000
System Description:	Ubuntu 14.04 LTS

Configured features:
XPM JPEG TIFF GIF PNG SOUND GSETTINGS NOTIFY GNUTLS FREETYPE XFT ZLIB
TOOLKIT_SCROLL_BARS GTK3 X11

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Emacs-Lisp

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent messages:
Mark set
Setting ‘send-mail-function’ temporarily since "emacs -q" would overwrite customizations
Sending...
Mark set [2 times]
Sending via mail...
Setting ‘smtpmail-smtp-server’ temporarily since "emacs -q" would overwrite customizations
Setting ‘smtpmail-smtp-service’ temporarily since "emacs -q" would overwrite customizations
Sending email 
Sending email done
Sending...done

Load-path shadows:
None found.

Features:
(network-stream nsm starttls tls gnutls mailalias smtpmail auth-source
cl-seq eieio byte-opt bytecomp byte-compile cl-extra cconv eieio-core
cl-macs gv qp cus-edit cus-start cus-load wid-edit pp shadow sort
mail-extr emacsbug message dired format-spec rfc822 mml mml-sec
password-cache epg epg-config gnus-util mm-decode mm-bodies mm-encode
mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047
rfc2045 ietf-drums mm-util help-fns help-mode easymenu cl-loaddefs pcase
cl-lib mail-prsvr mail-utils time-date mule-util tooltip eldoc electric
uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win
term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list newcomment elisp-mode lisp-mode prog-mode register page
menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock
syntax facemenu font-core frame cl-generic cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help
simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces
cus-face macroexp files text-properties overlay sha1 md5 base64 format
env code-pages mule custom widget hashtable-print-readable backquote
inotify dynamic-setting system-font-setting font-render-setting
move-toolbar gtk x-toolkit x multi-tty make-network-process emacs)

Memory information:
((conses 16 119674 16537)
 (symbols 48 22519 1)
 (miscs 40 327 168)
 (strings 32 21974 7538)
 (string-bytes 1 636109)
 (vectors 16 18827)
 (vector-slots 8 872737 93406)
 (floats 8 211 249)
 (intervals 56 446 4)
 (buffers 976 28)
 (heap 1024 41113 5584))