unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Philipp Stephani <p.stephani2@gmail.com>
To: 53266@debbugs.gnu.org
Subject: bug#53266: Incorrect customization group for undo-no-redo
Date: Fri, 14 Jan 2022 19:46:24 +0100	[thread overview]
Message-ID: <wvr4wnj2updr.fsf@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 705 bytes --]

Tags: patch

In Emacs 28, undo-no-redo incorrectly uses the customization group
next-error.  Can I install the attached patch on the emacs-28 branch to
fix this?

In GNU Emacs 28.0.91 (build 4, x86_64-pc-linux-gnu, GTK+ Version 3.24.30, cairo version 1.16.0)
 of 2022-01-13
Repository revision: 34ca4ff9a52d38250f70f578fd045490b4eef4f9
Repository branch: emacs-28
Windowing system distributor 'The X.Org Foundation', version 11.0.12013000
System Description: Debian GNU/Linux rodete

Configured using:
 'configure --enable-gcc-warnings=warn-only
 --enable-gtk-deprecation-warnings --without-pop --with-mailutils
 --enable-checking=all --enable-check-lisp-object-type --with-modules
 'CFLAGS=-O0 -ggdb3''


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-lisp-simple.el-undo-no-redo-Fix-customization-group.patch --]
[-- Type: text/patch, Size: 740 bytes --]

From b6bb585a5b9930264c328431bc9f092be8a4b6cd Mon Sep 17 00:00:00 2001
From: Philipp Stephani <phst@google.com>
Date: Fri, 14 Jan 2022 19:35:03 +0100
Subject: [PATCH] * lisp/simple.el (undo-no-redo): Fix customization group

---
 lisp/simple.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/simple.el b/lisp/simple.el
index ef7fdd061f..355ebd690f 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -2947,7 +2947,8 @@ undo-in-region
 
 (defcustom undo-no-redo nil
   "If t, `undo' doesn't go through redo entries."
-  :type 'boolean)
+  :type 'boolean
+  :group 'undo)
 
 (defvar pending-undo-list nil
   "Within a run of consecutive undo commands, list remaining to be undone.
-- 
2.34.1.703.g22d0c6ccf7-goog


[-- Attachment #3: Type: text/plain, Size: 715 bytes --]


-- 
Google Germany GmbH
Erika-Mann-Straße 33
80636 München

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg

Diese E-Mail ist vertraulich.  Falls Sie diese fälschlicherweise erhalten haben
sollten, leiten Sie diese bitte nicht an jemand anderes weiter, löschen Sie
alle Kopien und Anhänge davon und lassen Sie mich bitte wissen, dass die E-Mail
an die falsche Person gesendet wurde.

This e-mail is confidential.  If you received this communication by mistake,
please don’t forward it to anyone else, please erase all copies and
attachments, and please let me know that it has gone to the wrong person.

             reply	other threads:[~2022-01-14 18:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-14 18:46 Philipp Stephani [this message]
2022-01-14 19:02 ` bug#53266: Incorrect customization group for undo-no-redo Eli Zaretskii
2022-01-14 21:33   ` Philipp Stephani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=wvr4wnj2updr.fsf@gmail.com \
    --to=p.stephani2@gmail.com \
    --cc=53266@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).