From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#53071: 28.0.90; Emacs 28 regression: incorrect code generation for complex pcase forms? Date: Fri, 07 Jan 2022 10:36:03 +0100 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23531"; mail-complaints-to="usenet@ciao.gmane.io" To: 53071@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 07 10:42:43 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n5llj-0005wo-Ny for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 Jan 2022 10:42:43 +0100 Original-Received: from localhost ([::1]:43568 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n5lli-0002jR-Qq for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 Jan 2022 04:42:42 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54414) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5lgE-00049H-K0 for bug-gnu-emacs@gnu.org; Fri, 07 Jan 2022 04:37:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50174) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n5lgE-0000u3-8i for bug-gnu-emacs@gnu.org; Fri, 07 Jan 2022 04:37:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n5lgE-0004AH-6s for bug-gnu-emacs@gnu.org; Fri, 07 Jan 2022 04:37:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 Jan 2022 09:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 53071 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.164154817515934 (code B ref -1); Fri, 07 Jan 2022 09:37:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 7 Jan 2022 09:36:15 +0000 Original-Received: from localhost ([127.0.0.1]:43077 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5lfS-00048w-Gn for submit@debbugs.gnu.org; Fri, 07 Jan 2022 04:36:14 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:60684) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5lfP-00048k-Aw for submit@debbugs.gnu.org; Fri, 07 Jan 2022 04:36:13 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54190) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5lfP-0002QG-29 for bug-gnu-emacs@gnu.org; Fri, 07 Jan 2022 04:36:11 -0500 Original-Received: from [2a00:1450:4864:20::42a] (port=40528 helo=mail-wr1-x42a.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n5lfN-0000k6-99 for bug-gnu-emacs@gnu.org; Fri, 07 Jan 2022 04:36:10 -0500 Original-Received: by mail-wr1-x42a.google.com with SMTP id l10so9927429wrh.7 for ; Fri, 07 Jan 2022 01:36:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=YpVhiKIE/Em5BF5F+W3Qpa2rVpQSz2cJlTgV9jpv6OE=; b=IwsPtrF0pWfKiuAAtMQjgSx0FLQqDMhBzQ3gtH+9fFC67+1j9coq0TanMwcfClYMla YAjmZmTG94McOj4oxQhWBjxv9V9yNZ1DVHKW/XZlXrJk/qX0VNI5XUZBWDL/H8Z4e4SX BfVgrVg/QCS+O/dp1oz4JwVvakvl16He4hWA6iNvprjbUxsm++BCs6BmY+gbSBOrzpG3 Xrp44XSNDnjc0eWNVA1dDGMrhoS+QZDI9Sd5NaYlCsfYCZdlwtML8y5KEZRWrnOZYwmI 0akzzKf1ZtGAhM+93y5Ko9U7A4tFmMKuzVzpWag+HaRQ2oCvUcfQs3kloX3CMSP+/Vfv o/SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=YpVhiKIE/Em5BF5F+W3Qpa2rVpQSz2cJlTgV9jpv6OE=; b=J+tY756m0ntowPFItu/z4xWqbXAU8/CDMxmDOx2Wrk2TNUgd0GfaTHFMa5/A8/ubz1 wxfpM0KKzDMgmniffwmJ+ZAOtvK0jGqrGyaNaCl0t72/ANfg8Zfu7pnvPiFtOU1ptRJg TPS13FybOySq/13EBhIL+VwxxQ5xDhge32XuHozCNtPz3kyJXnsG/b/rnPx6UCGW9cli iYL5XpQ+/8jGe4vjAUO3o4NCl5OR8xxtPakbKlXlmJJyGbvtdAyuy6s0382lMqctIxKi LsQywHd402EdPYjPVWAtVnjOiPJSfq4J9/QctCpLM65JFcPyLDyuh9M/s7bgzBa7GnN/ e7oA== X-Gm-Message-State: AOAM531gm8HW8PHw2eFEEr57Awf+N9J+J52DXyRRAWgJRjR9fy5lv/1j Ubm2SrMts2nVgz/PTPnlAwL3O/6CoJg= X-Google-Smtp-Source: ABdhPJw//k6eooo5l6cBd8xkfd7Qqn7jX3bwJqFNH/QfXmot/+FapECLMUi721SeMcBnyB53LRzqrQ== X-Received: by 2002:a05:6000:168a:: with SMTP id y10mr56038077wrd.572.1641548167094; Fri, 07 Jan 2022 01:36:07 -0800 (PST) Original-Received: from phst ([2a02:2455:2a4:dc00:39ea:b2a2:f94b:4358]) by smtp.gmail.com with ESMTPSA id l2sm4404437wrz.8.2022.01.07.01.36.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jan 2022 01:36:06 -0800 (PST) X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::42a (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=p.stephani2@gmail.com; helo=mail-wr1-x42a.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:223780 Archived-At: I hit the following subtle Edebug regression in Emacs 28: Create a file /tmp/pcase-edebug.el with these contents: $ cat /tmp/pcase-edebug.el=20 ;; -*- lexical-binding: t; -*- (require 'rx) (defun f (a) (pcase a ((rx bos (let q (opt (let r nonl)) (let a nonl))) (message "%s" a)) ((rx bos eos) (message "%s" a)))) Visit the file in Emacs: $ emacs -Q -l rx /tmp/pcase-edebug.el Move point into the `f' function and instrument it using C-u C-M-x. Then, byte-compile `f' using M-: (byte-compile 'f). In Emacs 28, this will generate the following warnings: Warning: Unused lexical variable `q' Warning: Unused lexical variable `r' Warning: reference to free variable =E2=80=98a=E2=80=99 The first two are expected, the third one is not. Indeed, M-: (f "ab") and stepping through the code will signal an error: Symbol's value as variable is void: a This doesn't happen in Emacs 27, so I think it should be fixed on the release branch before releasing Emacs 28. In GNU Emacs 28.0.90 (build 12, x86_64-pc-linux-gnu, GTK+ Version 3.24.30, = cairo version 1.16.0) of 2022-01-05 Repository revision: c0cfbca311e6e07e9f8b9c1c9d0e2fe9792cd08c Repository branch: emacs-28 Windowing system distributor 'The X.Org Foundation', version 11.0.12011000 System Description: Debian GNU/Linux rodete Configured using: 'configure --enable-gcc-warnings=3Dwarn-only --enable-gtk-deprecation-warnings --without-pop --with-mailutils --enable-checking=3Dall --enable-check-lisp-object-type --with-modules 'CFLAGS=3D-O0 -ggdb3'' Configured features: CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB Important settings: value of $LC_TIME: en_DK.utf8 value of $LANG: en_US.utf8 value of $XMODIFIERS: @im=3Dibus locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug sendmail phst skeleton edmacro kmacro pcase ffap thingatpt url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util url-parse url-vars mailcap rx message rmc dired dired-loaddefs rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util rmail rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr mailabbrev mail-utils gmm-utils mailheader gnutls puny elp dbus xml subr-x seq byte-opt gv bytecomp byte-compile cconv compile text-property-search comint ansi-color ring cl-loaddefs cl-lib iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 69586 8115) (symbols 48 8528 3) (strings 32 24811 2252) (string-bytes 1 802373) (vectors 16 15668) (vector-slots 8 207469 17113) (floats 8 29 46) (intervals 56 228 0) (buffers 992 11)) --=20 Google Germany GmbH Erika-Mann-Stra=C3=9Fe 33 80636 M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Diese E-Mail ist vertraulich. Falls Sie diese f=C3=A4lschlicherweise erhal= ten haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter, l=C3=B6sche= n Sie alle Kopien und Anh=C3=A4nge davon und lassen Sie mich bitte wissen, dass d= ie E-Mail an die falsche Person gesendet wurde. This e-mail is confidential. If you received this communication by mistake, please don=E2=80=99t forward it to anyone else, please erase all copies and attachments, and please let me know that it has gone to the wrong person.