bug#30646: 27.0.50; Occur next-error and recentering bug

bug#30646: 27.0.50; Occur next-error and recentering bug

[p.stephani2]

M-x set-variable RET next-error-recenter RET (4) RET
M-x occur, use something that gives results (e.g. ';;' in the scratch
buffer)
M-g M-n

This signals an error
next-error: ‘recenter’ing a window that does not display current-buffer.

Stack trace is

Debugger entered--Lisp error: (error "‘recenter’ing a window that does not  
display current-buffer.")
   recenter((4))
   next-error(nil)
   funcall-interactively(next-error nil)
   call-interactively(next-error nil nil)
   command-execute(next-error)


In GNU Emacs 27.0.50 (build 21, x86_64-pc-linux-gnu, GTK+ Version 3.22.24)
  of 2018-02-28 built on localhost
Repository revision: 108ce84432d597f92637ea74bd0a094224d157de
Windowing system distributor 'The X.Org Foundation', version 11.0.11903000
System Description: Debian GNU/Linux buster/sid

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.

Configured using:
  'configure --without-threads --enable-gcc-warnings=warn-only
  --enable-gtk-deprecation-warnings --without-pop --with-mailutils
  --enable-checking --enable-check-lisp-object-type --with-modules
  'CFLAGS=-O0 -ggdb3''

Configured features:
XPM JPEG TIFF GIF PNG SOUND DBUS GSETTINGS NOTIFY GNUTLS FREETYPE XFT
ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 MODULES JSON

Important settings:
   value of $LANG: en_US.UTF-8
   locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
   tooltip-mode: t
   global-eldoc-mode: t
   eldoc-mode: t
   electric-indent-mode: t
   mouse-wheel-mode: t
   tool-bar-mode: t
   menu-bar-mode: t
   file-name-shadow-mode: t
   global-font-lock-mode: t
   font-lock-mode: t
   blink-cursor-mode: t
   auto-composition-mode: t
   auto-encryption-mode: t
   auto-compression-mode: t
   line-number-mode: t
   transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny seq byte-opt gv
bytecomp byte-compile cconv cl-loaddefs cl-lib dired dired-loaddefs
format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg
epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode
mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047
rfc2045 ietf-drums mm-util mail-prsvr mail-utils elec-pair time-date
mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar
dnd fontset image regexp-opt fringe tabulated-list replace newcomment
text-mode elisp-mode lisp-mode prog-mode register page menu-bar
rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock
syntax facemenu font-core term/tty-colors frame cl-generic cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european
ethiopic indian cyrillic chinese composite charscript charprop
case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer
cl-preloaded nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote dbusbind inotify
dynamic-setting system-font-setting font-render-setting move-toolbar gtk
x-toolkit x multi-tty make-network-process emacs)

Memory information:
((conses 16 95129 7987)
  (symbols 48 20164 1)
  (miscs 40 40 121)
  (strings 32 28285 2157)
  (string-bytes 1 757754)
  (vectors 16 14174)
  (vector-slots 8 499090 14200)
  (floats 8 50 67)
  (intervals 56 223 0)
  (buffers 992 12))

-- 
Google Germany GmbH
Erika-Mann-Straße 33
80636 München

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Paul Manicle, Halimah DeLaine Prado

If you received this communication by mistake, please don’t forward it to
anyone else (it may contain confidential or privileged information), please
erase all copies of it, including all attachments, and please let the sender
know it went to the wrong person.  Thanks.

bug#30646: 27.0.50; Occur next-error and recentering bug

[Juri Linkov]

> M-x set-variable RET next-error-recenter RET (4) RET
> M-x occur, use something that gives results (e.g. ';;' in the scratch
> buffer)
> M-g M-n
>
> This signals an error
> next-error: ‘recenter’ing a window that does not display current-buffer.
>
> Stack trace is
>
> Debugger entered--Lisp error: (error "‘recenter’ing a window that does not
> display current-buffer.")
>   recenter((4))
>   next-error(nil)
>   funcall-interactively(next-error nil)
>   call-interactively(next-error nil nil)
>   command-execute(next-error)

I don't know why ‘recenter’ doesn't support a non-selected window, but
moving the ‘recenter’ call outside of ‘with-current-buffer’ seems to do
the right thing.  Incidentally, we are discussing a related issue in
bug#20489, that might bring a better fix than this:

diff --git a/lisp/simple.el b/lisp/simple.el
index b7ad6eb..9b1720c 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -282,20 +282,20 @@ next-error
   (when (setq next-error-last-buffer (next-error-find-buffer))
     ;; we know here that next-error-function is a valid symbol we can funcall
     (with-current-buffer next-error-last-buffer
-      (funcall next-error-function (prefix-numeric-value arg) reset)
-      (when next-error-recenter
-        (recenter next-error-recenter))
-      (run-hooks 'next-error-hook))))
+      (funcall next-error-function (prefix-numeric-value arg) reset))
+    (when next-error-recenter
+      (recenter next-error-recenter))
+    (run-hooks 'next-error-hook)))
 
 (defun next-error-internal ()
   "Visit the source code corresponding to the `next-error' message at point."
   (setq next-error-last-buffer (current-buffer))
   ;; we know here that next-error-function is a valid symbol we can funcall
   (with-current-buffer next-error-last-buffer
-    (funcall next-error-function 0 nil)
-    (when next-error-recenter
-      (recenter next-error-recenter))
-    (run-hooks 'next-error-hook)))
+    (funcall next-error-function 0 nil))
+  (when next-error-recenter
+    (recenter next-error-recenter))
+  (run-hooks 'next-error-hook))
 
 (defalias 'goto-next-locus 'next-error)
 (defalias 'next-match 'next-error)

bug#30646: 27.0.50; Occur next-error and recentering bug

[Eli Zaretskii]

> From: Juri Linkov <juri@linkov.net>
> Date: Wed, 28 Feb 2018 23:06:37 +0200
> Cc: 30646@debbugs.gnu.org
> 
> I don't know why ‘recenter’ doesn't support a non-selected window

To catch bugs, see

  http://lists.gnu.org/archive/html/emacs-devel/2014-06/msg00094.html

bug#30646: 27.0.50; Occur next-error and recentering bug

[Nathan Moreau]

Also see #27362.

Nathan

On 28 February 2018 at 12:51,  <p.stephani2@gmail.com> wrote:
>
> M-x set-variable RET next-error-recenter RET (4) RET
> M-x occur, use something that gives results (e.g. ';;' in the scratch
> buffer)
> M-g M-n
>
> This signals an error
> next-error: ‘recenter’ing a window that does not display current-buffer.
>
> Stack trace is
>
> Debugger entered--Lisp error: (error "‘recenter’ing a window that does not
> display current-buffer.")
>   recenter((4))
>   next-error(nil)
>   funcall-interactively(next-error nil)
>   call-interactively(next-error nil nil)
>   command-execute(next-error)
>
>
> In GNU Emacs 27.0.50 (build 21, x86_64-pc-linux-gnu, GTK+ Version 3.22.24)
>  of 2018-02-28 built on localhost
> Repository revision: 108ce84432d597f92637ea74bd0a094224d157de
> Windowing system distributor 'The X.Org Foundation', version 11.0.11903000
> System Description: Debian GNU/Linux buster/sid
>
> Recent messages:
> For information about GNU Emacs and the GNU system, type C-h C-a.
>
> Configured using:
>  'configure --without-threads --enable-gcc-warnings=warn-only
>  --enable-gtk-deprecation-warnings --without-pop --with-mailutils
>  --enable-checking --enable-check-lisp-object-type --with-modules
>  'CFLAGS=-O0 -ggdb3''
>
> Configured features:
> XPM JPEG TIFF GIF PNG SOUND DBUS GSETTINGS NOTIFY GNUTLS FREETYPE XFT
> ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 MODULES JSON
>
> Important settings:
>   value of $LANG: en_US.UTF-8
>   locale-coding-system: utf-8-unix
>
> Major mode: Lisp Interaction
>
> Minor modes in effect:
>   tooltip-mode: t
>   global-eldoc-mode: t
>   eldoc-mode: t
>   electric-indent-mode: t
>   mouse-wheel-mode: t
>   tool-bar-mode: t
>   menu-bar-mode: t
>   file-name-shadow-mode: t
>   global-font-lock-mode: t
>   font-lock-mode: t
>   blink-cursor-mode: t
>   auto-composition-mode: t
>   auto-encryption-mode: t
>   auto-compression-mode: t
>   line-number-mode: t
>   transient-mark-mode: t
>
> Load-path shadows:
> None found.
>
> Features:
> (shadow sort mail-extr emacsbug message rmc puny seq byte-opt gv
> bytecomp byte-compile cconv cl-loaddefs cl-lib dired dired-loaddefs
> format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg
> epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode
> mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047
> rfc2045 ietf-drums mm-util mail-prsvr mail-utils elec-pair time-date
> mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks
> lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar
> dnd fontset image regexp-opt fringe tabulated-list replace newcomment
> text-mode elisp-mode lisp-mode prog-mode register page menu-bar
> rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock
> syntax facemenu font-core term/tty-colors frame cl-generic cham georgian
> utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
> japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european
> ethiopic indian cyrillic chinese composite charscript charprop
> case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer
> cl-preloaded nadvice loaddefs button faces cus-face macroexp files
> text-properties overlay sha1 md5 base64 format env code-pages mule
> custom widget hashtable-print-readable backquote dbusbind inotify
> dynamic-setting system-font-setting font-render-setting move-toolbar gtk
> x-toolkit x multi-tty make-network-process emacs)
>
> Memory information:
> ((conses 16 95129 7987)
>  (symbols 48 20164 1)
>  (miscs 40 40 121)
>  (strings 32 28285 2157)
>  (string-bytes 1 757754)
>  (vectors 16 14174)
>  (vector-slots 8 499090 14200)
>  (floats 8 50 67)
>  (intervals 56 223 0)
>  (buffers 992 12))
>
> --
> Google Germany GmbH
> Erika-Mann-Straße 33
> 80636 München
>
> Registergericht und -nummer: Hamburg, HRB 86891
> Sitz der Gesellschaft: Hamburg
> Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
>
> If you received this communication by mistake, please don’t forward it to
> anyone else (it may contain confidential or privileged information), please
> erase all copies of it, including all attachments, and please let the sender
> know it went to the wrong person.  Thanks.

bug#30646: 27.0.50; Occur next-error and recentering bug

[Juri Linkov]

forcemerge 27362 30646
thanks

Version: 27.0.50

> Also see #27362.

Thanks for the reference, now merged these two reports fixed in 0c9e3df.