bug#28567: 27.0.50; `directory-files-recursively' signals an error if there is some inaccessible subdirectory

bug#28567: 27.0.50; `directory-files-recursively' signals an error if there is some inaccessible subdirectory

[Philipp]

mkdir c c/c
chmod 0000 c/c
emacs -Q -batch -f toggle-debug-on-error -eval '(directory-files-recursively "/tmp/c" "foo")'
Debug on Error enabled globally
Debugger entered--Lisp error: (file-error "Opening directory" "Permission denied" "/tmp/c/c")
  file-name-all-completions("" "/tmp/c/c")
  directory-files-recursively("/tmp/c/c" "foo" nil)
  directory-files-recursively("/tmp/c" "foo")
  eval((directory-files-recursively "/tmp/c" "foo"))
  command-line-1(("-f" "toggle-debug-on-error" "-eval" "(directory-files-recursively \"/tmp/c\" \"foo\")"))
  command-line()
  normal-top-level()

It's probably fine to have this behavior by default (some users might
want strict errors when some subdirectory couldn't be listed), but I
think the function should have an optional argument to control the
behavior.


In GNU Emacs 27.0.50 (build 9, x86_64-pc-linux-gnu, GTK+ Version 3.10.8)
 of 2017-09-23 built on localhost
Repository revision: b3541b3bc936bbb8e9950d1aed14d2571e03c1fe
Windowing system distributor 'The X.Org Foundation', version 11.0.11803000
System Description:	Ubuntu 14.04.5 LTS

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.

Configured using:
 'configure --enable-gtk-deprecation-warnings --with-modules
 --without-pop --with-mailutils --enable-checking
 --enable-check-lisp-object-type --enable-gcc-warnings 'CFLAGS=-ggdb3
 -O0''

Configured features:
XPM JPEG TIFF GIF PNG SOUND GSETTINGS NOTIFY GNUTLS FREETYPE XFT ZLIB
TOOLKIT_SCROLL_BARS GTK3 X11 MODULES

Important settings:
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message subr-x puny seq byte-opt gv
bytecomp byte-compile cconv cl-loaddefs cl-lib dired dired-loaddefs
format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg
epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode
mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047
rfc2045 ietf-drums mm-util mail-prsvr mail-utils elec-pair time-date
mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar
dnd fontset image regexp-opt fringe tabulated-list replace newcomment
text-mode elisp-mode lisp-mode prog-mode register page menu-bar
rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock
syntax facemenu font-core term/tty-colors frame cl-generic cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european
ethiopic indian cyrillic chinese composite charscript charprop
case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer
cl-preloaded nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote inotify dynamic-setting
system-font-setting font-render-setting move-toolbar gtk x-toolkit x
multi-tty make-network-process emacs)

Memory information:
((conses 16 94586 16063)
 (symbols 48 20149 1)
 (miscs 40 39 145)
 (strings 32 28105 1934)
 (string-bytes 1 729423)
 (vectors 16 13998)
 (vector-slots 8 488187 11155)
 (floats 8 48 76)
 (intervals 56 215 0)
 (buffers 992 12)
 (heap 1024 25933 976))

-- 
Google Germany GmbH
Erika-Mann-Straße 33
80636 München

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Paul Manicle, Halimah DeLaine Prado

If you received this communication by mistake, please don’t forward it to
anyone else (it may contain confidential or privileged information), please
erase all copies of it, including all attachments, and please let the sender
know it went to the wrong person.  Thanks.

bug#28567: 27.0.50; `directory-files-recursively' signals an error if there is some inaccessible subdirectory

[Lars Ingebrigtsen]

Philipp <p.stephani2@gmail.com> writes:

> mkdir c c/c
> chmod 0000 c/c
> emacs -Q -batch -f toggle-debug-on-error -eval '(directory-files-recursively "/tmp/c" "foo")'
> Debug on Error enabled globally
> Debugger entered--Lisp error: (file-error "Opening directory" "Permission denied" "/tmp/c/c")
>   file-name-all-completions("" "/tmp/c/c")
>   directory-files-recursively("/tmp/c/c" "foo" nil)
>   directory-files-recursively("/tmp/c" "foo")
>   eval((directory-files-recursively "/tmp/c" "foo"))
>   command-line-1(("-f" "toggle-debug-on-error" "-eval" "(directory-files-recursively \"/tmp/c\" \"foo\")"))
>   command-line()
>   normal-top-level()
>
> It's probably fine to have this behavior by default (some users might
> want strict errors when some subdirectory couldn't be listed), but I
> think the function should have an optional argument to control the
> behavior.

Yup.  I've now fixed this on the trunk -- there's now an optional
PREDICATE parameter that can be t for "ignore file-error".

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#28567: 27.0.50; `directory-files-recursively' signals an error if there is some inaccessible subdirectory

[Philipp Stephani]

Am Mo., 15. Juli 2019 um 11:53 Uhr schrieb Lars Ingebrigtsen <larsi@gnus.org>:
>
> Philipp <p.stephani2@gmail.com> writes:
>
> > mkdir c c/c
> > chmod 0000 c/c
> > emacs -Q -batch -f toggle-debug-on-error -eval '(directory-files-recursively "/tmp/c" "foo")'
> > Debug on Error enabled globally
> > Debugger entered--Lisp error: (file-error "Opening directory" "Permission denied" "/tmp/c/c")
> >   file-name-all-completions("" "/tmp/c/c")
> >   directory-files-recursively("/tmp/c/c" "foo" nil)
> >   directory-files-recursively("/tmp/c" "foo")
> >   eval((directory-files-recursively "/tmp/c" "foo"))
> >   command-line-1(("-f" "toggle-debug-on-error" "-eval" "(directory-files-recursively \"/tmp/c\" \"foo\")"))
> >   command-line()
> >   normal-top-level()
> >
> > It's probably fine to have this behavior by default (some users might
> > want strict errors when some subdirectory couldn't be listed), but I
> > think the function should have an optional argument to control the
> > behavior.
>
> Yup.  I've now fixed this on the trunk -- there's now an optional
> PREDICATE parameter that can be t for "ignore file-error".

Thanks!