From: Glenn Morris <rgm@gnu.org>
To: David Bremner <david@tethera.net>
Cc: 14345@debbugs.gnu.org
Subject: bug#14345: 24.3; shr-insert-document crashes gtk-emacs
Date: Tue, 07 May 2013 21:33:40 -0400 [thread overview]
Message-ID: <wo7gja8dcb.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <twmws61fwd.fsf@fencepost.gnu.org> (Glenn Morris's message of "Tue, 07 May 2013 20:20:18 -0400")
Maybe this fixes it:
*** src/image.c 2013-04-07 04:41:19 +0000
--- src/image.c 2013-05-08 01:25:15 +0000
***************
*** 7273,7292 ****
/* Clear the part of the screen image not covered by the image.
Full animated GIF support requires more here (see the gif89 spec,
disposal methods). Let's simply assume that the part not covered
! by a sub-image is in the frame's background color. */
! for (y = 0; y < img->corners[TOP_CORNER]; ++y)
for (x = 0; x < width; ++x)
XPutPixel (ximg, x, y, FRAME_BACKGROUND_PIXEL (f));
! for (y = img->corners[BOT_CORNER]; y < height; ++y)
for (x = 0; x < width; ++x)
XPutPixel (ximg, x, y, FRAME_BACKGROUND_PIXEL (f));
! for (y = img->corners[TOP_CORNER]; y < img->corners[BOT_CORNER]; ++y)
{
! for (x = 0; x < img->corners[LEFT_CORNER]; ++x)
XPutPixel (ximg, x, y, FRAME_BACKGROUND_PIXEL (f));
! for (x = img->corners[RIGHT_CORNER]; x < width; ++x)
XPutPixel (ximg, x, y, FRAME_BACKGROUND_PIXEL (f));
}
--- 7273,7297 ----
/* Clear the part of the screen image not covered by the image.
Full animated GIF support requires more here (see the gif89 spec,
disposal methods). Let's simply assume that the part not covered
! by a sub-image is in the frame's background color.
!
! Note that the corner position can be outside the screen, so take
! care not to go beyond the screen boundary (bug#14345).
! */
! for (y = 0; y < min (height, img->corners[TOP_CORNER]); ++y)
for (x = 0; x < width; ++x)
XPutPixel (ximg, x, y, FRAME_BACKGROUND_PIXEL (f));
! for (y = max (0, img->corners[BOT_CORNER]); y < height; ++y)
for (x = 0; x < width; ++x)
XPutPixel (ximg, x, y, FRAME_BACKGROUND_PIXEL (f));
! for (y = max (0, img->corners[TOP_CORNER]);
! min (height, y < img->corners[BOT_CORNER]); ++y)
{
! for (x = 0; x < min (width, img->corners[LEFT_CORNER]); ++x)
XPutPixel (ximg, x, y, FRAME_BACKGROUND_PIXEL (f));
! for (x = max (0, img->corners[RIGHT_CORNER]); x < width; ++x)
XPutPixel (ximg, x, y, FRAME_BACKGROUND_PIXEL (f));
}
next prev parent reply other threads:[~2013-05-08 1:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-04 2:43 bug#14345: 24.3; shr-insert-document crashes gtk-emacs David Bremner
[not found] ` <handler.14345.B.136763603414892.ack@debbugs.gnu.org>
2013-05-04 11:45 ` bug#14345: backtrace David Bremner
2013-05-08 0:20 ` bug#14345: 24.3; shr-insert-document crashes gtk-emacs Glenn Morris
2013-05-08 1:33 ` Glenn Morris [this message]
2013-05-08 1:35 ` Glenn Morris
2013-05-08 1:38 ` Glenn Morris
2013-05-08 1:44 ` Glenn Morris
2013-05-12 19:21 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wo7gja8dcb.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=14345@debbugs.gnu.org \
--cc=david@tethera.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).