From: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
To: Robert Pluim <rpluim@gmail.com>
Cc: tomekowal@gmail.com, 39164@debbugs.gnu.org, jguenther@gmail.com
Subject: bug#39164: 27.0.60; Intermittent crash on MacOS 10.14 in setup_process_coding_systems
Date: Tue, 28 Jan 2020 17:23:25 +0900 [thread overview]
Message-ID: <wlzhe8q9aa.wl-mituharu@math.s.chiba-u.ac.jp> (raw)
In-Reply-To: <m2lfpsj9js.fsf@gmail.com>
On Tue, 28 Jan 2020 16:59:35 +0900,
Robert Pluim wrote:
>
> >>>>> On Mon, 27 Jan 2020 20:19:07 +0200, Eli Zaretskii <eliz@gnu.org> said:
>
> >> Date: Mon, 27 Jan 2020 22:26:10 +0900
> >> From: mituharu@math.s.chiba-u.ac.jp
> >> Cc: "Eli Zaretskii" <eliz@gnu.org>,
> >> jguenther@gmail.com,
> >> "Tomasz Kowal" <tomekowal@gmail.com>,
> >> 39164@debbugs.gnu.org
> >>
> >> This is a variant of Bug#24325: Crash - fd larger than FD_SETSIZE.
> >> Some functions in the Core Foundation framework on macOS
> >> call setrlimit for RLIMIT_NOFILE in order to increase the limit of
> >> the maximum number of open files for the process:
> >>
> >> https://opensource.apple.com/source/CF/CF-1153.18/CFSocket.c.auto.html
> >>
> >> So the fix for Bug#24325 doesn't work in this case.
>
> Eli> Thanks.
>
> Eli> So I guess one possible solution would be to see that fd is beyond
> Eli> FD_SETSIZE, and if so, call getrlimit to see if the limit was bumped
> Eli> up, and if so, reallocate the arrays used by process.c? Would that
> Eli> make sense?
>
> This will break {p}select, no? Thatʼs defined to only work up to
> FD_SETSIZE.
Yes. I'm currently thinking about adding the following workaround to
the next release of the Mac port. It is not a perfect solution, but
the Mac port is still based on Emacs 26, and I don't want to make a
drastic change there.
YAMAMOTO Mitsuharu
mituharu@math.s.chiba-u.ac.jp
diff --git a/src/macappkit.m b/src/macappkit.m
index d2647aff97..08a7e6bc9b 100644
--- a/src/macappkit.m
+++ b/src/macappkit.m
@@ -1337,6 +1337,21 @@ - (void)applicationDidFinishLaunching:(NSNotification *)notification
setenv ("CAVIEW_USE_GL", "1", 0);
#endif
+ /* Some functions/methods in CoreFoundation/Foundation increase the
+ maximum number of open files for the process in their first call.
+ We make dummy calls to them and then reduce the resource limit
+ here, since pselect cannot handle file descriptors that are
+ greater than or equal to FD_SETSIZE. */
+ CFSocketGetTypeID ();
+ CFFileDescriptorGetTypeID ();
+ MRC_RELEASE ([[NSFileHandle alloc] init]);
+ struct rlimit rlim;
+ if (getrlimit (RLIMIT_NOFILE, &rlim) == 0 && rlim.rlim_cur > FD_SETSIZE)
+ {
+ rlim.rlim_cur = FD_SETSIZE;
+ setrlimit (RLIMIT_NOFILE, &rlim);
+ }
+
/* Exit from the main event loop. */
[NSApp stop:nil];
[NSApp postDummyEvent];
next prev parent reply other threads:[~2020-01-28 8:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 19:00 bug#39164: 27.0.60; Intermittent crash on MacOS 10.14 in setup_process_coding_systems Justin Guenther
2020-01-17 21:01 ` Eli Zaretskii
2020-01-20 9:15 ` Robert Pluim
2020-01-20 18:00 ` Eli Zaretskii
2020-01-20 18:42 ` Robert Pluim
2020-01-27 13:26 ` mituharu
2020-01-27 18:19 ` Eli Zaretskii
2020-01-28 7:59 ` Robert Pluim
2020-01-28 8:23 ` YAMAMOTO Mitsuharu [this message]
2020-01-28 8:41 ` Robert Pluim
2020-01-28 9:02 ` Eli Zaretskii
2020-01-28 9:14 ` YAMAMOTO Mitsuharu
2020-01-28 9:42 ` Eli Zaretskii
2020-01-28 10:06 ` YAMAMOTO Mitsuharu
2020-01-28 17:37 ` Eli Zaretskii
2020-01-29 10:26 ` YAMAMOTO Mitsuharu
2020-01-29 11:09 ` Eli Zaretskii
2020-01-29 12:38 ` Eli Zaretskii
2020-01-30 9:42 ` YAMAMOTO Mitsuharu
2020-01-30 14:49 ` Eli Zaretskii
2020-01-26 17:41 ` bug#39164: Reproducing SIGSEGV bug Tomasz Kowal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wlzhe8q9aa.wl-mituharu@math.s.chiba-u.ac.jp \
--to=mituharu@math.s.chiba-u.ac.jp \
--cc=39164@debbugs.gnu.org \
--cc=jguenther@gmail.com \
--cc=rpluim@gmail.com \
--cc=tomekowal@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).