* bug#1236: ispell-complete-word / key binding not shown in menu [not found] <18945223.post@talk.nabble.com> @ 2008-10-24 2:31 ` David Reitter 2008-10-24 4:18 ` Glenn Morris 2009-01-22 12:35 ` bug#1236: marked as done (ispell-complete-word / key binding not shown in menu) Emacs bug Tracking System 0 siblings, 2 replies; 9+ messages in thread From: David Reitter @ 2008-10-24 2:31 UTC (permalink / raw) To: emacs-pretest-bug [-- Attachment #1: Type: text/plain, Size: 1039 bytes --] `ispell-complete-word' appears in the Spell Checking menu and is, in text-mode at least, bound to M-TAB, as C-h f/k will show. However, it does not have its key binding listed in the menu. Listing the correct key bindings in the menus is important - it's pretty difficult for newbies to learn these things otherwise. This occurs with the old Carbon port (22) and with a recent build of Cocoa (23). Begin forwarded message: > From: dranorter <dranorter@gmail.com> > Date: 12 August 2008 10:19:33 EDT > To: aquamacs-bugs@aquamacs.org > Subject: Re: [Aquamacs-bugs] Random aquamacs impressions > > >>> - Some of the menus don't have keyboard shortcuts listed. >> Is that because the associated functions have no key bindings, or are >> the shortcut indicators genuinely missing? (Either is possible.) > > I was thinking of edit > complete word, which doesn't have a > key binding. It would have been helpful to me at the time to > still have M-x ispell-complete-word listed but of course there > wouldn't be room, so whatever. [-- Attachment #2: smime.p7s --] [-- Type: application/pkcs7-signature, Size: 2193 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#1236: ispell-complete-word / key binding not shown in menu 2008-10-24 2:31 ` bug#1236: ispell-complete-word / key binding not shown in menu David Reitter @ 2008-10-24 4:18 ` Glenn Morris 2008-10-24 4:30 ` Processed: " Emacs bug Tracking System 2008-10-25 8:37 ` YAMAMOTO Mitsuharu 2009-01-22 12:35 ` bug#1236: marked as done (ispell-complete-word / key binding not shown in menu) Emacs bug Tracking System 1 sibling, 2 replies; 9+ messages in thread From: Glenn Morris @ 2008-10-24 4:18 UTC (permalink / raw) To: David Reitter; +Cc: 1236 reassign 1236 emacs,ns stop David Reitter wrote: > `ispell-complete-word' appears in the Spell Checking menu and is, in > text-mode at least, bound to M-TAB, as C-h f/k will show. However, it > does not have its key binding listed in the menu. Works fine in GNU/Linux: emacs -Q M-x text-mode Tools -> Spell Checking -> "Complete Word" has M-TAB binding displayed M-x lisp-mode -> "Complete Word" has no keybinding, none displayed > Listing the correct key bindings in the menus is important - it's > pretty difficult for newbies to learn these things otherwise. Hopefully they learn about C-h k. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Processed: Re: bug#1236: ispell-complete-word / key binding not shown in menu 2008-10-24 4:18 ` Glenn Morris @ 2008-10-24 4:30 ` Emacs bug Tracking System 2008-10-25 8:37 ` YAMAMOTO Mitsuharu 1 sibling, 0 replies; 9+ messages in thread From: Emacs bug Tracking System @ 2008-10-24 4:30 UTC (permalink / raw) To: Glenn Morris; +Cc: Emacs Bugs, ns #1236 Processing commands for control@emacsbugs.donarmstrong.com: > reassign 1236 emacs,ns bug#1236: ispell-complete-word / key binding not shown in menu Warning: Unknown package 'ns' bug reassigned from package `emacs' to `emacs,ns'. > stop Stopping processing here. Please contact me if you need assistance. Don Armstrong (administrator, Emacs bugs database) ^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#1236: ispell-complete-word / key binding not shown in menu 2008-10-24 4:18 ` Glenn Morris 2008-10-24 4:30 ` Processed: " Emacs bug Tracking System @ 2008-10-25 8:37 ` YAMAMOTO Mitsuharu 2008-10-25 18:45 ` Glenn Morris 1 sibling, 1 reply; 9+ messages in thread From: YAMAMOTO Mitsuharu @ 2008-10-25 8:37 UTC (permalink / raw) To: Glenn Morris, 1236 >>>>> On Fri, 24 Oct 2008 00:18:05 -0400, Glenn Morris <rgm@gnu.org> said: >> `ispell-complete-word' appears in the Spell Checking menu and is, in >> text-mode at least, bound to M-TAB, as C-h f/k will show. However, it >> does not have its key binding listed in the menu. > Works fine in GNU/Linux: > emacs -Q > M-x text-mode > Tools -> Spell Checking > -> "Complete Word" has M-TAB binding displayed > M-x lisp-mode > -> "Complete Word" has no keybinding, none displayed Probably you tried with Emacs 23, and Emacs 22 on GNU/Linux would behave as OP described. I think the following change made the difference. 2008-05-16 Stefan Monnier <monnier@iro.umontreal.ca> * keyboard.c (parse_menu_item): Do not cache key shortcut any more. YAMAMOTO Mitsuharu mituharu@math.s.chiba-u.ac.jp ^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#1236: ispell-complete-word / key binding not shown in menu 2008-10-25 8:37 ` YAMAMOTO Mitsuharu @ 2008-10-25 18:45 ` Glenn Morris 2008-10-25 21:27 ` David Reitter 2008-10-26 4:18 ` YAMAMOTO Mitsuharu 0 siblings, 2 replies; 9+ messages in thread From: Glenn Morris @ 2008-10-25 18:45 UTC (permalink / raw) To: YAMAMOTO Mitsuharu; +Cc: 1236 YAMAMOTO Mitsuharu wrote: > Probably you tried with Emacs 23, and Emacs 22 on GNU/Linux would > behave as OP described. I did indeed, since Emacs 22 is dead, and the problem was also said to occur with "a recent build of Cocoa (23)". Does it? (I can't build that.) ^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#1236: ispell-complete-word / key binding not shown in menu 2008-10-25 18:45 ` Glenn Morris @ 2008-10-25 21:27 ` David Reitter 2008-10-26 4:18 ` YAMAMOTO Mitsuharu 1 sibling, 0 replies; 9+ messages in thread From: David Reitter @ 2008-10-25 21:27 UTC (permalink / raw) To: Glenn Morris; +Cc: 1236 [-- Attachment #1: Type: text/plain, Size: 764 bytes --] On 25 Oct 2008, at 14:45, Glenn Morris wrote: > YAMAMOTO Mitsuharu wrote: > >> Probably you tried with Emacs 23, and Emacs 22 on GNU/Linux would >> behave as OP described. > > I did indeed, since Emacs 22 is dead, and the problem was also said to > occur with "a recent build of Cocoa (23)". Does it? (I can't build > that.) In general: given that there are tens if not hundreds of thousands of users out there on Emacs 22, with stopping to fix bugs we're not doing ourselves a favor. Applying Stefan's patch (which just turns off this cache) causes a crash while building (before dumping), which I don't have the chance to investigate further. Indeed, the key hint problem occurred with 23 as well, so perhaps we should fix it on that end first. [-- Attachment #2: smime.p7s --] [-- Type: application/pkcs7-signature, Size: 2193 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#1236: ispell-complete-word / key binding not shown in menu 2008-10-25 18:45 ` Glenn Morris 2008-10-25 21:27 ` David Reitter @ 2008-10-26 4:18 ` YAMAMOTO Mitsuharu 2008-10-26 13:56 ` David Reitter 1 sibling, 1 reply; 9+ messages in thread From: YAMAMOTO Mitsuharu @ 2008-10-26 4:18 UTC (permalink / raw) To: Glenn Morris; +Cc: 1236 >>>>> On Sat, 25 Oct 2008 14:45:52 -0400, Glenn Morris <rgm@gnu.org> said: >> Probably you tried with Emacs 23, and Emacs 22 on GNU/Linux would >> behave as OP described. > I did indeed, since Emacs 22 is dead, and the problem was also said > to occur with "a recent build of Cocoa (23)". Does it? (I can't > build that.) Menus in the Cocoa/GNUstep port doesn't show key bindings as in other platforms (at least by default) in the first place. YAMAMOTO Mitsuharu mituharu@math.s.chiba-u.ac.jp ^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#1236: ispell-complete-word / key binding not shown in menu 2008-10-26 4:18 ` YAMAMOTO Mitsuharu @ 2008-10-26 13:56 ` David Reitter 0 siblings, 0 replies; 9+ messages in thread From: David Reitter @ 2008-10-26 13:56 UTC (permalink / raw) To: YAMAMOTO Mitsuharu, Adrian Robert; +Cc: 1236 [-- Attachment #1: Type: text/plain, Size: 889 bytes --] On 26 Oct 2008, at 00:18, YAMAMOTO Mitsuharu wrote: >>>>>> On Sat, 25 Oct 2008 14:45:52 -0400, Glenn Morris <rgm@gnu.org> >>>>>> said: > >>> Probably you tried with Emacs 23, and Emacs 22 on GNU/Linux would >>> behave as OP described. > >> I did indeed, since Emacs 22 is dead, and the problem was also said >> to occur with "a recent build of Cocoa (23)". Does it? (I can't >> build that.) > > Menus in the Cocoa/GNUstep port doesn't show key bindings as in other > platforms (at least by default) in the first place. Using the 23 code that turns off caching of key binding hints does fix the problem in 22 Carbon Emacs. 23 Cocoa has a different problem with key bindings. No key binding is displayed here: (defun foo () (interactive)) (global-set-key "\M-p" 'foo) (define-key menu-bar-file-menu [new-file] '(menu-item "Foo!" foo)) (ns-reset-menu) ;; doesn't help [-- Attachment #2: smime.p7s --] [-- Type: application/pkcs7-signature, Size: 2193 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#1236: marked as done (ispell-complete-word / key binding not shown in menu) 2008-10-24 2:31 ` bug#1236: ispell-complete-word / key binding not shown in menu David Reitter 2008-10-24 4:18 ` Glenn Morris @ 2009-01-22 12:35 ` Emacs bug Tracking System 1 sibling, 0 replies; 9+ messages in thread From: Emacs bug Tracking System @ 2009-01-22 12:35 UTC (permalink / raw) To: Adrian Robert [-- Attachment #1: Type: text/plain, Size: 910 bytes --] Your message dated Thu, 22 Jan 2009 14:26:27 +0200 with message-id <A1DC42C3-CD46-4333-87FA-7B7F59794F14@gmail.com> and subject line Re: ispell-complete-word / key binding not shown in menu has caused the Emacs bug report #1236, regarding ispell-complete-word / key binding not shown in menu to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) -- 1236: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1236 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems [-- Attachment #2: Type: message/rfc822, Size: 7521 bytes --] [-- Attachment #2.1.1: Type: text/plain, Size: 1039 bytes --] `ispell-complete-word' appears in the Spell Checking menu and is, in text-mode at least, bound to M-TAB, as C-h f/k will show. However, it does not have its key binding listed in the menu. Listing the correct key bindings in the menus is important - it's pretty difficult for newbies to learn these things otherwise. This occurs with the old Carbon port (22) and with a recent build of Cocoa (23). Begin forwarded message: > From: dranorter <dranorter@gmail.com> > Date: 12 August 2008 10:19:33 EDT > To: aquamacs-bugs@aquamacs.org > Subject: Re: [Aquamacs-bugs] Random aquamacs impressions > > >>> - Some of the menus don't have keyboard shortcuts listed. >> Is that because the associated functions have no key bindings, or are >> the shortcut indicators genuinely missing? (Either is possible.) > > I was thinking of edit > complete word, which doesn't have a > key binding. It would have been helpful to me at the time to > still have M-x ispell-complete-word listed but of course there > wouldn't be room, so whatever. [-- Attachment #2.1.2: smime.p7s --] [-- Type: application/pkcs7-signature, Size: 2193 bytes --] [-- Attachment #3: Type: message/rfc822, Size: 2854 bytes --] From: Adrian Robert <adrian.b.robert@gmail.com> To: 1236-done@emacsbugs.donarmstrong.com Subject: Re: ispell-complete-word / key binding not shown in menu Date: Thu, 22 Jan 2009 14:26:27 +0200 Message-ID: <A1DC42C3-CD46-4333-87FA-7B7F59794F14@gmail.com> Fixed 2009/01/22 with changes to nsmenu.m: EmacsMenu. Non-super keybindings are displayed as strings appended in parentheses, as in "Visit New File... (C-x C-f)". This is ugly, however it seems that NSMenuItem will not accept multi-character strings for keyEquivalent. If anyone can improve upon / work around this situation please go ahead. ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2009-01-22 12:35 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- [not found] <18945223.post@talk.nabble.com> 2008-10-24 2:31 ` bug#1236: ispell-complete-word / key binding not shown in menu David Reitter 2008-10-24 4:18 ` Glenn Morris 2008-10-24 4:30 ` Processed: " Emacs bug Tracking System 2008-10-25 8:37 ` YAMAMOTO Mitsuharu 2008-10-25 18:45 ` Glenn Morris 2008-10-25 21:27 ` David Reitter 2008-10-26 4:18 ` YAMAMOTO Mitsuharu 2008-10-26 13:56 ` David Reitter 2009-01-22 12:35 ` bug#1236: marked as done (ispell-complete-word / key binding not shown in menu) Emacs bug Tracking System
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).