From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: YAMAMOTO Mitsuharu Newsgroups: gmane.emacs.bugs Subject: bug#57976: 29.0.50; Complex emoji have extra spacing Date: Thu, 22 Sep 2022 11:00:15 +0900 Organization: Faculty of Science, Chiba University Message-ID: References: <87h711kp4r.fsf@protesilaos.com> <87a66t9fzf.fsf@gnus.org> <87wn9xypek.fsf@protesilaos.com> <87wn9x80dh.fsf@gnus.org> <87o7v8q2y8.fsf@protesilaos.com> <877d1wam0p.fsf@gnus.org> <87illgq1qf.fsf@protesilaos.com> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22767"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?Q?Goj=C5=8D?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) Cc: Lars Ingebrigtsen , 57976@debbugs.gnu.org To: Protesilaos Stavrou Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 22 04:01:11 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1obBWZ-0005nP-KM for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 22 Sep 2022 04:01:11 +0200 Original-Received: from localhost ([::1]:55568 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1obBWY-0003Nk-Jx for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Sep 2022 22:01:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50486) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1obBWQ-0003Nc-G2 for bug-gnu-emacs@gnu.org; Wed, 21 Sep 2022 22:01:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36500) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1obBWQ-0000zM-6p for bug-gnu-emacs@gnu.org; Wed, 21 Sep 2022 22:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1obBWQ-0006Jg-1g for bug-gnu-emacs@gnu.org; Wed, 21 Sep 2022 22:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: YAMAMOTO Mitsuharu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Sep 2022 02:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57976 X-GNU-PR-Package: emacs Original-Received: via spool by 57976-submit@debbugs.gnu.org id=B57976.166381202224208 (code B ref 57976); Thu, 22 Sep 2022 02:01:02 +0000 Original-Received: (at 57976) by debbugs.gnu.org; 22 Sep 2022 02:00:22 +0000 Original-Received: from localhost ([127.0.0.1]:35578 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1obBVm-0006IN-8G for submit@debbugs.gnu.org; Wed, 21 Sep 2022 22:00:22 -0400 Original-Received: from mathmail.math.s.chiba-u.ac.jp ([133.82.132.2]:60139) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1obBVj-0006IA-KD for 57976@debbugs.gnu.org; Wed, 21 Sep 2022 22:00:20 -0400 Original-Received: from mathent.math.s.chiba-u.ac.jp (mathent [192.168.32.5]) by mathmail.math.s.chiba-u.ac.jp (Postfix) with ESMTP id E1FE6F08E8; Thu, 22 Sep 2022 11:00:15 +0900 (JST) (envelope-from mituharu@math.s.chiba-u.ac.jp) In-Reply-To: <87illgq1qf.fsf@protesilaos.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243379 Archived-At: On Wed, 21 Sep 2022 22:46:32 +0900, Protesilaos Stavrou wrote: >=20 > > From: Lars Ingebrigtsen > > Date: Wed, 21 Sep 2022 15:35:02 +0200 > > > > Protesilaos Stavrou writes: > > > >> I have no reproducible recipe with harfbuzz 5.2.0 beside Emacs. I wro= te > >> the M-x emoji-list buffer to a file and visited it with a generic text > >> editor: the display looks fine. > > > > If you take one of the emojis that displayed correctly and one that was > > wrong and then say > > > > (string-pixel-width "=F0=9F=98=B6=E2=80=8D=F0=9F=8C=AB=EF=B8=8F") > > > > on both -- what does that return? From the display, it kinda looked > > like Emacs thought that some of the glyphs were really wide. >=20 > I get these: >=20 > (string-pixel-width "=F0=9F=98=B6=E2=80=8D=F0=9F=8C=AB=EF=B8=8F") > ;; =3D> 136 >=20 > (string-pixel-width "=F0=9F=A4=A3") > ;; =3D> 16 Hmm, the fix for Bug#57066 needs to be undone for HarfBuzz 5.2.0. YAMAMOTO Mitsuharu mituharu@math.s.chiba-u.ac.jp diff --git a/src/ftcrfont.c b/src/ftcrfont.c index e089f9dea8..a02ff99870 100644 --- a/src/ftcrfont.c +++ b/src/ftcrfont.c @@ -679,8 +679,12 @@ ftcrhbfont_begin_hb_font (struct font *font, double *p= osition_unit) hb_font_t *hb_font =3D fthbfont_begin_hb_font (font, position_unit); /* HarfBuzz 5 correctly scales bitmap-only fonts without position unit adjustment. - (https://github.com/harfbuzz/harfbuzz/issues/489) */ - if (!hb_version_atleast (5, 0, 0) + (https://github.com/harfbuzz/harfbuzz/issues/489) + + Update: HarfBuzz 5.2.0 no longer does this for an hb_font_t font + object created from a given FT_Face. + (https://github.com/harfbuzz/harfbuzz/issues/3788) */ + if ((hb_version_atleast (5, 2, 0) || !hb_version_atleast (5, 0, 0)) && ftcrfont_info->bitmap_position_unit) *position_unit =3D ftcrfont_info->bitmap_position_unit; =20