From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: YAMAMOTO Mitsuharu Newsgroups: gmane.emacs.bugs,gmane.emacs.pretest.bugs,gmane.emacs.macintosh.carbon-emacs Subject: bug#527: input-input-method / Many crashes / Japanese input Date: Fri, 04 Jul 2008 12:29:46 +0900 Organization: Faculty of Science, Chiba University Message-ID: References: <18540.41308.57261.183352@castalia.local> <307A5450-EC7A-487D-8DD1-4C14BF746E47@gmail.com> Reply-To: YAMAMOTO Mitsuharu , 527@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1215143279 22253 80.91.229.12 (4 Jul 2008 03:47:59 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 4 Jul 2008 03:47:59 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org, carbon-emacs@googlegroups.com, Jose Figueroa-O'Farrill To: David Reitter , 527@emacsbugs.donarmstrong.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 04 05:48:45 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KEcHq-0007Rl-Gx for geb-bug-gnu-emacs@m.gmane.org; Fri, 04 Jul 2008 05:48:43 +0200 Original-Received: from localhost ([127.0.0.1]:57915 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KEcGz-00053h-2H for geb-bug-gnu-emacs@m.gmane.org; Thu, 03 Jul 2008 23:47:49 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KEcGd-0004mf-NN for bug-gnu-emacs@gnu.org; Thu, 03 Jul 2008 23:47:27 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KEcGa-0004jy-2G for bug-gnu-emacs@gnu.org; Thu, 03 Jul 2008 23:47:27 -0400 Original-Received: from [199.232.76.173] (port=38159 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KEcGZ-0004jS-Fw for bug-gnu-emacs@gnu.org; Thu, 03 Jul 2008 23:47:23 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:36473) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KEcGW-0007o4-Fq for bug-gnu-emacs@gnu.org; Thu, 03 Jul 2008 23:47:22 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m643lDWd007204; Thu, 3 Jul 2008 20:47:13 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m643Z6Qt003907; Thu, 3 Jul 2008 20:35:06 -0700 X-Loop: don@donarmstrong.com Resent-From: YAMAMOTO Mitsuharu Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Fri, 04 Jul 2008 03:35:05 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 527 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 527-submit@emacsbugs.donarmstrong.com id=B527.12151421912487 (code B ref 527); Fri, 04 Jul 2008 03:35:05 +0000 Original-Received: (at 527) by emacsbugs.donarmstrong.com; 4 Jul 2008 03:29:51 +0000 Original-Received: from mathmail.math.s.chiba-u.ac.jp (mathmail.math.s.chiba-u.ac.jp [133.82.132.2]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m643Tl9Q002459 for <527@emacsbugs.donarmstrong.com>; Thu, 3 Jul 2008 20:29:48 -0700 Original-Received: from church.math.s.chiba-u.ac.jp (church [133.82.132.36]) by mathmail.math.s.chiba-u.ac.jp (Postfix) with ESMTP id 391362C40; Fri, 4 Jul 2008 12:29:46 +0900 (JST) In-Reply-To: <307A5450-EC7A-487D-8DD1-4C14BF746E47@gmail.com> User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 =?UTF-8?Q?(Shij=C5=8D)?= APEL/10.6 Emacs/23.0.50 (sparc-sun-solaris2.8) MULE/5.0 (SAKAKI) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Resent-Date: Thu, 03 Jul 2008 23:47:27 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:18639 gmane.emacs.pretest.bugs:22708 gmane.emacs.macintosh.carbon-emacs:951 Archived-At: >>>>> On Thu, 3 Jul 2008 11:45:07 +0100, David Reitter said: > Begin forwarded message: >> From: "Jose Figueroa-O'Farrill" >> Date: 3 July 2008 10:52:27 BST >> To: aquamacs-bugs@aquamacs.org >> Subject: [Aquamacs-bugs] Many crashes in 1.4 >> Reply-To: j.m.figueroa@ed.ac.uk >>=20 >>=20 >> Hi, >>=20 >> It's the third time that Aquamacs 1.4 crashes while typing. This >> had not happened in a looooong time. This time I managed to save the >> crash report which I include below. I'm afraid that I don't know how >> to reproduce it. >>=20 >> Cheers, Jos=E9 >>=20 >>=20 >> Date/Time: 2008-07-02 23:06:09.682 +0200 >> OS Version: 10.4.11 (Build 8S165) >> Report Version: 4 >>=20 >> Command: Aquamacs Emacs >> Path: /Applications/Aquamacs Emacs.app/Contents/MacOS/Aquamacs =20 >> Emacs >> Parent: WindowServer [62] >>=20 >> Version: Aquamacs 1.4, GNU Emacs 22 () >>=20 >> PID: 14598 >> Thread: 0 >>=20 >> Exception: EXC_BAD_ACCESS (0x0001) >> Codes: KERN_PROTECTION_FAILURE (0x0002) at 0x00000008 >>=20 >> Thread 0 Crashed: >> 0 org.gnu.AquamacsEmacs 0x00175138 =20 >> mac_handle_text_input_event + 1720 (snip) >> Thread 0 crashed with PPC Thread State 64: >> r4: 0x0000000000000000 r5: 0x00000000081f0800 r6: =20 >> 0x0000000000000000 r7: 0x0000000000000059 If your object file is not much different from mine, the crash seems to happen just before a call to Long2Fix. _mac_handle_text_input_event: +1708 00000a6c 81230008 lwz r9,0x8(r3) +1712 00000a70 5402103a rlwinm r2,r0,2,0,29 +1716 00000a74 7cc2482e lwzx r6,r2,r9 +1720 00000a78 83a60008 lwz r29,0x8(r6) +1724 00000a7c 2f9d0000 cmpwi cr7,r29,0x0 +1728 00000a80 419efe88 beq cr7,0x908 +1732 00000a84 807d0008 lwz r3,0x8(r29) +1736 00000a88 48008959 bl 0x93e0 _Long2Fix Could you try the patch below? YAMAMOTO Mitsuharu mituharu@math.s.chiba-u.ac.jp Index: src/mactoolbox.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvsroot/emacs/emacs/src/mactoolbox.c,v retrieving revision 1.1.2.4 diff -c -p -r1.1.2.4 mactoolbox.c *** src/mactoolbox.c 23 Apr 2008 08:56:20 -0000 1.1.2.4 --- src/mactoolbox.c 4 Jul 2008 03:20:27 -0000 *************** mac_handle_text_input_event (next_handle *** 575,581 **** int hpos, vpos, x, y; struct glyph_row *row; struct glyph *glyph; ! XFontStruct *font; =20 f =3D mac_focus_frame (&one_mac_display_info); w =3D XWINDOW (f->selected_window); --- 575,581 ---- int hpos, vpos, x, y; struct glyph_row *row; struct glyph *glyph; ! struct face *face; =20 f =3D mac_focus_frame (&one_mac_display_info); w =3D XWINDOW (f->selected_window); *************** mac_handle_text_input_event (next_handle *** 600,608 **** + row->visible_height + f->top_pos + FRAME_OUTER_TO_INNER_DIFF_Y (f)); =20 ! font =3D FACE_FROM_ID (f, glyph->face_id)->font; ! if (font) { Fixed point_size =3D Long2Fix (font->mac_fontsize); short height =3D row->visible_height; short ascent =3D row->ascent; --- 600,609 ---- + row->visible_height + f->top_pos + FRAME_OUTER_TO_INNER_DIFF_Y (f)); =20 ! face =3D FACE_FROM_ID (f, glyph->face_id); ! if (face && face->font) { + XFontStruct *font =3D face->font; Fixed point_size =3D Long2Fix (font->mac_fontsize); short height =3D row->visible_height; short ascent =3D row->ascent;