From: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: "öran Uddeborg" <goeran@uddeborg.se>,
bug-gnu-emacs@gnu.org, 38-done@emacsbugs.donarmstrong.com
Subject: Re: No coding system used for environment variables
Date: Fri, 07 Mar 2008 21:12:35 +0900 [thread overview]
Message-ID: <wlmypa20ng.wl%mituharu@math.s.chiba-u.ac.jp> (raw)
In-Reply-To: <jwvir01kuj0.fsf-monnier+emacs@gnu.org>
>>>>> On Wed, 05 Mar 2008 11:25:59 -0500, Stefan Monnier <monnier@iro.umontreal.ca> said:
>> But I'd strongly suggest to revert this changes at this timing of
>> pretest for upcoming Emacs 22.2. First, some coding systems are
>> not ready until some .elc files get loaded (a chicken-and-egg
>> problem). Second, as DECODE_FILE causes GC and string compaction
>> in general, some variables such as `nm' in Fexpand_file_name may
>> not point to valid data after that. You may also want to see a
>> related patch in
>> http://lists.gnu.org/archive/html/emacs-pretest-bug/2007-05/msg00115.html
> How 'bout installing this change on the trunk?
While I was looking at the code of Fsubstitute_in_file_name to
make the patch for the trunk, I noticed that it contains a danger
of destination buffer shortage in both the EMACS_22_BASE branch
and the trunk.
*** src/fileio.c.~1.580.2.10.~ Thu Mar 6 09:44:27 2008
--- src/fileio.c Fri Mar 7 20:55:26 2008
***************
*** 2227,2233 ****
o = (unsigned char *) egetenv (target);
if (o)
{
! total += strlen (o);
substituted = 1;
}
else if (*p == '}')
--- 2227,2238 ----
o = (unsigned char *) egetenv (target);
if (o)
{
! if (STRING_MULTIBYTE (filename))
! /* A unibyte character may occupy 2 bytes when converted
! to multibyte. */
! total += strlen (o) * 2;
! else
! total += strlen (o);
substituted = 1;
}
else if (*p == '}')
As I can't install it too soon, please install it to EMACS_22_BASE if
the next pretest is out shortly (and if the patch looks good, of
course.)
YAMAMOTO Mitsuharu
mituharu@math.s.chiba-u.ac.jp
prev parent reply other threads:[~2008-03-07 12:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-21 21:40 No coding system used for environment variables Göran Uddeborg
2008-03-05 0:40 ` Jason Rumney
2008-03-05 2:22 ` YAMAMOTO Mitsuharu
2008-03-05 8:57 ` Jason Rumney
2008-03-05 9:16 ` YAMAMOTO Mitsuharu
2008-03-05 10:11 ` Jason Rumney
2008-03-05 11:00 ` YAMAMOTO Mitsuharu
2008-03-05 10:34 ` Andreas Schwab
2008-03-05 16:25 ` Stefan Monnier
2008-03-07 12:12 ` YAMAMOTO Mitsuharu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wlmypa20ng.wl%mituharu@math.s.chiba-u.ac.jp \
--to=mituharu@math.s.chiba-u.ac.jp \
--cc=38-done@emacsbugs.donarmstrong.com \
--cc=bug-gnu-emacs@gnu.org \
--cc=goeran@uddeborg.se \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).