From: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
To: Aaron Jensen <aaronjensen@gmail.com>
Cc: 26397@debbugs.gnu.org, Alan Third <alan@idiocy.org>
Subject: bug#26397: [PATCH] Use vfork if possible on Darwin (bug#26397)
Date: Mon, 10 Apr 2017 10:11:16 +0900 [thread overview]
Message-ID: <wlmvbpnk23.wl%mituharu@math.s.chiba-u.ac.jp> (raw)
In-Reply-To: <CAHyO48wHFhNV0QLeuwNdExJ0w0EgV4Z0rn6quxwndCBOYTew_A@mail.gmail.com>
>>>>> On Sun, 9 Apr 2017 17:06:21 -0700, Aaron Jensen <aaronjensen@gmail.com> said:
> For me, this slows down call-process in TTY emacs by 3ms (from
> 2.5ms->5.5ms). I typically launch a GUI emacs and connect to the
> server in TTY via emacsclient, and in that scenario this patch does
> not slow down call-process in the TTY, but it will affect those who
> use TTY only, it seems.
Then use "obsolete" ioctl TIOCNOTTY instead of setsid? I'm not
familiar with this matter, so could someone check if this is OK? I
confirmed that only the controlling terminal of the child process was
detached.
YAMAMOTO Mitsuharu
mituharu@math.s.chiba-u.ac.jp
diff --git a/src/callproc.c b/src/callproc.c
index 05048576ce..3f6df422f3 100644
--- a/src/callproc.c
+++ b/src/callproc.c
@@ -52,6 +52,8 @@ along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>. */
#include "syswait.h"
#include "blockinput.h"
#include "frame.h"
+#include "systty.h"
+#include "keyboard.h"
#ifdef MSDOS
#include "msdos.h"
@@ -626,7 +628,18 @@ call_process (ptrdiff_t nargs, Lisp_Object *args, int filefd,
{
unblock_child_signal (&oldset);
+#ifdef DARWIN_OS
+ /* Darwin doesn't let us run setsid after a vfork, so use
+ TIOCNOTTY when necessary. */
+ int j = emacs_open (DEV_TTY, O_RDWR, 0);
+ if (j >= 0)
+ {
+ ioctl (j, TIOCNOTTY, 0);
+ emacs_close (j);
+ }
+#else
setsid ();
+#endif
/* Emacs ignores SIGPIPE, but the child should not. */
signal (SIGPIPE, SIG_DFL);
next prev parent reply other threads:[~2017-04-10 1:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-08 6:25 bug#26397: 25.1; call-process slow on macOS and slower on larger frames Aaron Jensen
2017-04-08 7:37 ` YAMAMOTO Mitsuharu
2017-04-08 15:47 ` Aaron Jensen
2017-04-08 19:19 ` Alan Third
2017-04-09 13:01 ` Alan Third
2017-04-09 15:07 ` Aaron Jensen
2017-04-09 19:18 ` bug#26397: [PATCH] Use vfork if possible on Darwin (bug#26397) Alan Third
2017-04-09 20:32 ` Andreas Schwab
2017-04-09 21:34 ` Alan Third
2017-04-09 23:46 ` YAMAMOTO Mitsuharu
2017-04-10 0:06 ` Aaron Jensen
2017-04-10 1:11 ` YAMAMOTO Mitsuharu [this message]
2017-04-10 4:13 ` Aaron Jensen
2017-04-10 15:42 ` bug#26397: [PATCH v2] " Alan Third
2017-04-11 7:06 ` YAMAMOTO Mitsuharu
2017-04-18 2:29 ` Aaron Jensen
2017-04-18 10:48 ` Alan Third
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wlmvbpnk23.wl%mituharu@math.s.chiba-u.ac.jp \
--to=mituharu@math.s.chiba-u.ac.jp \
--cc=26397@debbugs.gnu.org \
--cc=aaronjensen@gmail.com \
--cc=alan@idiocy.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).