From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: YAMAMOTO Mitsuharu Newsgroups: gmane.emacs.bugs Subject: bug#50951: 28.0.50; Urdu text is not displayed correctly Date: Tue, 27 Sep 2022 09:29:04 +0900 Organization: Faculty of Science, Chiba University Message-ID: References: <83mtnsc63i.fsf@gnu.org> <83sfxjbox7.fsf@gnu.org> <87pmsnwlvo.fsf@igel.home> <837devbgrl.fsf@gnu.org> <8335pjbewj.fsf@gnu.org> <83zgrr9zn1.fsf@gnu.org> <87edwq7srx.fsf_-_@gnus.org> <87y1uy6mn5.fsf@zohomail.eu> <83wnaij974.fsf@gnu.org> <87tu5m6jrw.fsf@zohomail.eu> <835yhzifuw.fsf@gnu.org> <87o7vqxuvs.fsf@gmail.com> <87h71gwpr5.fsf@zohomail.eu> <87mtayymk5.fsf@zohomail.eu> <835yhixq1r.fsf@gnu.org> <83h710t1ez.fsf@gnu.org> <83leq6li1x.fsf@gnu.org> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24536"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?Q?Goj=C5=8D?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) Cc: rahguzar@zohomail.eu, larsi@gnus.org, 50951-done@debbugs.gnu.org, visuweshm@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 27 02:30:17 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ocyUK-00067b-MO for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 27 Sep 2022 02:30:16 +0200 Original-Received: from localhost ([::1]:47832 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ocyUJ-00070o-29 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 26 Sep 2022 20:30:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42380) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ocyU6-00070Z-L1 for bug-gnu-emacs@gnu.org; Mon, 26 Sep 2022 20:30:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52944) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ocyU6-00047n-Co for bug-gnu-emacs@gnu.org; Mon, 26 Sep 2022 20:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ocyU6-0006Zf-8F for bug-gnu-emacs@gnu.org; Mon, 26 Sep 2022 20:30:02 -0400 Resent-From: YAMAMOTO Mitsuharu Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Sep 2022 00:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 50951 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Mail-Followup-To: 50951@debbugs.gnu.org, mituharu@math.s.chiba-u.ac.jp, aikrahguzar@gmail.com Original-Received: via spool by 50951-done@debbugs.gnu.org id=D50951.166423855225181 (code D ref 50951); Tue, 27 Sep 2022 00:30:02 +0000 Original-Received: (at 50951-done) by debbugs.gnu.org; 27 Sep 2022 00:29:12 +0000 Original-Received: from localhost ([127.0.0.1]:52020 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocyTH-0006Y5-IY for submit@debbugs.gnu.org; Mon, 26 Sep 2022 20:29:11 -0400 Original-Received: from mathmail.math.s.chiba-u.ac.jp ([133.82.132.2]:55884) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocyTC-0006Xs-HG for 50951-done@debbugs.gnu.org; Mon, 26 Sep 2022 20:29:10 -0400 Original-Received: from mathent.math.s.chiba-u.ac.jp (mathent [192.168.32.5]) by mathmail.math.s.chiba-u.ac.jp (Postfix) with ESMTP id C6A35F08E7; Tue, 27 Sep 2022 09:29:04 +0900 (JST) (envelope-from mituharu@math.s.chiba-u.ac.jp) In-Reply-To: <83leq6li1x.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243684 Archived-At: On Mon, 26 Sep 2022 16:18:50 +0900, Eli Zaretskii wrote: > > > Date: Sun, 25 Sep 2022 16:18:26 +0900 > > From: YAMAMOTO Mitsuharu > > Cc: rahguzar@zohomail.eu, visuweshm@gmail.com, larsi@gnus.org, > > 50951@debbugs.gnu.org > > > > > Also, I asked whether you could elaborate on the rationale for > > > adjusting the zero width to be 1 pixel, and I don't think you > > > answered that particular question. What you are saying (AFAIU) is > > > that heuristically the results of using this adjustment are better, > > > at least in this case. I don't argue with that, but I wonder > > > whether there's some rationale for this that isn't just heuristics? > > > IOW, do you know how come hb-view doesn't have this problem? what do > > > we do that produces the zero width where hb-view doesn't? > > > > The output of hb-view was in PDF, and its coordinate system does not > > directly correspond to the integral number of physical pixels unlike > > in Emacs. > > > > The display engine of Emacs only accepts positive integer as > > pixel-width of a glyph (in Emacs terminology). If the actual grapheme > > cluster has width zero (after rounding), then it is replaced to some > > positive integer (space width) in gui_produce_glyphs. Because some > > grapheme cluster in the result of shaping can be in very small width > > and rounded to 0, adjusting it to 1 is almost the best approximation. > > OK, thanks. Please install your patch on the master branch. I installed a slightly modified version because the previous one did not adjust the last grapheme cluster when its width is zero. Closing. YAMAMOTO Mitsuharu mituharu@math.s.chiba-u.ac.jp