bug#5268: 23.1.90; # of rows/columns not adjusted by change of internal-border-width for fullscreen frames

bug#5268: 23.1.90; # of rows/columns not adjusted by change of internal-border-width for fullscreen frames

[YAMAMOTO Mitsuharu]

Steps to reproduce:

  1. emacs -Q
  2. (set-frame-parameter nil 'fullscreen 'fullboth) C-j
  3. (set-frame-parameter nil 'internal-border-width 30) C-j

Result:

  The echo area does not fit in the screen and becomes invisible.
  The number of rows/columns seems to be unchanged by Step 3.

I tried it on Ubuntu 9.10, GTK+ build.

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp

If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
For information about debugging Emacs, please read the file
/usr/local/share/emacs/23.1.90/etc/DEBUG.


In GNU Emacs 23.1.90.1 (i686-pc-linux-gnu, GTK+ Version 2.18.3)
 of 2009-12-24 on mituharu-laptop
Windowing system distributor `The X.Org Foundation', version 11.0.10604000
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: ja_JP.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix
  default enable-multibyte-characters: t

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<help-echo> <menu-bar> <help-menu> <send-emacs-bug
-report>

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.

Load-path shadows:
None found.

Features:
(shadow sort mail-extr message sendmail regexp-opt ecomplete rfc822 mml
easymenu mml-sec password-cache mm-decode mm-bodies mm-encode mailcap
mail-parse rfc2231 rfc2047 rfc2045 qp ietf-drums mailabbrev nnheader
gnus-util netrc time-date mm-util mail-prsvr gmm-utils wid-edit
mailheader canlock sha1 hex-util hashcash mail-utils emacsbug japan-util
tooltip ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd
font-setting tool-bar dnd fontset image fringe lisp-mode register page
menu-bar rfn-eshadow timer select scroll-bar mldrag mouse jit-lock
font-lock syntax facemenu font-core frame cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew
greek romanian slovak czech european ethiopic indian cyrillic chinese
case-table epa-hook jka-cmpr-hook help simple abbrev loaddefs button
minibuffer faces cus-face files text-properties overlay md5 base64
format env code-pages mule custom widget hashtable-print-readable
backquote make-network-process dbusbind system-font-setting
font-render-setting gtk x-toolkit x multi-tty emacs)

bug#5268: 23.1.90; # of rows/columns not adjusted by change of internal-border-width for fullscreen frames

[martin rudalics]

 >   2. (set-frame-parameter nil 'fullscreen 'fullboth) C-j
 >   3. (set-frame-parameter nil 'internal-border-width 30) C-j
 >
 > Result:
 >
 >   The echo area does not fit in the screen and becomes invisible.
 >   The number of rows/columns seems to be unchanged by Step 3.

I suppose that's by intention.  If I do

(set-frame-parameter nil 'internal-border-width 0)

afterwards, the frame shrinks (probably in order to keep the number of
lines and columns constant).  Fullscreen mode is inherently incompatible
with the "keep the number of lines/columns constant" paradigm permeating
many of the frame and font size handling routines.

martin

bug#5268: 23.1.90; # of rows/columns not adjusted by change of internal-border-width for fullscreen frames

[YAMAMOTO Mitsuharu]

>>>>> On Fri, 25 Dec 2009 12:26:31 +0100, martin rudalics <rudalics@gmx.at> said:

>> 2. (set-frame-parameter nil 'fullscreen 'fullboth) C-j
>> 3. (set-frame-parameter nil 'internal-border-width 30) C-j
>> 
>> Result:
>> 
>> The echo area does not fit in the screen and becomes invisible.
>> The number of rows/columns seems to be unchanged by Step 3.

> I suppose that's by intention.  If I do

> (set-frame-parameter nil 'internal-border-width 0)

> afterwards, the frame shrinks (probably in order to keep the number of
> lines and columns constant).  Fullscreen mode is inherently incompatible
> with the "keep the number of lines/columns constant" paradigm permeating
> many of the frame and font size handling routines.

In the case of the `font' frame parameter, it does the adjustment of
the number of rows/columns on its change.

  1. emacs -Q
  2. (set-frame-parameter nil 'fullscreen 'fullboth) C-j
  3. (frame-parameter nil 'width) C-j	[which gives 176 for me]
  4. (set-frame-parameter nil 'font "-*-courier-*--20-*") C-j
  5. (frame-parameter nil 'width) C-j	[which gives 112 for me]

So I think the reported issue was simply overlooked rather than by
intention.

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp

bug#5268: 23.1.90; # of rows/columns not adjusted by change of internal-border-width for fullscreen frames

[martin rudalics]

 >   1. emacs -Q
 >   2. (set-frame-parameter nil 'fullscreen 'fullboth) C-j
 >   3. (frame-parameter nil 'width) C-j	[which gives 176 for me]

Gives 156 here.

 >   4. (set-frame-parameter nil 'font "-*-courier-*--20-*") C-j
 >   5. (frame-parameter nil 'width) C-j	[which gives 112 for me]

Gives 102 here and the frame is still full size.  But if I now do

(set-frame-parameter nil 'font "-*-courier-*--12-*")

the frame is sized down and

(frame-parameter nil 'width)

still evaluates to 102 (after doing that the frame sometimes misses its
modeline, for whatever reason).

With GNU Emacs 23.1.90.1 (i386-mingw-nt5.1.2600) of 2009-12-14 so any
differences we see might be related to our ports.

martin

bug#5268: 23.1.90; # of rows/columns not adjusted by change of internal-border-width for fullscreen frames

[YAMAMOTO Mitsuharu]

>>>>> On Sat, 26 Dec 2009 09:55:36 +0100, martin rudalics <rudalics@gmx.at> said:

>> 1. emacs -Q
>> 2. (set-frame-parameter nil 'fullscreen 'fullboth) C-j
>> 3. (frame-parameter nil 'width) C-j	[which gives 176 for me]

> Gives 156 here.

>> 4. (set-frame-parameter nil 'font "-*-courier-*--20-*") C-j
>> 5. (frame-parameter nil 'width) C-j	[which gives 112 for me]

> Gives 102 here and the frame is still full size.  But if I now do

> (set-frame-parameter nil 'font "-*-courier-*--12-*")

> the frame is sized down and

> (frame-parameter nil 'width)

> still evaluates to 102 (after doing that the frame sometimes misses its
> modeline, for whatever reason).

> With GNU Emacs 23.1.90.1 (i386-mingw-nt5.1.2600) of 2009-12-14 so any
> differences we see might be related to our ports.

On Ubuntu 9.10 (GTK+ build), it gives 176 again and the frame size is
kept in fullscreen and the modeline visible.  FWIW, the Mac port I'm
distributing
(http://lists.gnu.org/archive/html/emacs-devel/2009-12/msg00466.html)
gives a similar result.

I think such adjustment of the number of rows/columns for a fullscreen
frame is the intended and expected behavior for operations that would
require the change of the frame size if the frame were an ordinary
one.  That's why I thought the current behavior of the
`internal-border-width' case was not by intention.

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp

bug#5268: 23.1.90; # of rows/columns not adjusted by change of internal-border-width for fullscreen frames

[martin rudalics]

 > On Ubuntu 9.10 (GTK+ build), it gives 176 again and the frame size is
 > kept in fullscreen and the modeline visible.  FWIW, the Mac port I'm
 > distributing
 > (http://lists.gnu.org/archive/html/emacs-devel/2009-12/msg00466.html)
 > gives a similar result.

So my Windows port looks much more broken in this regard.  My frame also
resizes when I add/remove vertical scrollbars.

 > I think such adjustment of the number of rows/columns for a fullscreen
 > frame is the intended and expected behavior for operations that would
 > require the change of the frame size if the frame were an ordinary
 > one.  That's why I thought the current behavior of the
 > `internal-border-width' case was not by intention.

Given that all other parameters work for you as intended I fully agree
with you.

martin

bug#5268: 23.1.90; # of rows/columns not adjusted by change of internal-border-width for fullscreen frames

[YAMAMOTO Mitsuharu]

>>>>> On Sun, 27 Dec 2009 12:02:17 +0100, martin rudalics <rudalics@gmx.at> said:

>> On Ubuntu 9.10 (GTK+ build), it gives 176 again and the frame size
>> is kept in fullscreen and the modeline visible.  FWIW, the Mac port
>> I'm distributing
>> (http://lists.gnu.org/archive/html/emacs-devel/2009-12/msg00466.html)
>> gives a similar result.

> So my Windows port looks much more broken in this regard.  My frame
> also resizes when I add/remove vertical scrollbars.

This behavior is rather new even on X11; the font and scroll bar cases
did not adjust the number of rows/columns of a fullscreen frame on
Emacs 23.1.  So it is likely to happen for non-X11 ports to be behind
with respect to the implementation of such a new behavior.

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp