* bug#10743: 24.0.93; missing type checking for Vtool_bar_button_margin in x_draw_image_relief
@ 2012-02-07 0:48 YAMAMOTO Mitsuharu
2012-02-22 6:01 ` Chong Yidong
0 siblings, 1 reply; 2+ messages in thread
From: YAMAMOTO Mitsuharu @ 2012-02-07 0:48 UTC (permalink / raw)
To: 10743
The current code in x_draw_image_relief (in xterm.c) applies XINT to
Vtool_bar_button_margin without INTEGERP:
2326 extra = s->face->id == TOOL_BAR_FACE_ID
2327 ? XINT (Vtool_bar_button_margin) : 0;
Other than an integer, a cons of integers is also a valid value for
Vtool_bar_button_margin.
YAMAMOTO Mitsuharu
mituharu@math.s.chiba-u.ac.jp
In GNU Emacs 24.0.93.1 (x86_64-apple-darwin11.3.0, X toolkit, Xaw scroll bars)
of 2012-02-07 on yamamoto-no-iMac.local
Windowing system distributor `The X.Org Foundation', version 11.0.11003000
Configured using:
`configure '--with-jpeg=no' '--with-gif=no' '--with-tiff=no'
'--enable-asserts' '--enable-checking''
Important settings:
value of $LC_ALL: nil
value of $LC_COLLATE: nil
value of $LC_CTYPE: nil
value of $LC_MESSAGES: nil
value of $LC_MONETARY: nil
value of $LC_NUMERIC: nil
value of $LC_TIME: nil
value of $LANG: ja_JP.UTF-8
value of $XMODIFIERS: nil
locale-coding-system: utf-8-unix
default enable-multibyte-characters: t
Major mode: Fundamental
Minor modes in effect:
tooltip-mode: t
mouse-wheel-mode: t
tool-bar-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
blink-cursor-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
line-number-mode: t
transient-mark-mode: t
^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#10743: 24.0.93; missing type checking for Vtool_bar_button_margin in x_draw_image_relief
2012-02-07 0:48 bug#10743: 24.0.93; missing type checking for Vtool_bar_button_margin in x_draw_image_relief YAMAMOTO Mitsuharu
@ 2012-02-22 6:01 ` Chong Yidong
0 siblings, 0 replies; 2+ messages in thread
From: Chong Yidong @ 2012-02-22 6:01 UTC (permalink / raw)
To: YAMAMOTO Mitsuharu; +Cc: 10743
YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp> writes:
> The current code in x_draw_image_relief (in xterm.c) applies XINT to
> Vtool_bar_button_margin without INTEGERP:
>
> 2326 extra = s->face->id == TOOL_BAR_FACE_ID
> 2327 ? XINT (Vtool_bar_button_margin) : 0;
>
> Other than an integer, a cons of integers is also a valid value for
> Vtool_bar_button_margin.
Thanks. Fixed in trunk.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-02-22 6:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-07 0:48 bug#10743: 24.0.93; missing type checking for Vtool_bar_button_margin in x_draw_image_relief YAMAMOTO Mitsuharu
2012-02-22 6:01 ` Chong Yidong
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).