From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: YAMAMOTO Mitsuharu Newsgroups: gmane.emacs.bugs Subject: bug#18334: 24.3.93; ImageMagick: eww shows favicon animations in search results Date: Sun, 14 Sep 2014 16:42:20 +0900 Organization: Faculty of Science, Chiba University Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Trace: ger.gmane.org 1410680606 18352 80.91.229.3 (14 Sep 2014 07:43:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 14 Sep 2014 07:43:26 +0000 (UTC) To: 18334@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 14 09:43:18 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XT4Ss-0001bA-95 for geb-bug-gnu-emacs@m.gmane.org; Sun, 14 Sep 2014 09:43:18 +0200 Original-Received: from localhost ([::1]:53213 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XT4Sr-0002sg-VI for geb-bug-gnu-emacs@m.gmane.org; Sun, 14 Sep 2014 03:43:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47542) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XT4Sj-0002sB-JG for bug-gnu-emacs@gnu.org; Sun, 14 Sep 2014 03:43:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XT4Sd-0007um-D9 for bug-gnu-emacs@gnu.org; Sun, 14 Sep 2014 03:43:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49021) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XT4Sd-0007ui-9r for bug-gnu-emacs@gnu.org; Sun, 14 Sep 2014 03:43:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XT4Sc-0006iW-OO for bug-gnu-emacs@gnu.org; Sun, 14 Sep 2014 03:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: YAMAMOTO Mitsuharu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Sep 2014 07:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18334 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18334-submit@debbugs.gnu.org id=B18334.141068055025779 (code B ref 18334); Sun, 14 Sep 2014 07:43:02 +0000 Original-Received: (at 18334) by debbugs.gnu.org; 14 Sep 2014 07:42:30 +0000 Original-Received: from localhost ([127.0.0.1]:40585 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XT4S5-0006hi-AZ for submit@debbugs.gnu.org; Sun, 14 Sep 2014 03:42:29 -0400 Original-Received: from mathmail.math.s.chiba-u.ac.jp ([133.82.132.2]:53519) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XT4S0-0006hV-Pc for 18334@debbugs.gnu.org; Sun, 14 Sep 2014 03:42:27 -0400 Original-Received: from fermat.math.s.chiba-u.ac.jp (fermat [133.82.132.10]) by mathmail.math.s.chiba-u.ac.jp (Postfix) with ESMTP id 1CBD1C055D for <18334@debbugs.gnu.org>; Sun, 14 Sep 2014 16:42:21 +0900 (JST) In-Reply-To: User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (=?UTF-8?Q?Shij=C5=8D?=) APEL/10.6 Emacs/22.3 (sparc-sun-solaris2.8) MULE/5.0 (SAKAKI) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:93355 Archived-At: >>>>> On Wed, 27 Aug 2014 09:57:29 +0900, YAMAMOTO Mitsuharu said: > Steps to Reproduce: > 1. Build Emacs with the ImageMagick support. > 2. $ emacs -Q & > 3. M-x eww RET wikipedia RET > Result: > Probably you'll observe animated favicons in the search results by > DuckDuckGo. I think these animations are unexpected and unwanted. > See also bug#18333. Currently, all the image data containing multiple image frames seems to be treated as animations. In shr-put-image (lisp/net/shr.el), we have (when (and shr-image-animate (cond ((fboundp 'image-multi-frame-p) ;; Only animate multi-frame things that specify a ;; delay; eg animated gifs as opposed to ;; multi-page tiffs. FIXME? (cdr (image-multi-frame-p image))) ((fboundp 'image-animated-p) (image-animated-p image)))) (image-animate image nil 60))) And in lisp/image.el, (defun image-multi-frame-p (image) "Return non-nil if IMAGE contains more than one frame. The actual return value is a cons (NIMAGES . DELAY), where NIMAGES is the number of frames (or sub-images) in the image and DELAY is the delay in seconds that the image specifies between each frame. DELAY may be nil, in which case you might want to use `image-default-frame-delay'." (when (fboundp 'image-metadata) (let* ((metadata (image-metadata image)) (images (plist-get metadata 'count)) (delay (plist-get metadata 'delay))) (when (and images (> images 1)) (if (or (not (numberp delay)) (< delay 0)) (setq delay image-default-frame-delay)) (cons images delay))))) Which should be fixed? Should image-multi-frame-p, a new function in 24.4, stop using image-default-frame-delay as a default value for DELAY? Or should each caller of image-multi-frame-p temporarily let-bind image-default-frame-delay to nil if it doesn't want to treat images that are missing DELAY value as animations? YAMAMOTO Mitsuharu mituharu@math.s.chiba-u.ac.jp