From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: YAMAMOTO Mitsuharu Newsgroups: gmane.emacs.bugs Subject: bug#52461: spontaneous crash with portable dumper Date: Wed, 15 Dec 2021 12:04:31 +0900 Organization: Faculty of Science, Chiba University Message-ID: References: <83czm0my1u.fsf@gnu.org> <83zgp4la58.fsf@gnu.org> <83czlzl3vl.fsf@gnu.org> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27140"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?Q?Goj=C5=8D?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) Cc: 52461@debbugs.gnu.org, pipcet@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 15 04:05:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mxKbS-0006m7-FJ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Dec 2021 04:05:14 +0100 Original-Received: from localhost ([::1]:60472 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mxKbQ-0000NZ-HE for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Dec 2021 22:05:12 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58040) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mxKbG-0000NO-FM for bug-gnu-emacs@gnu.org; Tue, 14 Dec 2021 22:05:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48404) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mxKbG-0000CW-7J for bug-gnu-emacs@gnu.org; Tue, 14 Dec 2021 22:05:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mxKbF-0003w9-WE for bug-gnu-emacs@gnu.org; Tue, 14 Dec 2021 22:05:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: YAMAMOTO Mitsuharu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Dec 2021 03:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52461 X-GNU-PR-Package: emacs Original-Received: via spool by 52461-submit@debbugs.gnu.org id=B52461.163953747615097 (code B ref 52461); Wed, 15 Dec 2021 03:05:01 +0000 Original-Received: (at 52461) by debbugs.gnu.org; 15 Dec 2021 03:04:36 +0000 Original-Received: from localhost ([127.0.0.1]:59950 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxKaq-0003vR-Gs for submit@debbugs.gnu.org; Tue, 14 Dec 2021 22:04:36 -0500 Original-Received: from mathmail.math.s.chiba-u.ac.jp ([133.82.132.2]:64375) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxKao-0003vG-AL for 52461@debbugs.gnu.org; Tue, 14 Dec 2021 22:04:35 -0500 Original-Received: from mathent.math.s.chiba-u.ac.jp (mathent [192.168.32.5]) by mathmail.math.s.chiba-u.ac.jp (Postfix) with ESMTP id 6AB22F08DA; Wed, 15 Dec 2021 12:04:31 +0900 (JST) (envelope-from mituharu@math.s.chiba-u.ac.jp) In-Reply-To: <83czlzl3vl.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:222404 Archived-At: On Tue, 14 Dec 2021 22:20:30 +0900, Eli Zaretskii wrote: > > > I directly inserted the memset line just after the xpalloc call in > > charset.c, and dumped 10 times. No crash occured. > > > > I also tried the change below, and it seems to work, too. > > Thanks. I think I prefer the second variant. > > Do you think we need more testing of this, since the problem was > intermittent? I don't think so. The members of struct charset other than code_space_mask is non-pointer values, so they do not involve any dereference. Can I install it to the emacs-28 branch? Currently, we have charset_table_used == 179, and charset_table_size == 180, so the problem does not manifest itself without additional charsets defined before dumping. YAMAMOTO Mitsuharu mituharu@math.s.chiba-u.ac.jp