From: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 52461@debbugs.gnu.org, pipcet@gmail.com
Subject: bug#52461: spontaneous crash with portable dumper
Date: Wed, 15 Dec 2021 12:04:31 +0900 [thread overview]
Message-ID: <wlbl1io9fk.wl-mituharu@math.s.chiba-u.ac.jp> (raw)
In-Reply-To: <83czlzl3vl.fsf@gnu.org>
On Tue, 14 Dec 2021 22:20:30 +0900,
Eli Zaretskii wrote:
>
> > I directly inserted the memset line just after the xpalloc call in
> > charset.c, and dumped 10 times. No crash occured.
> >
> > I also tried the change below, and it seems to work, too.
>
> Thanks. I think I prefer the second variant.
>
> Do you think we need more testing of this, since the problem was
> intermittent?
I don't think so. The members of struct charset other than
code_space_mask is non-pointer values, so they do not involve any
dereference.
Can I install it to the emacs-28 branch? Currently, we have
charset_table_used == 179, and charset_table_size == 180, so the
problem does not manifest itself without additional charsets defined
before dumping.
YAMAMOTO Mitsuharu
mituharu@math.s.chiba-u.ac.jp
next prev parent reply other threads:[~2021-12-15 3:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-13 1:38 bug#52461: spontaneous crash with portable dumper YAMAMOTO Mitsuharu
2021-12-13 1:44 ` YAMAMOTO Mitsuharu
2021-12-13 13:31 ` Eli Zaretskii
2021-12-13 14:43 ` Pip Cet
2021-12-13 16:52 ` Eli Zaretskii
2021-12-14 8:04 ` YAMAMOTO Mitsuharu
2021-12-14 13:20 ` Eli Zaretskii
2021-12-15 3:04 ` YAMAMOTO Mitsuharu [this message]
2021-12-15 3:24 ` YAMAMOTO Mitsuharu
2021-12-15 3:30 ` Eli Zaretskii
2021-12-15 4:15 ` YAMAMOTO Mitsuharu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wlbl1io9fk.wl-mituharu@math.s.chiba-u.ac.jp \
--to=mituharu@math.s.chiba-u.ac.jp \
--cc=52461@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=pipcet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).