unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Glenn Morris <rgm@gnu.org>
To: "Jürgen Bickert" <juergen.bickert@googlemail.com>
Cc: 10217@debbugs.gnu.org, Nick Roberts <nickrob@snap.net.nz>
Subject: bug#10217: 24.0.92; Error on quitting Emacs
Date: Mon, 05 Dec 2011 22:53:18 -0500	[thread overview]
Message-ID: <wir50imk41.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <9hmxb6ielo.fsf@fencepost.gnu.org> (Glenn Morris's message of "Mon, 05 Dec 2011 22:05:55 -0500")

Glenn Morris wrote:

> Glenn Morris wrote:
>
>> By experiment, reverting the 2009-08-13 change to start_process_unwind
>> ("Use pid == -2 to mean no process") seems to fix it, ie:
>
> But that can't be a complete solution, since it breaks gdb:

The obvious thing, or some variation of it, seems to work:

*** src/process.c 2011-11-28 08:20:58 +0000
--- src/process.c 2011-12-06 03:49:04 +0000
***************
*** 1521,1528 ****
    if (!PROCESSP (proc))
      abort ();
  
!   /* Was PROC started successfully?  */
!   if (XPROCESS (proc)->pid == -1)
      remove_process (proc);
  
    return Qnil;
--- 1521,1529 ----
    if (!PROCESSP (proc))
      abort ();
  
!   /* Was PROC started successfully?
!      -2 is used for a pty with no process, eg for gdb.  */
!   if (XPROCESS (proc)->pid <= 0 && XPROCESS (proc)->pid != -2)
      remove_process (proc);
  
    return Qnil;






  reply	other threads:[~2011-12-06  3:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-04 22:41 bug#10217: 24.0.92; Error on quitting Emacs Jürgen Bickert
2011-12-06  2:47 ` Glenn Morris
2011-12-06  3:05   ` Glenn Morris
2011-12-06  3:53     ` Glenn Morris [this message]
2011-12-06  8:18       ` Glenn Morris
2011-12-06 17:41         ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=wir50imk41.fsf@fencepost.gnu.org \
    --to=rgm@gnu.org \
    --cc=10217@debbugs.gnu.org \
    --cc=juergen.bickert@googlemail.com \
    --cc=nickrob@snap.net.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).