bug#17966: 24.4.50; Error while saving bookmarks: Unknown button type `help-xref'

bug#17966: 24.4.50; Error while saving bookmarks: Unknown button type `help-xref'

[Dani Moncayo]

emacs -Q
(set-language-environment 'latin-1)
(info "(emacs)Regexp Backslash")
C-u 9 C-n
C-x r m foo RET
M-x bookmark-save RET

At that moment, a *Bookmarks* buffers appears and the echo area shows
the message "Unknown button type `help-xref'".

I can't even exit Emacs, because that implies saving the bookmarks,
which againg triggers the above error.  (I have to move point to another
place, define the bookmark there, and then save it).


In GNU Emacs 24.4.50.5 (x86_64-unknown-linux-gnu, GTK+ Version 3.10.8)
 of 2014-07-07 on LEG570
Windowing system distributor `The X.Org Foundation', version 11.0.11501000
System Description: Ubuntu 14.04 LTS

Configured using:
 `configure --enable-checking 'CFLAGS=-O0 -g3' CPPFLAGS=-DGLYPH_DEBUG=1'

Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS
NOTIFY LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB

Important settings:
  value of $LC_MONETARY: es_ES.UTF-8
  value of $LC_NUMERIC: es_ES.UTF-8
  value of $LC_TIME: es_ES.UTF-8
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: Fundamental

Minor modes in effect:
  tooltip-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t

Recent input:
C-y <return> C-p C-p C-e C-x C-e C-n C-x C-e C-u 9
C-n C-x r m f o o <return> M-x b o - s a <tab> <return>
M-x r e - e m - b u <tab> <return>

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Mark set
t
nil
Saving bookmarks to file ~/.emacs.d/bookmarks...
make-text-button: Unknown button type `help-xref'

Load-path shadows:
None found.

Features:
(shadow sort gnus-util mail-extr emacsbug message dired format-spec
rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231
mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums
mm-util help-fns mail-prsvr mail-utils bookmark pp info easymenu
time-date tooltip electric uniquify ediff-hook vc-hooks lisp-float-type
mwheel x-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list newcomment lisp-mode prog-mode register page menu-bar
rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax
facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak
czech european ethiopic indian cyrillic chinese case-table epa-hook
jka-cmpr-hook help simple abbrev minibuffer nadvice loaddefs button
faces cus-face macroexp files text-properties overlay sha1 md5 base64
format env code-pages mule custom widget hashtable-print-readable
backquote make-network-process dbusbind gfilenotify dynamic-setting
system-font-setting font-render-setting move-toolbar gtk x-toolkit x
multi-tty emacs)

Memory information:
((conses 16 86066 4798)
 (symbols 48 18429 0)
 (miscs 40 49 212)
 (strings 32 15349 5638)
 (string-bytes 1 374310)
 (vectors 16 14117)
 (vector-slots 8 801460 115730)
 (floats 8 78 93)
 (intervals 56 318 181)
 (buffers 960 14)
 (heap 1024 50559 1322))

-- 
Dani Moncayo

bug#17966: 24.4.50; Error while saving bookmarks: Unknown button type `help-xref'

[Glenn Morris]

Dani Moncayo wrote:

> emacs -Q
> (set-language-environment 'latin-1)
> (info "(emacs)Regexp Backslash")
> C-u 9 C-n
> C-x r m foo RET
> M-x bookmark-save RET
>
> At that moment, a *Bookmarks* buffers appears and the echo area shows
> the message "Unknown button type `help-xref'".

I can't reproduce this with current trunk on GNU/Linux.
Perhaps it depends on pre-existing contents of the bookmarks file;
mine is empty.

bug#17966: 24.4.50; Error while saving bookmarks: Unknown button type `help-xref'

[Dani Moncayo]

> I can't reproduce this with current trunk on GNU/Linux.

Oh, too bad :-(

> Perhaps it depends on pre-existing contents of the bookmarks file;
> mine is empty.

I've just verified that the problem persists even if I rename
"~/.emacs.d" to something else before running Emacs.

FWIW, I've compiled this Emacs from today's trunk (revno 117481) in
this same machine, whose OS is Ubuntu 14.04.

-- 
Dani Moncayo

bug#17966: 24.4.50; Error while saving bookmarks: Unknown button type `help-xref'

[Dani Moncayo]

FWIW, these are the last two lines in the *Messages* buffer:

  Saving bookmarks to file ~/.emacs.d/bookmarks...
  make-text-button: Unknown button type `help-xref'

and these are the contents of the *Bookmarks* buffer which appears
suddenly after doing "M-x bookmark-save":

  ;;;; Emacs Bookmark Format Version 1 ;;;;
  ;;; This format is meant to be slightly human-readable;
  ;;; nevertheless, you probably don't want to edit it.
  ;;; -*- End Of Bookmark File Format Version Stamp -*-
  (("foo"
   (front-context-string . "‘\\|’\n     specif")
   (rear-context-string . "\\’ constructs.\n\n")
   (position . 345746)
   (filename . "/home/dani/devel/emacs/repo/info/emacs")
   (info-node . "Regexp Backslash")
   (handler . Info-bookmark-jump))
  )


-- 
Dani Moncayo

bug#17966: 24.4.50; Error while saving bookmarks: Unknown button type `help-xref'

[Dani Moncayo]

[-- Attachment #1: Type: text/plain, Size: 657 bytes --]

>> Perhaps it depends on pre-existing contents of the bookmarks file;
>> mine is empty.
>
> I've just verified that the problem persists even if I rename
> "~/.emacs.d" to something else before running Emacs.

Perhaps the key difference between your environment and mine is that I
have makeinfo version 5.2, which produces the special (non-ascii)
quotation chars ‘ and ’, and you may have an older version which
produces ` and ' instead.

Can you reproduce the problem with the following recipe?

emacs -Q
(set-language-environment 'latin-1)
Visit the attached file.
C-u 9 C-n
C-x r m RET
M-x bookmark-save RET


-- 
Dani Moncayo

[-- Attachment #2: file1 --]
[-- Type: application/octet-stream, Size: 1014 bytes --]

15.7 Backslash in Regular Expressions
=====================================

For the most part, ‘\’ followed by any character matches only that
character.  However, there are several exceptions: two-character
sequences starting with ‘\’ that have special meanings.  The second
character in the sequence is always an ordinary character when used on
its own.  Here is a table of ‘\’ constructs.

‘\|’
     specifies an alternative.  Two regular expressions A and B with
     ‘\|’ in between form an expression that matches some text if either
     A matches it or B matches it.  It works by trying to match A, and
     if that fails, by trying to match B.

     Thus, ‘foo\|bar’ matches either ‘foo’ or ‘bar’ but no other string.

     ‘\|’ applies to the largest possible surrounding expressions.  Only
     a surrounding ‘\( … \)’ grouping can limit the grouping power of
     ‘\|’.

     Full backtracking capability exists to handle multiple uses of
     ‘\|’.

bug#17966: 24.4.50; Error while saving bookmarks: Unknown button type `help-xref'

[Drew Adams]

> >> Perhaps it depends on pre-existing contents of the bookmarks file;
> >> mine is empty.
> >
> > I've just verified that the problem persists even if I rename
> > "~/.emacs.d" to something else before running Emacs.
> 
> Perhaps the key difference between your environment and mine is that I
> have makeinfo version 5.2, which produces the special (non-ascii)
> quotation chars ‘ and ’, and you may have an older version which
> produces ` and ' instead.
> 
> Can you reproduce the problem with the following recipe?
> 
> emacs -Q
> (set-language-environment 'latin-1)
> Visit the attached file.
> C-u 9 C-n
> C-x r m RET
> M-x bookmark-save RET

Sounds similar to what was reported in bug #17568, which I'm
guessing has to do with existing code expecting a buffer to be in
`help-mode' after `with-output-to-temp-buffer'.  IOW, perhaps
more collateral damage from bug #17109.  Just a hunch.

bug#17966: 24.4.50; Error while saving bookmarks: Unknown button type `help-xref'

[Glenn Morris]

Dani Moncayo wrote:

> Perhaps the key difference between your environment and mine is that I
> have makeinfo version 5.2, which produces the special (non-ascii)
> quotation chars ' and ', and you may have an older version which
> produces ` and ' instead.

Good deductive skills! :)
(I have both makeinfo 4 and 5, but 5 is far too slow for everyday use.)

Yes, it is a problem with select-safe-coding-system-interactively.