From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.bugs Subject: bug#9256: Erroneous output from "verify-visited-file-modtime" (fileio.c) Date: Mon, 20 Jan 2020 15:36:53 +0000 Message-ID: References: <874o1vuenv.fsf@data.fbx.proxad.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="56042"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.60 (windows-nt) To: 9256@debbugs.gnu.org Cancel-Lock: sha1:PXyvsFgeDVrATW1L26zCw2v3OsM= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 20 16:38:20 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1itZ88-000EJN-B0 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Jan 2020 16:38:20 +0100 Original-Received: from localhost ([::1]:38780 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itZ87-0001b9-3o for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Jan 2020 10:38:19 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51413) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itZ7v-0001ay-NO for bug-gnu-emacs@gnu.org; Mon, 20 Jan 2020 10:38:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1itZ7q-0002Op-NH for bug-gnu-emacs@gnu.org; Mon, 20 Jan 2020 10:38:07 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39862) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1itZ7q-0002Of-Kl for bug-gnu-emacs@gnu.org; Mon, 20 Jan 2020 10:38:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1itZ7q-0007pE-J0 for bug-gnu-emacs@gnu.org; Mon, 20 Jan 2020 10:38:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <874o1vuenv.fsf@data.fbx.proxad.net> Resent-From: Andy Moreton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Jan 2020 15:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9256 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.157953463530021 (code B ref -1); Mon, 20 Jan 2020 15:38:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 20 Jan 2020 15:37:15 +0000 Original-Received: from localhost ([127.0.0.1]:45835 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itZ71-0007o5-2g for submit@debbugs.gnu.org; Mon, 20 Jan 2020 10:37:15 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:54066) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itZ6u-0007nu-OS for submit@debbugs.gnu.org; Mon, 20 Jan 2020 10:37:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51242) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itZ6t-0001SL-Fl for bug-gnu-emacs@gnu.org; Mon, 20 Jan 2020 10:37:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1itZ6q-0001uf-63 for bug-gnu-emacs@gnu.org; Mon, 20 Jan 2020 10:37:03 -0500 Original-Received: from ciao.gmane.io ([159.69.161.202]:45758) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1itZ6q-0001tk-0N for bug-gnu-emacs@gnu.org; Mon, 20 Jan 2020 10:37:00 -0500 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1itZ6n-000Cq7-T9 for bug-gnu-emacs@gnu.org; Mon, 20 Jan 2020 16:36:57 +0100 X-Injected-Via-Gmane: http://gmane.org/ X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:174923 Archived-At: On Mon 20 Jan 2020, Paul Eggert wrote: >> I'd expect things to bug out pretty regularly across the board, >> since you'd have to check for EINTR in every single call to a bunch of >> system calls > > Yes in theory. However, Emacs already does the EINTR check for open, read and > write even on regular files where POSIX says it can't happen (but it does > happen with NFS). If you've recently dealt with an NFS file then it'll be > cached on the client and you won't get EINTR, so in practice the issue comes > up only for syscalls that are applied to a file that hasn't been looked at > lately. stat is one of these calls (hence the bug report) so we might as well > do the EINTR check for it as well. I installed the attached patch to do that > for stat and similar calls, and also for openat (which I think was overlooked > when 'open' was done). > > The other part of this bug report (with ENOENT) is not something Emacs can > work around and it's surely a bug in the Linux NFS client that was most likely > fixed a while ago anyway . > > As I think both issues in the bug report have been addressed, I'm boldly closing it. This patch breaks the build for Windows, as it appears that MinGW does not have openat: CCLD temacs.exe C:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/9.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: sysdep.o: in function `emacs_openat': C:/emacs/git/emacs/master/src/sysdep.c:2486: undefined reference to `openat' C:/emacs/git/emacs/master/src/sysdep.c:2486:(.text+0x1359): relocation truncated to fit: R_X86_64_PC32 against undefined symbol `openat' collect2.exe: error: ld returned 1 exit status Presumably this will need updates to w32.c to add the necessary support. AndyM