From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.bugs Subject: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables Date: Tue, 26 Mar 2019 18:28:15 +0000 Message-ID: References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87mulmkeo9.fsf@ericabrahamsen.net> <87pnqik7ld.fsf@ericabrahamsen.net> <834l7ur52w.fsf@gnu.org> <877ecqk1b5.fsf@ericabrahamsen.net> <86imw9abj3.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="24291"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (windows-nt) To: 33653@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Mar 26 19:43:40 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h8r2x-0006Dq-Bg for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 Mar 2019 19:43:39 +0100 Original-Received: from localhost ([127.0.0.1]:36416 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h8r2w-0000j0-Cp for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 Mar 2019 14:43:38 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59313) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h8r1Q-00085a-7Y for bug-gnu-emacs@gnu.org; Tue, 26 Mar 2019 14:42:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h8r1P-0003W7-0g for bug-gnu-emacs@gnu.org; Tue, 26 Mar 2019 14:42:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47007) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h8r1O-0003Vx-MA for bug-gnu-emacs@gnu.org; Tue, 26 Mar 2019 14:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h8r1O-0004cF-Dw for bug-gnu-emacs@gnu.org; Tue, 26 Mar 2019 14:42:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <8736raz3ec.fsf@ericabrahamsen.net> Resent-From: Andy Moreton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Mar 2019 18:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33653 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.155362567417686 (code B ref -1); Tue, 26 Mar 2019 18:42:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 26 Mar 2019 18:41:14 +0000 Original-Received: from localhost ([127.0.0.1]:60551 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8r0c-0004bC-8U for submit@debbugs.gnu.org; Tue, 26 Mar 2019 14:41:14 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44471) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8r0a-0004am-2r for submit@debbugs.gnu.org; Tue, 26 Mar 2019 14:41:12 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:59148) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h8r0T-0002oP-JB for submit@debbugs.gnu.org; Tue, 26 Mar 2019 14:41:06 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:58547) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h8r0S-00074O-6M for bug-gnu-emacs@gnu.org; Tue, 26 Mar 2019 14:41:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h8qoG-0004Ze-NP for bug-gnu-emacs@gnu.org; Tue, 26 Mar 2019 14:28:29 -0400 Original-Received: from [195.159.176.226] (port=59116 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h8qoD-0004Y8-Pv for bug-gnu-emacs@gnu.org; Tue, 26 Mar 2019 14:28:28 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1h8qoB-000wOr-Te for bug-gnu-emacs@gnu.org; Tue, 26 Mar 2019 19:28:23 +0100 X-Injected-Via-Gmane: http://gmane.org/ Cancel-Lock: sha1://khO0z6TiaT6yiNeyto744ogaM= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156834 Archived-At: On Sat 23 Mar 2019, Andy Moreton wrote: > On Fri 22 Mar 2019, Eric Abrahamsen wrote: > >> Eli Zaretskii writes: >> >>>> From: Eric Abrahamsen >>>> Date: Fri, 22 Mar 2019 12:54:54 -0700 >>>> >>>> is there anything to be done besides warning people on the mailing >>>> lists? >>> >>> A warning would be nice, yes. >> >> Okay, I'll do that. I've already gotten a bug report :( > > After bootstrapping, I observe that the summary buffer does not update > the faces correctly for nntp articles that have been read: they still > have an unread face. After more debugging, I have found the problem. Updating summary lines is handled in `gnus-summary-insert-line': (condition-case () (put-text-property (point) (progn (eval gnus-summary-line-format-spec) (point)) 'gnus-number gnus-tmp-number) (error (gnus-message 5 "Error updating the summary line"))) In my setup, `gnus-summary-line-format' used starts with "%U%R%u&score;" to use a user format function for printing score info. That results in calls to my user function to display summary lines: (defun gnus-user-format-function-score (header) (let* ((article (mail-header-number header)) (thread (gnus-id-to-thread (mail-header-id header))) ... This now fails because `gnus-id-to-thread' sometimes throws an error, because `gnus-newsgroup-dependencies' is nil when it is called. This usage worked in emacs-26 and in master before your changes. I've fixed this in my user format function with: (defun gnus-user-format-function-score (header) (let* ((article (mail-header-number header)) (thread (and gnus-newsgroup-dependencies (gnus-id-to-thread (mail-header-id header)))) ... After that change, the marks are displayed correctly in the summary buffer. I'm not sure if that is something that only worked by chance in old code, or if it is a regression, but it is a change of behaviour. AndyM