From: Andy Moreton <andrewjmoreton@gmail.com>
To: 23640@debbugs.gnu.org
Subject: bug#23640: 25.1.50; Getting rid of compiler warnings
Date: Thu, 02 Jun 2016 13:05:09 +0100 [thread overview]
Message-ID: <vz1lh2npzii.fsf@gmail.com> (raw)
In-Reply-To: <ff882ff4-e092-afe2-3a71-e22bce3c114d@cornell.edu>
On Wed 01 Jun 2016, Paul Eggert wrote:
> On 06/01/2016 01:37 PM, Richard Stallman wrote:
>> A macro UNUSED_LISP could handle the first.
>
> Yes, we could have separate macros for each data type requiring syntactically
> different initializers. Something like this, say:
>
> int n UNUSED_0;
> Lisp_Object obj UNUSED_Qnil;
>
> instead of the current:
>
> int n IF_LINT (= 0);
> Lisp_Object obj IF_LINT (= Qnil);
>
> We could easily change the code in that way. Is it worth the trouble?
>
>> What is the reason for writing IF_LINT (volatile)
>> instead of just volatile?
>
> Primarily, to tell the reader that the 'volatile' is not needed for
> correctness; it's present only to pacify a buggy compiler or lint checker. (In
> this case, it pacifies GCC; see GCC bug#54561.) It's basically the same reason
> the code uses 'IF_LINT (= 0)' rather than '= 0'.
Adding more macros that cruft up the source code to deal with a buggy
compiler warning is silly. If the warning is broken and does not
operate correctly, then do not enable that warning.
AndyM
next prev parent reply other threads:[~2016-06-02 12:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-28 18:40 bug#23640: 25.1.50; Getting rid of compiler warnings Ken Brown
2016-05-28 18:57 ` Eli Zaretskii
2016-05-28 21:47 ` Ken Brown
2016-05-29 22:43 ` Ken Brown
2016-05-30 11:39 ` Ken Brown
2016-05-30 14:41 ` Ken Brown
2016-05-30 16:20 ` Ken Brown
2016-05-30 23:29 ` Paul Eggert
2016-05-31 0:11 ` Ken Brown
2016-05-31 8:03 ` Andy Moreton
2016-05-31 22:22 ` Richard Stallman
2016-05-31 0:15 ` Paul Eggert
2016-06-01 8:35 ` Paul Eggert
2016-06-01 20:37 ` Richard Stallman
2016-06-01 21:10 ` Paul Eggert
2016-06-02 12:05 ` Andy Moreton [this message]
2016-06-03 3:35 ` Richard Stallman
2016-06-06 14:45 ` Paul Eggert
2016-06-07 6:19 ` Richard Stallman
2016-06-07 7:15 ` Paul Eggert
2016-06-08 4:00 ` Richard Stallman
2016-06-08 7:18 ` Paul Eggert
2016-06-08 17:06 ` Richard Stallman
2016-06-01 8:55 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vz1lh2npzii.fsf@gmail.com \
--to=andrewjmoreton@gmail.com \
--cc=23640@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).