From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.bugs Subject: bug#22522: Commit b88e9cded7ae3756e3a2ec4a23e8df352a0239f9 breaks emacs dumping for me Date: Wed, 03 Feb 2016 14:01:22 +0000 Message-ID: References: <87mvrkft66.fsf@whirm.eu> <86io28qd6g.fsf@gmail.com> <56B01BA1.1030602@cornell.edu> <85powfyywo.fsf@iznogoud.viz> <56B110B6.3090703@cornell.edu> <56B128D9.3080706@cornell.edu> <56B13388.9060904@cs.ucla.edu> <56B14544.9010609@cornell.edu> <56B1BD2E.8050606@cs.ucla.edu> <56B20225.8040104@cornell.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1454508215 9756 80.91.229.3 (3 Feb 2016 14:03:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 3 Feb 2016 14:03:35 +0000 (UTC) To: 22522@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 03 15:03:23 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aQy1d-000613-Te for geb-bug-gnu-emacs@m.gmane.org; Wed, 03 Feb 2016 15:03:18 +0100 Original-Received: from localhost ([::1]:35205 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQy1c-0008Ca-UP for geb-bug-gnu-emacs@m.gmane.org; Wed, 03 Feb 2016 09:03:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59124) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQy1U-0008BC-BZ for bug-gnu-emacs@gnu.org; Wed, 03 Feb 2016 09:03:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQy1O-0000uC-JG for bug-gnu-emacs@gnu.org; Wed, 03 Feb 2016 09:03:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48955) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQy1O-0000u8-FM for bug-gnu-emacs@gnu.org; Wed, 03 Feb 2016 09:03:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aQy1O-000092-7F for bug-gnu-emacs@gnu.org; Wed, 03 Feb 2016 09:03:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <87mvrkft66.fsf@whirm.eu> Resent-From: Andy Moreton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Feb 2016 14:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22522 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.1454508130486 (code B ref -1); Wed, 03 Feb 2016 14:03:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 3 Feb 2016 14:02:10 +0000 Original-Received: from localhost ([127.0.0.1]:57544 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aQy0Y-00007l-6g for submit@debbugs.gnu.org; Wed, 03 Feb 2016 09:02:10 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:39627) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aQy0V-00007T-RF for submit@debbugs.gnu.org; Wed, 03 Feb 2016 09:02:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQy0P-0000cz-NC for submit@debbugs.gnu.org; Wed, 03 Feb 2016 09:02:02 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:36316) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQy0P-0000cv-K0 for submit@debbugs.gnu.org; Wed, 03 Feb 2016 09:02:01 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58826) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQy0O-0007oz-Gm for bug-gnu-emacs@gnu.org; Wed, 03 Feb 2016 09:02:01 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQy0L-0000ca-AN for bug-gnu-emacs@gnu.org; Wed, 03 Feb 2016 09:02:00 -0500 Original-Received: from plane.gmane.org ([80.91.229.3]:44048) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQy0L-0000cV-3O for bug-gnu-emacs@gnu.org; Wed, 03 Feb 2016 09:01:57 -0500 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1aQy0B-0004Fl-Bu for bug-gnu-emacs@gnu.org; Wed, 03 Feb 2016 15:01:47 +0100 Original-Received: from uk.solarflare.com ([193.34.186.16]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 03 Feb 2016 15:01:47 +0100 Original-Received: from andrewjmoreton by uk.solarflare.com with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 03 Feb 2016 15:01:47 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 58 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: uk.solarflare.com User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.90 (windows-nt) Cancel-Lock: sha1:eTBUOdg6jVa3Gf9nVJ/7aNOiaCE= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:112337 Archived-At: On Wed 03 Feb 2016, Ken Brown wrote: > On 2/3/2016 3:41 AM, Paul Eggert wrote: >> Ken Brown wrote: >>>> I installed the attached patch into the Emacs master, to try to work >>>> around this problem by putting GCC into C11 mode. Please give it a try. >>> >>> No, that didn't fix it. >> >> Can you investigate why not? The patch should cause 'configure' to put >> -stdc=gnu11 into CFLAGS. If you look at config.log, it should have >> something like this: >> >> configure:5924: checking for gcc option to enable C11 features >> ... >> configure:6146: result: -std=gnu11 >> >> If this isn't the result, what is the result and why? > > Yes, that's the result. Compiling with that option caused __STDC_VERSION__ to > be defined as 201112L. But it didn't affect __ISO_C_VISIBLE, which is what > guards the declaration of aligned_alloc. > >> I'd rather not go that route, as __ISO_C_VISIBLE is supposed to be private. >> I installed the attached patch instead; please give it a try. > > We're almost there. After your change, I get the following in config.h: > > /* Define to 1 if you have the declaration of `aligned_alloc', and to 0 if you > don't. */ > #define HAVE_DECL_ALIGNED_ALLOC 0 > > So we need the following additional change: > > diff --git a/src/lisp.h b/src/lisp.h > index a99002b..c8363be 100644 > --- a/src/lisp.h > +++ b/src/lisp.h > @@ -3775,7 +3775,7 @@ INLINE void (check_cons_list) (void) { lisp_h_check_cons_list (); } > #if !defined DOUG_LEA_MALLOC && !defined HYBRID_MALLOC && !defined SYSTEM_MALLOC > extern size_t __malloc_extra_blocks; > #endif > -#ifndef HAVE_DECL_ALIGNED_ALLOC > +#if !HAVE_DECL_ALIGNED_ALLOC > extern void *aligned_alloc (size_t, size_t) ATTRIBUTE_MALLOC_SIZE ((2)); > #endif > extern void malloc_enable_thread (void); > With this change applied to changeset 5fcd89f52ec6, I have successfully built: 64bit cygwin w32 64bit mingw64 32bit mingw32 32bit mingw32 --with-wide-int Thanks Ken (and Paul) for sorting this out. AndyM