From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.bugs Subject: bug#25967: [PATCH] Add support for ImageMagick 7 (Bug#25967) Date: Tue, 04 Sep 2018 20:03:07 +0100 Message-ID: References: <6a48dc20-17fc-4e4b-b793-4c37c6bcbcc5@Spark> <86wos25gvy.fsf@gmail.com> <83wos1xk4q.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1536087734 4049 195.159.176.226 (4 Sep 2018 19:02:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 4 Sep 2018 19:02:14 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (windows-nt) To: 25967@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 04 21:02:10 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fxGaX-0000tg-Sq for geb-bug-gnu-emacs@m.gmane.org; Tue, 04 Sep 2018 21:02:09 +0200 Original-Received: from localhost ([::1]:52287 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxGce-0000Y2-DB for geb-bug-gnu-emacs@m.gmane.org; Tue, 04 Sep 2018 15:04:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58080) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxGcR-0000Xv-B7 for bug-gnu-emacs@gnu.org; Tue, 04 Sep 2018 15:04:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fxGcM-0000oA-83 for bug-gnu-emacs@gnu.org; Tue, 04 Sep 2018 15:04:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40981) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fxGcM-0000o3-2V for bug-gnu-emacs@gnu.org; Tue, 04 Sep 2018 15:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fxGcL-0000Na-Tz for bug-gnu-emacs@gnu.org; Tue, 04 Sep 2018 15:04:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <6a48dc20-17fc-4e4b-b793-4c37c6bcbcc5@Spark> Resent-From: Andy Moreton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 Sep 2018 19:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25967 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.15360878211432 (code B ref -1); Tue, 04 Sep 2018 19:04:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 4 Sep 2018 19:03:41 +0000 Original-Received: from localhost ([127.0.0.1]:45999 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fxGc1-0000N1-8f for submit@debbugs.gnu.org; Tue, 04 Sep 2018 15:03:41 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:37045) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fxGc0-0000Mo-Hi for submit@debbugs.gnu.org; Tue, 04 Sep 2018 15:03:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fxGbq-0000aX-FM for submit@debbugs.gnu.org; Tue, 04 Sep 2018 15:03:35 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:57917) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fxGbo-0000Zp-Rj for submit@debbugs.gnu.org; Tue, 04 Sep 2018 15:03:30 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58010) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxGbn-0000VQ-WE for bug-gnu-emacs@gnu.org; Tue, 04 Sep 2018 15:03:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fxGbf-0000Uj-Is for bug-gnu-emacs@gnu.org; Tue, 04 Sep 2018 15:03:25 -0400 Original-Received: from [195.159.176.226] (port=52122 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fxGbf-0000U6-4w for bug-gnu-emacs@gnu.org; Tue, 04 Sep 2018 15:03:19 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1fxGZU-0007bS-At for bug-gnu-emacs@gnu.org; Tue, 04 Sep 2018 21:01:04 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 42 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:SsJfPOm7Qcm8sHmD5YJ6jp4pfgY= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:150016 Archived-At: On Tue 04 Sep 2018, Eli Zaretskii wrote: >> From: Andy Moreton >> Date: Mon, 03 Sep 2018 23:57:05 +0100 >> >> As a followup, here is a patch to add ImageMagick support for Windows. >> The patch was initially developed for Imagemagick 6, but I've updated it >> to support ImageMagick 7. >> >> I've given this some light testing on a 64bit mingw64 (MSYS2) and 64bit >> cygwin builds, both of which use Imagemagick 7. >> >> Please test, and report if it breaks anything on other platforms. > > Thanks. A couple of minor comments: > > This needs a NEWS entry. > >> + '(imagemagick "libMagickWand-7.Q16HDRI-6.dll"))) > > Is this DLL name fixed for all the supported versions? It sounds > like it's only for Imagemagick v7, and so the DLL for version 6 will > be named differently. Indeed. v6 is legacy (and not available on any platform I currently test on). The DLL name is from the current package for MSYS2. > Also, AFAIU, there are binary incompatibilities between v6 and v7, so > an Emacs compiled with one of them should not attempt to load DLLs > from another, is that right? Correct. > For these two reasons, I think we should have a Lisp variable that > provides the version of Imagemagick with which Emacs was built, and we > need the dispatch in w32-win.el for loading the correct DLLs based on > that variable, like we do with libgif etc. Agreed. Do you use Imagemagick on mingw.org builds ? Is there a packaged library available there ? AndyM