From: Andy Moreton <andrewjmoreton@gmail.com>
To: 15933@debbugs.gnu.org
Subject: bug#15933: make check not working
Date: Wed, 20 Nov 2013 12:55:09 +0000 [thread overview]
Message-ID: <vz1fvqr6xn6.fsf@gmail.com> (raw)
Hi,
Running 'make check' does not work correctly for me with bzr r115157 on
Windows with mingw and and out of tree build directory:
--[make check]------------------------------------------------------
Compiling ../../../test/automated/package-x-test.el
In toplevel form:
../../../test/automated/package-x-test.el:38:30:Error: Cannot open load file: no such file or directory, package-test
make[2]: *** [../../../test/automated/package-x-test.elc] Error 1
--[make check]------------------------------------------------------
It seems that the recent changes for relative paths and msys
translations have not been added to tests/automated/Makefile.in. The
following patch copies the new behaviour from lisp/Makefile.in and
allowed the tests to build and run (one test aborts emacs, for other
reasons).
=== modified file 'test/automated/Makefile.in'
--- test/automated/Makefile.in 2013-11-06 17:56:48 +0000
+++ test/automated/Makefile.in 2013-11-20 11:49:09 +0000
@@ -20,8 +20,13 @@
SHELL = @SHELL@
srcdir = @srcdir@
+test_automated = $(srcdir)
VPATH = $(srcdir)
+# Empty for all systems except MinGW, where xargs needs an explicit
+# limitation.
+XARGS_LIMIT = @XARGS_LIMIT@
+
# We never change directory before running Emacs, so a relative file
# name is fine, and makes life easier. If we need to change
# directory, we can use emacs --chdir.
@@ -66,20 +71,20 @@
# Compile all the Elisp files that need it. Beware: it approximates
# `no-byte-compile', so watch out for false-positives!
compile-main: compile-clean
- @$(setwins); \
+ @(cd $(test_automated) && $(setwins); \
els=`echo "$$wins " | sed -e 's|/\./|/|g' -e 's|/\. | |g' -e 's| |/*.el |g'`; \
for el in $$els; do \
test -f $$el || continue; \
test ! -f $${el}c && GREP_OPTIONS= grep '^;.*no-byte-compile: t' $$el > /dev/null && continue; \
echo "$${el}c"; \
- done | xargs echo | \
+ done | xargs $(XARGS_LIMIT) echo) | \
while read chunk; do \
$(MAKE) $(MFLAGS) compile-targets EMACS="$(EMACS)" TARGETS="$$chunk"; \
done
# Erase left-over .elc files that do not have a corresponding .el file.
compile-clean:
- @$(setwins); \
+ @cd $(test_automated) && $(setwins); \
elcs=`echo "$$wins " | sed -e 's|/\./|/|g' -e 's|/\. | |g' -e 's| |/*.elc |g'`; \
for el in $$(echo $$elcs | sed -e 's/\.elc/\.el/g'); do \
if test -f "$$el" -o \! -f "$${el}c"; then :; else \
next reply other threads:[~2013-11-20 12:55 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-20 12:55 Andy Moreton [this message]
2013-11-20 18:49 ` bug#15933: make check not working Glenn Morris
2013-11-20 18:56 ` Glenn Morris
2013-11-20 21:33 ` Eli Zaretskii
2013-11-21 0:34 ` Glenn Morris
2013-11-20 19:04 ` Eli Zaretskii
2013-11-20 19:10 ` Glenn Morris
2013-11-20 19:14 ` Glenn Morris
2013-11-20 21:38 ` Eli Zaretskii
2013-11-20 21:53 ` Eli Zaretskii
2013-11-21 0:33 ` Glenn Morris
2013-11-21 3:46 ` Eli Zaretskii
2013-11-20 21:34 ` Eli Zaretskii
2013-11-20 20:34 ` Andy Moreton
2013-11-21 0:36 ` Glenn Morris
2013-11-21 0:56 ` Andy Moreton
2013-11-24 14:36 ` Michael Albinus
2013-11-25 11:48 ` Andy Moreton
2013-11-25 12:31 ` Michael Albinus
2013-11-25 17:15 ` Eli Zaretskii
2013-11-25 19:24 ` Michael Albinus
2013-11-25 21:08 ` Eli Zaretskii
2013-11-25 21:30 ` Glenn Morris
2013-11-26 13:08 ` Michael Albinus
2013-11-26 13:13 ` Michael Albinus
2013-11-28 19:46 ` Eli Zaretskii
2013-11-28 20:28 ` Eli Zaretskii
2013-11-29 10:36 ` Eli Zaretskii
2013-11-29 10:22 ` Andy Moreton
2013-11-29 11:16 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vz1fvqr6xn6.fsf@gmail.com \
--to=andrewjmoreton@gmail.com \
--cc=15933@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).