From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.bugs Subject: bug#21707: include-file cleanup for src directory Date: Mon, 19 Oct 2015 13:54:15 +0100 Message-ID: References: <56249650.5050804@cs.ucla.edu> <83vba3gw4p.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1445259333 12838 80.91.229.3 (19 Oct 2015 12:55:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 19 Oct 2015 12:55:33 +0000 (UTC) To: 21707@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 19 14:55:15 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zo9y5-0005Fn-E3 for geb-bug-gnu-emacs@m.gmane.org; Mon, 19 Oct 2015 14:55:13 +0200 Original-Received: from localhost ([::1]:39315 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zo9y4-0004jx-Qw for geb-bug-gnu-emacs@m.gmane.org; Mon, 19 Oct 2015 08:55:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46081) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zo9y0-0004jq-7O for bug-gnu-emacs@gnu.org; Mon, 19 Oct 2015 08:55:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zo9xv-0002UA-8O for bug-gnu-emacs@gnu.org; Mon, 19 Oct 2015 08:55:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37079) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zo9xv-0002U3-50 for bug-gnu-emacs@gnu.org; Mon, 19 Oct 2015 08:55:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Zo9xu-0006iq-Q1 for bug-gnu-emacs@gnu.org; Mon, 19 Oct 2015 08:55:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <56249650.5050804@cs.ucla.edu> Resent-From: Andy Moreton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Oct 2015 12:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21707 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.144525928125804 (code B ref -1); Mon, 19 Oct 2015 12:55:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 19 Oct 2015 12:54:41 +0000 Original-Received: from localhost ([127.0.0.1]:56020 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zo9xZ-0006i7-75 for submit@debbugs.gnu.org; Mon, 19 Oct 2015 08:54:41 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:35827) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zo9xV-0006hy-U8 for submit@debbugs.gnu.org; Mon, 19 Oct 2015 08:54:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zo9xU-0002Iu-Jq for submit@debbugs.gnu.org; Mon, 19 Oct 2015 08:54:37 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:42158) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zo9xU-0002Iq-HZ for submit@debbugs.gnu.org; Mon, 19 Oct 2015 08:54:36 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45802) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zo9xT-0004MR-LR for bug-gnu-emacs@gnu.org; Mon, 19 Oct 2015 08:54:36 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zo9xO-0002Dz-Mw for bug-gnu-emacs@gnu.org; Mon, 19 Oct 2015 08:54:35 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:48765) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zo9xO-0002DP-Fs for bug-gnu-emacs@gnu.org; Mon, 19 Oct 2015 08:54:30 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1Zo9xH-0004ec-Jw for bug-gnu-emacs@gnu.org; Mon, 19 Oct 2015 14:54:23 +0200 Original-Received: from uk.solarflare.com ([193.34.186.16]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 19 Oct 2015 14:54:23 +0200 Original-Received: from andrewjmoreton by uk.solarflare.com with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 19 Oct 2015 14:54:23 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 25 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: uk.solarflare.com User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (windows-nt) Cancel-Lock: sha1:zZuMCuD+/jVrB1qxdHGLhLAXo5E= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:107756 Archived-At: On Mon 19 Oct 2015, Eli Zaretskii wrote: >> From: Paul Eggert >> Date: Mon, 19 Oct 2015 00:05:52 -0700 >> >> Attached is a patch to remove unnecessary #include directives from the src >> directory, and add a few #include directives that should be there. I'm not >> installing this now, to give Eli a heads-up in case this affects the MS-Windows >> port. > > I had compilation warnings and errors due to redisplaying_p and > cancel_hourglass not being declared in eval.c and lread.c. These two > files need to include dispextern.h to avoid that problem. (This isn't > Windows specific, so I wonder how it compiled for you.) > > Otherwise, LGTM, thanks. > > Would someone with MinGW64 installed please try this patch and see > that it works there as well? I've done a full bootstrap without problems on MinGW64 from commit f1575763c0d3 with the patch and your additional fixes (which are needed on MinGW64 too). AndyM