From: Andy Moreton <andrewjmoreton@gmail.com>
To: 21707@debbugs.gnu.org
Subject: bug#21707: include-file cleanup for src directory
Date: Mon, 19 Oct 2015 13:54:15 +0100 [thread overview]
Message-ID: <vz1fv17nhmw.fsf@gmail.com> (raw)
In-Reply-To: <56249650.5050804@cs.ucla.edu>
On Mon 19 Oct 2015, Eli Zaretskii wrote:
>> From: Paul Eggert <eggert@cs.ucla.edu>
>> Date: Mon, 19 Oct 2015 00:05:52 -0700
>>
>> Attached is a patch to remove unnecessary #include directives from the src
>> directory, and add a few #include directives that should be there. I'm not
>> installing this now, to give Eli a heads-up in case this affects the MS-Windows
>> port.
>
> I had compilation warnings and errors due to redisplaying_p and
> cancel_hourglass not being declared in eval.c and lread.c. These two
> files need to include dispextern.h to avoid that problem. (This isn't
> Windows specific, so I wonder how it compiled for you.)
>
> Otherwise, LGTM, thanks.
>
> Would someone with MinGW64 installed please try this patch and see
> that it works there as well?
I've done a full bootstrap without problems on MinGW64 from commit
f1575763c0d3 with the patch and your additional fixes (which are needed
on MinGW64 too).
AndyM
next prev parent reply other threads:[~2015-10-19 12:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-19 7:05 bug#21707: include-file cleanup for src directory Paul Eggert
2015-10-19 7:23 ` Eli Zaretskii
2015-10-19 12:54 ` Andy Moreton [this message]
2015-10-19 13:23 ` Eli Zaretskii
2015-10-20 5:54 ` Paul Eggert
2015-10-20 8:23 ` Andy Moreton
2015-10-20 15:06 ` Eli Zaretskii
2015-10-20 15:06 ` Eli Zaretskii
2015-10-20 18:50 ` Paul Eggert
2015-10-20 19:15 ` Eli Zaretskii
2015-10-20 20:52 ` Paul Eggert
2015-10-20 19:28 ` Andy Moreton
2015-10-21 1:38 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vz1fv17nhmw.fsf@gmail.com \
--to=andrewjmoreton@gmail.com \
--cc=21707@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).