bug#20318: 24.5; %N in message-citation-line-format

bug#20318: 24.5; %N in message-citation-line-format

[Nicolas Graner]

The %N specification in message-citation-line-format doesn't work when
replying to email while Gnus is not loader. When a real name and an
email address are present in the original message, it displays both,
instead of just the real name. This doesn't happen if Gnus is loaded.

Example starting from emacs -Q:

(setq message-citation-line-function 'message-insert-formatted-citation-line
      message-citation-line-format "%N writes:")
M-x rmail
r
C-c C-y



The first unread message in my mailbox had:

From: Hervé Le Tellier <herve.le.tellier@gmail.com>

The citation line inserted in the reply was:
Hervé Le Tellier <herve.le.tellier@gmail.com> writes:

but it should be:
Hervé Le Tellier writes:

The same happens when replying to any message which has both a real name
and an address in its "From" header.

Here is a patch that works for me:

*** /usr/share/emacs/24.5/lisp/gnus/message.el.old	2015-04-02 09:23:06.000000000 +0200
--- /usr/share/emacs/24.5/lisp/gnus/message.el.new	2015-04-13 00:51:08.421875000 +0200
*************** (defun message-insert-formatted-citation
*** 3923,3929 ****
      (unless from
        (setq from (mail-header-from message-reply-headers)))
      (let* ((data (condition-case ()
! 		     (funcall (if (boundp gnus-extract-address-components)
  				  gnus-extract-address-components
  				'mail-extract-address-components)
  			      from)
--- 3923,3929 ----
      (unless from
        (setq from (mail-header-from message-reply-headers)))
      (let* ((data (condition-case ()
! 		     (funcall (if (boundp 'gnus-extract-address-components)
  				  gnus-extract-address-components
  				'mail-extract-address-components)
  			      from)


Hope this helps.

Nicolas Graner


--------------------------------------------------



In GNU Emacs 24.5.1 (i686-pc-cygwin, GTK+ Version 3.14.10)
 of 2015-04-10 on desktop-new
Configured using:
 `configure
--srcdir=/home/kbrown/src/cygemacs/emacs-24.5-1.i686/src/emacs-24.5
--prefix=/usr --exec-prefix=/usr --localstatedir=/var --sysconfdir=/etc
--docdir=/usr/share/doc/emacs --htmldir=/usr/share/doc/emacs/html -C
--without-gconf --without-gsettings 'CFLAGS=-ggdb -O2 -pipe
-Wimplicit-function-declaration
-fdebug-prefix-map=/home/kbrown/src/cygemacs/emacs-24.5-1.i686/build=/usr/src/debug/emacs-24.5-1
-fdebug-prefix-map=/home/kbrown/src/cygemacs/emacs-24.5-1.i686/src/emacs-24.5=/usr/src/debug/emacs-24.5-1'
CPPFLAGS= LDFLAGS='

Important settings:
  value of $LANG: fr_FR
  locale-coding-system: iso-latin-1-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent messages:
For information about GNU Emacs and the GNU system, type M-x about-emacs.

Load-path shadows:
~/bin/Emacs/solitaire hides /usr/share/emacs/24.5/lisp/play/solitaire
~/bin/Emacs/undigest hides /usr/share/emacs/24.5/lisp/mail/undigest

Features:
(shadow sort mail-extr emacsbug message derived format-spec rfc822 mml
easymenu mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231
mailabbrev nnheader gnus-util gmm-utils mailheader sendmail rfc2047
rfc2045 ietf-drums mm-util help-fns mail-prsvr mail-utils time-date
cl-macs cl gv cl-loaddefs cl-lib tooltip electric uniquify ediff-hook
vc-hooks lisp-float-type mwheel x-win x-dnd tool-bar dnd fontset image
regexp-opt fringe tabulated-list newcomment lisp-mode prog-mode register
page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock
font-lock syntax facemenu font-core frame cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew
greek romanian slovak czech european ethiopic indian cyrillic chinese
case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice
loaddefs button faces cus-face macroexp files text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote make-network-process dbusbind
gfilenotify dynamic-setting font-render-setting move-toolbar gtk
x-toolkit x multi-tty emacs)

Memory information:
((conses 8 104300 11252)
 (symbols 24 18757 0)
 (miscs 20 31 175)
 (strings 16 12213 3348)
 (string-bytes 1 342184)
 (vectors 8 7718)
 (vector-slots 4 349875 3650)
 (floats 8 64 265)
 (intervals 28 570 797)
 (buffers 512 11))

---
Ce courrier électronique ne contient aucun virus ou logiciel malveillant parce que la protection avast! Antivirus est active.
http://www.avast.com

bug#20318: 24.5; %N in message-citation-line-format

[Glenn Morris]

Version: 25.1

Thanks; applied.