From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Randy Taylor Newsgroups: gmane.emacs.bugs Subject: bug#61302: 29.0.60; rust-ts-mode does not show function-invocation on field-properties Date: Tue, 07 Feb 2023 14:26:54 +0000 Message-ID: References: <6209c097-0369-828a-7513-d8afb73fd7f0@secure.kjonigsen.net> <5bd2f9f0-39d5-4d6b-815d-eda20d366441@app.fastmail.com> <32e34056-1a88-469a-819c-ae52e7d60712@app.fastmail.com> <3e40d23f-1629-c5b7-1f17-d769790d6494@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5277"; mail-complaints-to="usenet@ciao.gmane.io" Cc: eliz@gnu.org, Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= , 61302@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 07 15:28:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pPOxE-0001BK-KJ for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 07 Feb 2023 15:28:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pPOx2-0006OT-F4; Tue, 07 Feb 2023 09:28:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPOx0-0006ND-Q2 for bug-gnu-emacs@gnu.org; Tue, 07 Feb 2023 09:28:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pPOx0-0006js-GW for bug-gnu-emacs@gnu.org; Tue, 07 Feb 2023 09:28:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pPOx0-0003Jn-9b for bug-gnu-emacs@gnu.org; Tue, 07 Feb 2023 09:28:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Feb 2023 14:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61302 X-GNU-PR-Package: emacs Original-Received: via spool by 61302-submit@debbugs.gnu.org id=B61302.167578003612707 (code B ref 61302); Tue, 07 Feb 2023 14:28:02 +0000 Original-Received: (at 61302) by debbugs.gnu.org; 7 Feb 2023 14:27:16 +0000 Original-Received: from localhost ([127.0.0.1]:51620 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPOwF-0003Ir-Sw for submit@debbugs.gnu.org; Tue, 07 Feb 2023 09:27:16 -0500 Original-Received: from mail-4317.proton.ch ([185.70.43.17]:47447) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPOwD-0003Id-KG for 61302@debbugs.gnu.org; Tue, 07 Feb 2023 09:27:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1675780025; x=1676039225; bh=N0kV45R4uSyGIJ5SMA00y3tFfjm5kDt7iJvdZ4IVC3U=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=kCtvHWcwDHPshw2C/6oqhe6i1hIyStR3D4HXqgGRu6s9qIQArkwaKNvqt/FA01RS4 yyZF1yWhFsOSfkfX9MEKLUSOZweMenaT7SHLUfxd0iWWjoh2iqlJbEEmPZ5qVRen/P 47uoiUzHcGXx3pgMZdLVcSxNXTOlnLDam6OC2SggwYQ/FcIN1AZtkL7HT+g2MRoBDr dIHcEGqXo2PGae6vDO6bzApx+/q3/bDERMxHkZLWyJ8n7ynxCcspH9vnbkSVeo3OW2 AblQQTs5o9S1TRu3NeP0Gl3ViJmHrEeW8m4cAaaucMkaiJPMmSVlHtpWhAYaOGlYoH lOYUE5o7jMseQ== In-Reply-To: <3e40d23f-1629-c5b7-1f17-d769790d6494@yandex.ru> Feedback-ID: 44397038:user:proton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255050 Archived-At: On Sunday, February 5th, 2023 at 21:45, Dmitry Gutov wro= te: >=20 > In the meantime, I've also added highlighting of variable declarations > to go-ts-mode (to 'definition', so it's on feature level 3). This should > finish bringing rust and go ts modes to parity with the rest. >=20 > Please take it for a spin when you have the time. I'm not too familiar > with Go, so I could have missed some cases. But hopefully not. Hi Dmitry, I've given them a test spin. c/c++-ts-modes look good to me. go-ts-mode looks good to me. rust-ts-mode looks good to me as well except the imports. Stuff like: use std::fmt::{Display, Formatter}; is highlighted incorrectly. In the above example, std and fmt are highlight= ed as variables. We should give them font-lock-constant-face. I will try to propose a patch later today unless someone beats me to it.