From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#17884: 24.3.92; `vc-next-action' discards commit message Date: Sat, 12 Jul 2014 16:25:20 -0400 Message-ID: References: <53C09C9C.1040302@cs.ucla.edu> <53C0A6D0.3060806@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1405196776 23081 80.91.229.3 (12 Jul 2014 20:26:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 12 Jul 2014 20:26:16 +0000 (UTC) Cc: rcopley@gmail.com, 17884@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 12 22:26:09 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1X63s0-0007eM-6N for geb-bug-gnu-emacs@m.gmane.org; Sat, 12 Jul 2014 22:26:08 +0200 Original-Received: from localhost ([::1]:50284 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X63rz-0004JL-Pt for geb-bug-gnu-emacs@m.gmane.org; Sat, 12 Jul 2014 16:26:07 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54940) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X63rv-0004JB-Ui for bug-gnu-emacs@gnu.org; Sat, 12 Jul 2014 16:26:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X63rv-0004Tt-6V for bug-gnu-emacs@gnu.org; Sat, 12 Jul 2014 16:26:03 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:32992) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X63rv-0004Tk-37 for bug-gnu-emacs@gnu.org; Sat, 12 Jul 2014 16:26:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1X63ru-00007R-KG for bug-gnu-emacs@gnu.org; Sat, 12 Jul 2014 16:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 Jul 2014 20:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17884 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17884-submit@debbugs.gnu.org id=B17884.1405196725404 (code B ref 17884); Sat, 12 Jul 2014 20:26:02 +0000 Original-Received: (at 17884) by debbugs.gnu.org; 12 Jul 2014 20:25:25 +0000 Original-Received: from localhost ([127.0.0.1]:40963 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X63rI-00006S-Us for submit@debbugs.gnu.org; Sat, 12 Jul 2014 16:25:25 -0400 Original-Received: from fencepost.gnu.org ([208.118.235.10]:44377 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X63rG-00006J-2G for 17884@debbugs.gnu.org; Sat, 12 Jul 2014 16:25:22 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1X63rF-0006co-5K; Sat, 12 Jul 2014 16:25:21 -0400 X-Spook: Becker Ermes RSA Etacs Albanian Soviet Iran [Hello to all X-Ran: ~K-yX2YoED&Y-rB_HPM|k.'CHLiV4*CwtAqHN%T"0KSoJ=bY\y9/x=[Lldw'O1Wjdd*d'Q X-Hue: black X-Attribution: GM In-Reply-To: <53C0A6D0.3060806@cs.ucla.edu> (Paul Eggert's message of "Fri, 11 Jul 2014 20:09:04 -0700") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:91474 Archived-At: Paul Eggert wrote: > bzr 117371 didn't use log-edit-empty-buffer-p, as its module might not > be loaded and I didn't want to introduce an unnecessary dependency. > But perhaps the dependency is necessary after all. I don't see the issue. We are talking about vc-dispatcher calling log-edit, which is defined in log-edit.el, which is also where log-edit-empty-buffer-p is defined. So just make vc-log-edit explicitly require log-edit? For the other thing I mentioned, I think checking whether there is an existing local value of vc-log-fileset that matches the new one should cover it.