From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Randy Taylor Newsgroups: gmane.emacs.bugs Subject: bug#70657: [PATCH] Add go-ts-mode font-locking for function var decls Date: Thu, 09 May 2024 00:30:14 +0000 Message-ID: References: <00B8CD38-0C6F-4051-B100-FF5B979BF9CC@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8927"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Yuan Fu , "70657-done@debbugs.gnu.org" <70657-done@debbugs.gnu.org> To: Noah Peart Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 09 02:31:17 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s4rgr-0002Gx-Ix for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 09 May 2024 02:31:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s4rgU-0004FR-UG; Wed, 08 May 2024 20:30:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s4rgE-00046M-5s for bug-gnu-emacs@gnu.org; Wed, 08 May 2024 20:30:38 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s4rgD-0006NO-2r for bug-gnu-emacs@gnu.org; Wed, 08 May 2024 20:30:37 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s4rgc-0005VA-Ei for bug-gnu-emacs@gnu.org; Wed, 08 May 2024 20:31:02 -0400 Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 May 2024 00:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 70657 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 70657@debbugs.gnu.org, dev@rjt.dev, noah.v.peart@gmail.com Original-Received: via spool by 70657-done@debbugs.gnu.org id=D70657.171521465821134 (code D ref 70657); Thu, 09 May 2024 00:31:02 +0000 Original-Received: (at 70657-done) by debbugs.gnu.org; 9 May 2024 00:30:58 +0000 Original-Received: from localhost ([127.0.0.1]:51766 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s4rgX-0005Uo-KG for submit@debbugs.gnu.org; Wed, 08 May 2024 20:30:58 -0400 Original-Received: from mail-4022.proton.ch ([185.70.40.22]:50253) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s4rgQ-0005Uc-V5 for 70657-done@debbugs.gnu.org; Wed, 08 May 2024 20:30:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1715214618; x=1715473818; bh=DzkzkU6x8dPLdvf+2etCo2oI6jFrQ3nEvMTKxUvlRto=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=uKt2f9/w+iGOTfNf9h6cbu+pFPxLwUfnYidr0YNabylviwrI7k+0GRsJ2IB8k/jM/ I4apTvhZu/9iDstig9WspwnyEe8o2iEEG5EbsnGxLaUBiNZ1QK/RJ0y87ll8BJ6elg ordN2eZszNgPRnqRjjmxAzenuoEuDPJxF0tkl0PqAk0HWPwejfA1EhIfIpKqji2bLR bwkBGRRb2op4kByOw/VZnQHTfsxbmoLh6THUJb9VD30IQe7dPbvlqEmYWCfaapaOka 3e5DjC+v6auhyYMYZ6y/VS97On0ezd9Fp9grZhfl2DXQKVtRvCnvS41AvREqk4l6jP AvlMF1YEvquMg== In-Reply-To: Feedback-ID: 44397038:user:proton X-Pm-Message-ID: 712e1ef2cb52536a71abe37e61e9e2aee4493286 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284702 Archived-At: On Thursday, May 2nd, 2024 at 06:27, Noah Peart wr= ote: > > Do we know how does other editors fontify this statement? Or maybe we c= an look > > at how does the official documentation highlight their code? >=20 > From what I can tell, both neovim and vscode give them variable font-lock= ing (basic vim doesnt > give them any font). The syntax highlighting is very basic in the officia= l docs I looked at (just the repl in Tour of Go), not > giving variables any highlight. >=20 > They are variables with function values like Randy said, and looking now = at other languages > it seems like they all give variable font-locking to named closures (eg. = rust-ts-mode, lambdas in ruby-ts-mode). >=20 > > I'm not sure we want to do this though, since they are still variables. >=20 > Sounds good, thanks for taking a look. Closing.