From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ulrich Mueller <ulm@gentoo.org> Newsgroups: gmane.emacs.bugs Subject: bug#67012: 29.1; epa-sign-file pinentry loopback mode does not work with S/MIME Date: Fri, 17 Nov 2023 12:40:05 +0100 Message-ID: <uy1ewmwve@gentoo.org> References: <u4jhvqus0@gentoo.org> <83jzqjqfma.fsf@gnu.org> <87leaz9hrv.fsf@gmx.de> <83h6lnq7y7.fsf@gnu.org> <u34x6nhuq@gentoo.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4628"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii <eliz@gnu.org>, Michael Albinus <michael.albinus@gmx.de> To: 67012@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 17 12:41:19 2023 Return-path: <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org> Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org>) id 1r3xDq-00015F-WC for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 17 Nov 2023 12:41:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <bug-gnu-emacs-bounces@gnu.org>) id 1r3xDd-0003Ba-7L; Fri, 17 Nov 2023 06:41:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1r3xDb-00036r-V3 for bug-gnu-emacs@gnu.org; Fri, 17 Nov 2023 06:41:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1r3xDZ-0001fp-In for bug-gnu-emacs@gnu.org; Fri, 17 Nov 2023 06:41:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1r3xDZ-0003XZ-Ne for bug-gnu-emacs@gnu.org; Fri, 17 Nov 2023 06:41:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ulrich Mueller <ulm@gentoo.org> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org> Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Nov 2023 11:41:01 +0000 Resent-Message-ID: <handler.67012.B67012.170022122013553@debbugs.gnu.org> Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67012 X-GNU-PR-Package: emacs Original-Received: via spool by 67012-submit@debbugs.gnu.org id=B67012.170022122013553 (code B ref 67012); Fri, 17 Nov 2023 11:41:01 +0000 Original-Received: (at 67012) by debbugs.gnu.org; 17 Nov 2023 11:40:20 +0000 Original-Received: from localhost ([127.0.0.1]:45441 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>) id 1r3xCt-0003WX-PO for submit@debbugs.gnu.org; Fri, 17 Nov 2023 06:40:20 -0500 Original-Received: from woodpecker.gentoo.org ([2001:470:ea4a:1:5054:ff:fec7:86e4]:36639 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ulm@gentoo.org>) id 1r3xCr-0003WG-6K for 67012@debbugs.gnu.org; Fri, 17 Nov 2023 06:40:18 -0500 In-Reply-To: <u34x6nhuq@gentoo.org> (Ulrich Mueller's message of "Thu, 16 Nov 2023 10:54:37 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-gnu-emacs>, <mailto:bug-gnu-emacs-request@gnu.org?subject=unsubscribe> List-Archive: <https://lists.gnu.org/archive/html/bug-gnu-emacs> List-Post: <mailto:bug-gnu-emacs@gnu.org> List-Help: <mailto:bug-gnu-emacs-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-gnu-emacs>, <mailto:bug-gnu-emacs-request@gnu.org?subject=subscribe> Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274498 Archived-At: <http://permalink.gmane.org/gmane.emacs.bugs/274498> Until there's a proper fix (not anytime soon, I suppose?), could we please disable pinentry loopback with gpgsm? See patch below. That way, the user could still set epg-pinentry-mode to loopback for use with gpg2, and with gpgsm it would fall back to passphrase input through the pinentry program (i.e. in the GUI). This seems to be better than erroring out. (In fact, I use gpgsm with pinentry.el from Emacs 25.3 as a workaround. Unfortunately, that package has been removed as a fix for bug #27445.) >From b1cbdfc8f4890c6cb31cc8d59b347aedfb2f7f5d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ulrich=20M=C3=BCller?= <ulm@gentoo.org> Date: Fri, 17 Nov 2023 12:16:54 +0100 Subject: [PATCH] Don't enable pinentry loopback mode for gpgsm * lisp/epg.el (epg--start): Passphrase entry through the minibuffer is currently not supported with gpgsm, therefore don't pass "--pinentry-mode loopback" as an argument when the protocol is CMS. (Bug#67012) --- lisp/epg.el | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/lisp/epg.el b/lisp/epg.el index aae9b9444b4..b994c1b9ca2 100644 --- a/lisp/epg.el +++ b/lisp/epg.el @@ -595,7 +595,12 @@ epg--start (if (epg-context-textmode context) '("--textmode")) (if (epg-context-output-file context) (list "--output" (epg-context-output-file context))) - (if (epg-context-pinentry-mode context) + (if (and (epg-context-pinentry-mode context) + (not + ;; loopback doesn't work with gpgsm + (and (eq (epg-context-protocol context) 'CMS) + (eq (epg-context-pinentry-mode context) + 'loopback)))) (list "--pinentry-mode" (symbol-name (epg-context-pinentry-mode context)))) -- 2.42.1