From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Paul Nelson Newsgroups: gmane.emacs.bugs Subject: bug#74140: [PATCH] Add :continue-only directive for repeat maps in bind-keys, use-package Date: Mon, 16 Dec 2024 06:57:13 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26595"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 74140@debbugs.gnu.org, eliz@gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 16 06:59:50 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tN490-0006nW-0D for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 16 Dec 2024 06:59:50 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tN48I-0001oQ-Cz; Mon, 16 Dec 2024 00:59:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tN48H-0001ny-7D for bug-gnu-emacs@gnu.org; Mon, 16 Dec 2024 00:59:05 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tN48G-0002IR-Nu for bug-gnu-emacs@gnu.org; Mon, 16 Dec 2024 00:59:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:In-Reply-To:From:To:References:Subject; bh=i4Ig8DSpyS58PcWq4ToNLW3VMzUgbc71YAqQsWDG4WQ=; b=VFilwVWZJTXHBDdmFWXsW7gZtDr6fJCLttVR+0aS5XRXEbRPIMFJteNp2ZDRSvcHccXD35pBp0qK/4TO4/LV4ADwUxSBo4VnaTAFKHlIdJe7TDGCr1PNKE+cNXxaeUwfjS5ojoKhwPMKH3zvLcfG09WL+/yIYBOaazRaUEohQWWIXllILUfDekSmcshQxDfTIOaAnI/yy6WmoWd5vSBwPOzh1JbgJs1XzMrKfIStftVHzooIgWtdGutbwaFGyIMB81DyGtMRIsY6DfCwqOdiAtuGRwm6S3hSKZLEnZvEEuR+gNQU+Zk3D6mtgX+crT6rd37TK871TIbsaOAFrI7TkA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tN48F-0003SN-BL for bug-gnu-emacs@gnu.org; Mon, 16 Dec 2024 00:59:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Paul Nelson Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Dec 2024 05:59:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74140 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74140-submit@debbugs.gnu.org id=B74140.173432870713181 (code B ref 74140); Mon, 16 Dec 2024 05:59:03 +0000 Original-Received: (at 74140) by debbugs.gnu.org; 16 Dec 2024 05:58:27 +0000 Original-Received: from localhost ([127.0.0.1]:53138 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tN47f-0003QX-81 for submit@debbugs.gnu.org; Mon, 16 Dec 2024 00:58:27 -0500 Original-Received: from mail-lf1-f53.google.com ([209.85.167.53]:46163) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tN47a-0003Q4-Sl for 74140@debbugs.gnu.org; Mon, 16 Dec 2024 00:58:24 -0500 Original-Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-54021daa6cbso4392690e87.0 for <74140@debbugs.gnu.org>; Sun, 15 Dec 2024 21:58:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734328637; x=1734933437; darn=debbugs.gnu.org; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=i4Ig8DSpyS58PcWq4ToNLW3VMzUgbc71YAqQsWDG4WQ=; b=D7atBIbSSo7f3rz8iBE5joq1TeDSYPfIMU0tWRxQ3gzA2kj1duMiNy9CLTlc6oHXrj cjgwSEDDkNve6yiHJ1MMRBFdhXiSwtbSgTXaAkojkwDGrwR2yCQMV+Q6+3Qznc5vt1eh 5Z8MtgsMzikzYLsGVcUHRkeaRNebo1p254UHCj8PNvaxCba/9XpE2i01DWSarX6haEQP Yy7iJGLteELh7Z4UMwbSRqaBYP+dJrR+3tfp/H4pFfn3daI6AAYOrlO706N44Mxg4lGy YJRd6OO7akp6BA8250/zv5OCSMB4eO03sZt/5HQvP0ZRBPnjguUSin/O4F9uxhxP4aSi gtZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734328637; x=1734933437; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=i4Ig8DSpyS58PcWq4ToNLW3VMzUgbc71YAqQsWDG4WQ=; b=HYrySaJZD3cTI1IueCHvPRiHh2lScBTDZI6o/yfaEQ6NhVK22pBEmW5+mpXjArBeti oniF2Yu7HVeEkgAGThySh5dsihGJQDw+DX5hTSWqeZdX1mAuVwDHSv1r3I/dvL0lNs0D exC3kFT0wHIsfi6HQv5W9wvFucZK/REaW80hoBfzlXEhQVic60TvW6C6hntjlbOdR5F/ t2JGc+ic1In6XXilEq0i3slsy0Tgqyuj0AqMqLXn+3b3NoxZFMNKzc3BBftv9Wr83UQA vIYMh2uAqwJGh9hs9aycotN91Asd/w+YWrptcRD+XfNSssFN5D67RJf5IfUpeLUTRDo8 90+Q== X-Forwarded-Encrypted: i=1; AJvYcCXlrrcRAn/0ze7UGhjR2HT8N5y6PMxVTxA83KEWde36WTZ0GFNlv5ZJ4Ipp2ypnT2QOxZ1kSA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyykIBswH3vDcDxec+xLjLVVWDd/4n0AzVqAz1JSawlYA1Mla01 KO9fww1C0eJtjuHupaKFQDwv2GOf2v4jDjcace79EAlxmK7w9ABI X-Gm-Gg: ASbGnctrx3k4447xmaocCvbLs/UFU45zu41T1wwBPdhqLGk1n0Z6Bwh2BpEDRQcS+pm JbybQZmwNW0AYCcxOJI5O08/xEbzb5ju1ckoi0ZSU1yLgYI2XEJQtrvEPgDw9v+QUTCY6MVEL1P ItAmycbvLv+KtCvGlpIW6OnSVzk1ggxqgidkDKhna/ZToiEnjcBdya16rFuK5c0ySzQbvy5rNYe 25IBcg4DEJidOWDqjDo9VjW5oWwzPFVC4W6is2HVSY1T4pbLl+sxlJZiMtSIF3yDkILoCBr1Vv7 087rDXEIWbVoppeSwzgCz8M= X-Google-Smtp-Source: AGHT+IFFuCFyjXYOEMfSlImHl7LkzBFtHcWjn4gNluLo4XQalG+m+xPLiFV5tB1yQHNvTfMRnlYUtQ== X-Received: by 2002:a05:6512:304e:b0:540:202f:4955 with SMTP id 2adb3069b0e04-540905a7afcmr3346073e87.46.1734328636532; Sun, 15 Dec 2024 21:57:16 -0800 (PST) Original-Received: from localhost (0x573d66b5.static.cust.fastspeed.dk. [87.61.102.181]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54120b9f366sm713661e87.11.2024.12.15.21.57.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Dec 2024 21:57:15 -0800 (PST) In-Reply-To: <87ldwvicgf.fsf@mail.linkov.net> (message from Juri Linkov on Wed, 04 Dec 2024 19:29:20 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297155 Archived-At: Thanks Juri, I took a look at your implementation. It has at least the following issue: the same command cannot be used to continue several repeat maps. Consider for instance the following example: (defvar-keymap repeat-list-map :doc "Keymap for repeating sequences." :repeat ( :continue-only (yank undo)) "n" 'forward-list "p" 'backward-list "C-/" 'undo "y" 'yank) (defvar-keymap repeat-paragraph-map :doc "Keymap for repeating sequences." :repeat ( :continue-only (yank undo)) "]" 'forward-paragraph "}" 'forward-paragraph "[" 'backward-paragraph "{" 'backward-paragraph "C-/" 'undo "y" 'yank) This is why I think the repeat-continue-only property should be a list specifying which repeat maps the command should continue.