From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ulrich Mueller Newsgroups: gmane.emacs.bugs Subject: bug#66125: 29.1; configure --with-small-ja-dic has no effect Date: Sat, 23 Sep 2023 23:29:33 +0200 Message-ID: References: <838r90byil.fsf@gnu.org> <834jjobwx1.fsf@gnu.org> <837coh5no9.fsf@gnu.org> <83wmwh44gm.fsf@gnu.org> <83o7ht3vy5.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11813"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 66125@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 23 23:30:08 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qkACW-0002tz-NJ for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 Sep 2023 23:30:08 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qkACG-00011Q-Qd; Sat, 23 Sep 2023 17:29:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qkACF-00011D-O5 for bug-gnu-emacs@gnu.org; Sat, 23 Sep 2023 17:29:51 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qkACF-00049q-Fo for bug-gnu-emacs@gnu.org; Sat, 23 Sep 2023 17:29:51 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qkACQ-00061c-Qj for bug-gnu-emacs@gnu.org; Sat, 23 Sep 2023 17:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ulrich Mueller Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Sep 2023 21:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66125 X-GNU-PR-Package: emacs Original-Received: via spool by 66125-submit@debbugs.gnu.org id=B66125.169550459823125 (code B ref 66125); Sat, 23 Sep 2023 21:30:02 +0000 Original-Received: (at 66125) by debbugs.gnu.org; 23 Sep 2023 21:29:58 +0000 Original-Received: from localhost ([127.0.0.1]:40698 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkACM-00060u-8f for submit@debbugs.gnu.org; Sat, 23 Sep 2023 17:29:58 -0400 Original-Received: from woodpecker.gentoo.org ([2001:470:ea4a:1:5054:ff:fec7:86e4]:33685 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkACJ-00060g-0g for 66125@debbugs.gnu.org; Sat, 23 Sep 2023 17:29:57 -0400 In-Reply-To: <83o7ht3vy5.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 23 Sep 2023 15:39:30 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271192 Archived-At: >>>>> On Sat, 23 Sep 2023, Eli Zaretskii wrote: >> > (The "if test" part of the new target's rules could be updated to >> > check that the small-ja-dic-option file exists, and generate a >> > non-empty file if not.) >> >> IMHO this would be cleaner. > Can you try that and see if there are no other issues? I did some tests and ended up replacing the small-ja-dic-option recipe in leim/Makefile.in with something very simple: # This is used to support regeneration of ja-dic when the SMALL_JA_DIC # option is flipped by the configure-time option. small-ja-dic-option: ../config.status $(AM_V_GEN)echo "small ja-dic option: $(SMALL_JA_DIC)" > $@.$$$$ && \ ${top_srcdir}/build-aux/move-if-change $@.$$$$ $@ AFAICS this does what is intended, i.e. the detour via recording the option in ja-dic.el isn't even needed.