unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: 2151@emacsbugs.donarmstrong.com
Subject: bug#2151: 23.0.90; Building the 23.0.90 pretest recompiles Lisp files
Date: Fri, 27 Feb 2009 17:02:38 +0200	[thread overview]
Message-ID: <uvdqvq5wx.fsf@gnu.org> (raw)
In-Reply-To: <ubpsvt8pt.fsf@gnu.org>

> Date: Sun, 22 Feb 2009 06:07:58 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: 2151@emacsbugs.donarmstrong.com
> 
> > From: Stefan Monnier <monnier@iro.umontreal.ca>
> > Cc: 2151@emacsbugs.donarmstrong.com
> > Date: Sat, 21 Feb 2009 17:49:16 -0500
> > 
> > >> I'd rather not if the patch I suggested works.  Does it?
> > 
> > > Maybe it does, but it isn't meant to solve the problem at hand, as it
> > > builds bootstrap-emacs unconditionally.
> > 
> > Not sure what you mean.  It solves the title problem "pretest recompiles
> > Lisp files".  AFAIK the only thing it does unnecessarily is to dump
> > Emacs twice.
> 
> Yes.  And the Right Solution (IMO) is to invoke src/Makefile with
> `boot' argument empty, which would only dump once and not recompile
> anything.

A new idea: can we avoid the `boot=bootstrap-emacs$(EXEEXT)' thing in
top-level Makefile.in by testing for some file that is only present
when Emacs is built out of CVS?  For example, the `admin' directory is
not in the pretest/release tarballs; can we test for its existence and
invoke sub-Make's with `boot=""' if `admin' is not there?

There's one other reason for compiling Lisp files during the build, it
is this fragment from the top-level Makefile.in:

    # Subdirectories to make recursively.  `lisp' is not included
    # because the compiled lisp files are part of the distribution.
    # leim is not included because it needs special handling.
    # 
    # Actually, we now include `lisp' as well, since the compiled files
    # are not included any more in case of bootstrap or in case Emacs was
    # checked out from a VCS.
    SUBDIR = lib-src src lisp

The second part gives the rationale for adding `lisp' to the list, but
that rationale is not valid for when Emacs is built from a pretest or
release tarball.  Is it okay to avoid recursing into `lisp' in that
case, again by testing the existence of `admin' or some such?






  reply	other threads:[~2009-02-27 15:02 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-02  6:03 bug#2151: 23.0.90; Building the 23.0.90 pretest recompiles Lisp files Eli Zaretskii
2009-02-02 16:02 ` Stefan Monnier
2009-02-02 20:42   ` Eli Zaretskii
2009-02-03 21:24     ` Stefan Monnier
2009-02-04  4:25       ` Eli Zaretskii
2009-02-04 19:51         ` Stefan Monnier
2009-02-21 16:10           ` Eli Zaretskii
2009-02-21 20:54             ` Stefan Monnier
2009-02-21 22:33               ` Eli Zaretskii
2009-02-21 22:49                 ` Stefan Monnier
2009-02-22  4:07                   ` Eli Zaretskii
2009-02-27 15:02                     ` Eli Zaretskii [this message]
2009-02-27 22:18                       ` Eli Zaretskii
2009-02-27 23:21                         ` Glenn Morris
2009-02-28 11:12                           ` Eli Zaretskii
2009-02-28  4:48                       ` Stefan Monnier
2009-02-28 10:41                         ` Eli Zaretskii
2009-02-28 22:06                           ` Stefan Monnier
2009-02-28 22:11                             ` Eli Zaretskii
2009-05-01 19:07                             ` Eli Zaretskii
2011-09-11 21:12                               ` Lars Magne Ingebrigtsen
2011-09-11 21:50                                 ` Chong Yidong
2014-06-27  0:42                                   ` Glenn Morris
2014-06-27  5:55                                     ` Eli Zaretskii
2009-02-22 18:19               ` Kevin Rodgers
2009-02-02 21:25   ` Magnus Henoch
2009-02-02 21:55     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=uvdqvq5wx.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=2151@emacsbugs.donarmstrong.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).