From: Glenn Morris <rgm@gnu.org>
To: David De La Harpe Golden <david@harpegolden.net>
Cc: 12536@debbugs.gnu.org
Subject: bug#12536: 24.2.50; Outdated emacs22 icons in repo
Date: Mon, 15 Oct 2012 19:57:39 -0400 [thread overview]
Message-ID: <uubog370gc.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <507222FF.2040701@harpegolden.net> (David De La Harpe Golden's message of "Mon, 08 Oct 2012 01:49:03 +0100")
David De La Harpe Golden wrote:
> Well, I've used the emacs22 icon since the change, but I suppose I am
> fully capable of keeping my own copy if I want it. Or I could use the
> new emacs icon if I just changed iceweasel etc. instead, just so long
> as I don't have to juggle quite so many blue crystal spheres,
> grumble...
It's trivial (one-line patch) to put back the emacs22 icons, just not
install them.
It's only fractionally less trivial (three-line patch) to also allow
choice of icon at install time:
*** Makefile.in 2012-10-15 21:57:20 +0000
--- Makefile.in 2012-10-15 23:54:13 +0000
***************
*** 631,636 ****
--- 631,640 ----
done
## Install those items from etc/ that need to end up elsewhere.
+
+ ## Choose "emacs" or "emacs22" at installation time.
+ ## Note: emacs22 does not have all the resolutions.
+ EMACS_ICON=emacs
install-etc:
umask 022; ${MKDIR_P} $(DESTDIR)${desktopdir}
dest=`echo emacs | sed '$(TRANSFORM)'`; \
***************
*** 645,653 ****
for dir in */*/apps */*/mimetypes; do \
[ -d $${dir} ] || continue ; \
( cd $${thisdir}; ${MKDIR_P} $(DESTDIR)${icondir}/$${dir} ) ; \
! for icon in $${dir}/*.*; do \
[ -r $${icon} ] || continue ; \
! dest=`echo "$${icon}" | sed -e 's|.*/||' -e '$(TRANSFORM)'` ; \
( cd $${thisdir}; \
${INSTALL_DATA} ${iconsrcdir}/$${icon} $(DESTDIR)${icondir}/$${dir}/$${dest} ) \
|| exit 1; \
--- 649,657 ----
for dir in */*/apps */*/mimetypes; do \
[ -d $${dir} ] || continue ; \
( cd $${thisdir}; ${MKDIR_P} $(DESTDIR)${icondir}/$${dir} ) ; \
! for icon in $${dir}/${EMACS_ICON}[.-]*; do \
[ -r $${icon} ] || continue ; \
! dest=`echo "$${icon}" | sed -e 's|.*/||' -e 's/$(EMACS_ICON)/emacs/' -e '$(TRANSFORM)'` ; \
( cd $${thisdir}; \
${INSTALL_DATA} ${iconsrcdir}/$${icon} $(DESTDIR)${icondir}/$${dir}/$${dest} ) \
|| exit 1; \
prev parent reply other threads:[~2012-10-15 23:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 23:02 bug#12536: 24.2.50; Outdated emacs22 icons in repo Marcin Antczak
2012-09-28 23:48 ` Andreas Schwab
2012-09-29 0:13 ` Marcin Antczak
2012-09-29 0:46 ` Glenn Morris
2012-09-29 0:55 ` Marcin Antczak
2012-09-29 0:59 ` Glenn Morris
2012-10-01 0:31 ` Glenn Morris
2012-10-01 0:50 ` Marcin Antczak
2012-10-01 3:19 ` Chong Yidong
2012-10-01 18:01 ` Glenn Morris
2012-10-08 0:49 ` David De La Harpe Golden
2012-10-15 23:57 ` Glenn Morris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=uubog370gc.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=12536@debbugs.gnu.org \
--cc=david@harpegolden.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).