From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ulrich Mueller Newsgroups: gmane.emacs.bugs Subject: bug#61460: 30.0.50; Calendar shows eclipse for quarter moon Date: Wed, 22 Feb 2023 12:32:30 +0100 Message-ID: References: <87cz6eb10y.fsf@web.de> <87r0uu9e5v.fsf@web.de> <87mt5i9cba.fsf@web.de> <875yc4q0ee.fsf@web.de> <87y1p0obe8.fsf@web.de> <87ttzoo6px.fsf@web.de> <87pma8q2w1.fsf@web.de> <87wn4g4v1y.fsf@web.de> <87y1ovecz2.fsf@web.de> <8735739vun.fsf@web.de> <87a61759t5.fsf@web.de> <87y1oq3tm0.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31916"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) Cc: 61460@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 22 12:33:14 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pUnN3-00089Z-L0 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 22 Feb 2023 12:33:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pUnMu-0005Hg-V1; Wed, 22 Feb 2023 06:33:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUnMs-0005H9-Q7 for bug-gnu-emacs@gnu.org; Wed, 22 Feb 2023 06:33:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pUnMs-00016F-A8 for bug-gnu-emacs@gnu.org; Wed, 22 Feb 2023 06:33:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pUnMs-00032D-6M for bug-gnu-emacs@gnu.org; Wed, 22 Feb 2023 06:33:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ulrich Mueller Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 Feb 2023 11:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61460 X-GNU-PR-Package: emacs Original-Received: via spool by 61460-submit@debbugs.gnu.org id=B61460.167706556811642 (code B ref 61460); Wed, 22 Feb 2023 11:33:02 +0000 Original-Received: (at 61460) by debbugs.gnu.org; 22 Feb 2023 11:32:48 +0000 Original-Received: from localhost ([127.0.0.1]:58143 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUnMe-00031i-BC for submit@debbugs.gnu.org; Wed, 22 Feb 2023 06:32:48 -0500 Original-Received: from woodpecker.gentoo.org ([140.211.166.183]:41674 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUnMX-00031N-D2 for 61460@debbugs.gnu.org; Wed, 22 Feb 2023 06:32:47 -0500 In-Reply-To: <87y1oq3tm0.fsf@web.de> (Michael Heerdegen's message of "Wed, 22 Feb 2023 11:03:03 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:256331 Archived-At: >>>>> On Wed, 22 Feb 2023, Michael Heerdegen wrote: > Ulrich Mueller writes: >> It is probably a matter of personal taste, but I dislike the nested >> concats. This seems simpler (not tested, though): >>=20 >> - (cons mark (concat (lunar-phase-name (nth 2 phase)) " " >> - (cadr phase)))))) >> + (cons mark >> + (let ((eclipse (nth 3 phase))) >> + (concat (lunar-phase-name (nth 2 phase)) " " >> + (cadr phase) >> + (if (string-empty-p eclipse) "" " ") >> + eclipse)))))) > Fine by me (my preference would be Andreas' suggestion). Use something like =E2=80=98(unless (string-empty-p eclipse) " ")=E2=80=99?= WFM. > We also need to fix the space handling in calendar-lunar-phases aka M in > calendar - when no eclipse occurs, the descriptions end with a > trailing space. While at it, maybe replace =E2=80=98(car (last x))=E2=80=99 by =E2=80=98(nt= h 3 x)=E2=80=99?