From: Eli Zaretskii <eliz@gnu.org>
To: Alan Mackenzie <acm@muc.de>
Cc: 2738@emacsbugs.donarmstrong.com
Subject: bug#2738: Content-free doc string: `handle-shift-selection'.
Date: Mon, 23 Mar 2009 06:20:54 +0200 [thread overview]
Message-ID: <uocvsoont.fsf@gnu.org> (raw)
In-Reply-To: <20090322225915.GA4466@muc.de>
> Date: Sun, 22 Mar 2009 22:59:15 +0000
> Cc: 2738@emacsbugs.donarmstrong.com
> From: Alan Mackenzie <acm@muc.de>
>
> > Is this good enough to close the bug? If not, please tell what still
> > needs improvement.
>
> I don't think it is. I'm not sure this function can be documented
> coherently. I think it's a bad function. Sorry, I'm not being very
> constructive here. I just find the whole thing distasteful in the
> extreme, the idea that rather than binding commands to key sequences,
> with a clean separation between the interactive commander, the key
> sequences and the commands, we've now got a hodge podge where the
> command loop now actually performs part of a command's function -
> sometimes, depending on the key binding.
>
> In fact, how about just saying something like "this function ensures the
> mark is set for a movement command making a CUA region", or something
> like that?
>
> In addition this, the function is buggy. It spuriously enables
> transient-mark-mode in certain circumstances (I'll be submitting a bug
> report soon).
Well, I'm sure doc strings cannot fix buggy or bad implementation, so
please do submit a separate bug report about that.
next prev parent reply other threads:[~2009-03-23 4:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-21 17:23 bug#2738: Content-free doc string: `handle-shift-selection' Alan Mackenzie
2009-03-21 18:46 ` Eli Zaretskii
2009-03-22 22:59 ` Alan Mackenzie
2009-03-23 2:12 ` Stefan Monnier
2009-03-23 4:20 ` Eli Zaretskii [this message]
2011-07-11 14:03 ` Lars Magne Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=uocvsoont.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=2738@emacsbugs.donarmstrong.com \
--cc=acm@muc.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).