undigestify is fooled by messages containing lines of dashes

[Tim Hesterberg <timh@insightful.com>]

[-- Attachment #1: Type: text/plain, Size: 5352 bytes --]

Here is 
* a review of a problem I reported previously, 
* a new problem that occurs with the workaround.

On 10 Aug 2007 I reported:
> Using emacs 21.3, undigestify-rmail-message works fine, giving a large
> number of individual messages.
>
> Using emacs 22.1, the result is only two message:
> * correct first message, the "Today's Topics" message
> * all other real messages are kept as part of a single message.
>
> I get the same result using --no-init-file.
> ...
>
> If I use emacs 22.1 but load the emacs 21.3 version of
> .../lisp/mail/undigest.el, then undigestify works correctly.
Since then I've been using the version of undigest.el from emacs 21.3.

There is a new problem that occurs with this solution - that undigestify
thinks a line of dashes
--------------------------------------------------
separates messages, hence splits messages containing such
lines into multiple messages.

I'll attach an rmail file containing a single message, a digest
message from a mailing list.  Message 14 in the digest is a relatively
long message, containing multiple topics separated by dashed lines.

To reproduce this, load undigest.el from emacs 21.3, 
open the file using rmail, and undigestify the digest.  That long
message 14 is split into multiple messages, with all but the first having
a blank subject.  Here is the rmail summary:

    1D  6-Feb  -devel-request@r-project.[1335] R-devel Digest, Vol 60, Issue 6
    2   6-Feb  -devel-request@r-project.  [43] R-devel Digest, Vol 60, Issue 6
    3-  4-Feb     scott.yonker@gmail.com  [24] [Rd] garchFit (PR#10698)
...
   15-  6-Feb   p.murrell@auckland.ac.nz [141] Re: [Rd] Error in grid.text after tcltk package loaded
   16-  6-Feb  to: r-devel@stat.math.eth  [10] [Rd] Suggestions for R-intro manual (PR#10701)
   17-         to: r-devel@r-project.org  [23] 
   18-         to: r-devel@r-project.org  [18] 
   19-         to: r-devel@r-project.org  [10] 
   20-         to: r-devel@r-project.org  [14] 
   21-         to: r-devel@r-project.org   [8] 
   22-         to: r-devel@r-project.org  [14] 
   23-         to: r-devel@r-project.org   [7] 
   24-         to: r-devel@r-project.org   [9] 
   25-         to: r-devel@r-project.org  [31] 
   26-  6-Feb      ripley@stats.ox.ac.uk  [47] Re: [Rd] R valgrind question
   27          to: r-devel@r-project.org   [8] 

In contrast, the list of topics within the original digest:

Today's Topics:

   1. garchFit (PR#10698) (scott.yonker@gmail.com)
...
  13. Re: Error in grid.text after tcltk package loaded (Paul Murrell)
  14. Suggestions for R-intro manual (PR#10701) (timh@insightful.com)
  15. Re: R valgrind question (Prof Brian Ripley)

If I start emacs with --no-init-file I can reproduce both bugs;
failure to split into component messages with the current version of
undigest.el, and extra splits using the old version.




In GNU Emacs 22.1.1 (i386-mingw-nt5.1.2600)
 of 2007-06-02 on RELEASE
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4) --cflags -Ic:/gnuwin32/include'

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: ENU
  locale-coding-system: cp1252
  default-enable-multibyte-characters: t

Major mode: RMAIL Summary

Minor modes in effect:
  display-time-mode: t
  shell-dirtrack-mode: t
  show-paren-mode: t
  encoded-kbd-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  unify-8859-on-encoding-mode: t
  utf-translate-cjk-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t

Recent input:
SPC a n d SPC e x t r a SPC s p l i t s SPC u s i n 
g SPC t h e SPC o l d SPC v e r s i o n . C-n C-SPC 
C-n C-n C-n C-n C-n C-w C-u C-x r t e m p <return> 
C-x k <return> C-x 1 <escape> v C-u C-u C-p C-u C-p 
C-u C-p C-u C-p C-e a SPC l i n e C-n C-n C-u C-f C-u 
C-f C-u C-f C-f <escape> d s p l i t s C-n C-a <escape> 
d C-d C-u C-p C-n C-e SPC o f SPC d a s y e s <backspace> 
<backspace> <backspace> h e s C-u C-p C-u C-p C-u C-p 
C-u C-p C-p C-p C-p C-u C-f C-u C-f C-e <backspace> 
SPC <backspace> . C-p C-p C-p C-p C-e <backspace> <backspace> 
<backspace> <backspace> <backspace> C-n C-n C-n C-a 
C-SPC <escape> > C-x C-x C-SPC C-n C-n C-n C-n C-n 
C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n 
C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n 
C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n 
C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n 
C-n C-n C-n C-n C-n C-n C-n C-n C-n <escape> w C-x 
N C-x b t e m p 2 <return> C-y <escape> < C-x N C-x 
k <return> C-u C-x r t e m p <return> <escape> x u 
n d i g e s t i f y <return> h <escape> x e m a c s 
- r e p <tab> <backspace> <backspace> <backspace> <backspace> 
<backspace> <backspace> <backspace> <backspace> <backspace> 
r e p o <tab> r t <tab> <return>

Recent messages:
Counting messages...done
Mark set [3 times]
Saved text from "First some background on a problem I rep"
Mark set [2 times]
Counting messages...done
Message successfully undigestified
Counting messages...done
Computing summary lines...done
Making completion list...
Loading emacsbug...done

[-- Attachment #2: temp --]
[-- Type: application/octet-stream, Size: 48634 bytes --]