bug#5692: rfc822-addresses returns a string on occasion

[Uday S Reddy <u.s.reddy@cs.bham.ac.uk>]

A change made to rfc822.el in Emacs 23.1 seems to have introduced a
bug.  As the following calls illustrate, the function rfc822-addresses
normally returns a list of strings, but in the last case it is
returning a string.  This problem was not present in 22.3.

(rfc822-addresses "foo@bar")
("foo@bar")

(rfc822-addresses "foo:@bar")
("(Unparsable address -- Gubbish in middle of :...; group: \"foo:_^_@bar\")")

(rfc822-addresses "foo:;@bar")
"(Unparsable address -- Strange character \\@ found: \"@_^_bar\")"

------

More generally, it is not clear to me why rfc822-addresses is
returning strings instead of throwing errors when it finds bad address
strings.  From the code in VM, it appears that it was originally
expected to throw errors.  But that has changed sometime in the course
of revisions.

Cheers,
Uday

---------


In GNU Emacs 22.3.1 (i386-mingw-nt5.1.2600)
 of 2008-09-06 on SOFT-MJASON
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4)'

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: ENU
  locale-coding-system: cp1252
  default-enable-multibyte-characters: t

Major mode: VM Presentation

Minor modes in effect:
  shell-dirtrack-mode: t
  savehist-mode: t
  encoded-kbd-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  blink-cursor-mode: t
  unify-8859-on-encoding-mode: t
  utf-translate-cjk-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
<mouse-1> <down-mouse-1> <mouse-1> <down-mouse-1> <mouse-1> 
<down-mouse-1> <mouse-1> <wheel-up> <down-mouse-1> 
<mouse-1> <down-mouse-1> <mouse-1> <down-mouse-1> <mouse-1> 
<down-mouse-1> <mouse-movement> <mouse-1> <down-mouse-1> 
<mouse-1> <switch-frame> <down-mouse-1> <mouse-movement> 
<mouse-1> <switch-frame> <down-mouse-1> <mouse-movement> 
<mouse-1> C-x b <return> <escape> C-a C-v C-v C-v C-v 
C-s a d d r e s s e s C-s C-a <escape> C-x C-x C-g 
M-x d e b u g e e <backspace> <backspace> g e r - e 
s SPC <return> <switch-frame> <down-mouse-1> <mouse-movement> 
<mouse-1> C-x c C-g q M-x f o l d e r <return> <return> 
c c c c V C r e c i SPC <return> f o o <return> c c 
d d c d d c d d d c d c d c d c c c c <switch-frame> 
<down-mouse-1> <mouse-movement> <mouse-1> <wheel-down> 
<double-wheel-down> <wheel-down> <wheel-down> <wheel-down> 
<wheel-down> <wheel-up> <switch-frame> <down-mouse-1> 
<mouse-movement> <mouse-1> q V C r e c i SPC <return> 
f o o <return> c c d d c d d c d d d c d c d c d c 
d c d d c d d c d d c d d c d c d d d c d d c d c d 
c c c d d d d d c d c d c <switch-frame> <down-mouse-1> 
<mouse-movement> <mouse-1> <wheel-down> <down-mouse-1> 
<mouse-1> <switch-frame> <down-mouse-1> <mouse-movement> 
<mouse-1> d d c d c d d d c d c c d d d c d c d d c 
c c c c c c c c c c c c <switch-frame> <down-mouse-1> 
<mouse-movement> <mouse-1> SPC SPC SPC <backspace> 
C-x o C-n C-n C-p C-p C-p C-p C-p C-p C-n C-SPC C-n 
C-n C-n C-n C-n C-n C-n C-n C-x C-k M-x r e p o SPC 
r t - e m a c s SPC SPC <return>

Recent messages:
Continuing.
Entering debugger...
Continuing.
Entering debugger...
Continuing.
No messages. [3 times]
Decoding MIME message... done
Mark set
Making completion list...
Loading emacsbug...done