From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Klaus Straubinger Newsgroups: gmane.emacs.bugs Subject: bug#1899: marked as done (url-cookie-retrieve is not prepared for missing localpart) Date: Thu, 15 Jan 2009 09:44:29 +0100 () Message-ID: References: <87fxjlvcl7.fsf@cyd.mit.edu> Reply-To: Klaus Straubinger , 1899@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1232010247 15521 80.91.229.12 (15 Jan 2009 09:04:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 15 Jan 2009 09:04:07 +0000 (UTC) Cc: 1899-reopen@emacsbugs.donarmstrong.com, cyd@stupidchicken.com To: bug-gnu-emacs@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jan 15 10:05:13 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LNO9n-0007zT-Ja for geb-bug-gnu-emacs@m.gmane.org; Thu, 15 Jan 2009 10:04:56 +0100 Original-Received: from localhost ([127.0.0.1]:56965 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LNO8X-00015l-0L for geb-bug-gnu-emacs@m.gmane.org; Thu, 15 Jan 2009 04:03:37 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LNO8R-00014Q-21 for bug-gnu-emacs@gnu.org; Thu, 15 Jan 2009 04:03:31 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LNO8P-000139-IK for bug-gnu-emacs@gnu.org; Thu, 15 Jan 2009 04:03:30 -0500 Original-Received: from [199.232.76.173] (port=47331 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LNO8O-00012p-Vt for bug-gnu-emacs@gnu.org; Thu, 15 Jan 2009 04:03:29 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:40784) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LNO8O-0007H2-F9 for bug-gnu-emacs@gnu.org; Thu, 15 Jan 2009 04:03:28 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0F93Q3K017216; Thu, 15 Jan 2009 01:03:26 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n0F8o4wM013743; Thu, 15 Jan 2009 00:50:04 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Klaus Straubinger Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Thu, 15 Jan 2009 08:50:04 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 1899 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by submit@emacsbugs.donarmstrong.com id=B.123200910412509 (code B ref -1); Thu, 15 Jan 2009 08:50:04 +0000 Original-Received: (at submit) by emacsbugs.donarmstrong.com; 15 Jan 2009 08:45:04 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0F8j0Jk012370 for ; Thu, 15 Jan 2009 00:45:01 -0800 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LNNqW-0000sP-7U for bug-gnu-emacs@gnu.org; Thu, 15 Jan 2009 03:45:00 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LNNqU-0000sA-OW for bug-gnu-emacs@gnu.org; Thu, 15 Jan 2009 03:44:59 -0500 Original-Received: from [199.232.76.173] (port=51402 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LNNqU-0000s3-FX for bug-gnu-emacs@gnu.org; Thu, 15 Jan 2009 03:44:58 -0500 Original-Received: from mx20.gnu.org ([199.232.41.8]:4770) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LNNqT-0005Fo-VC for bug-gnu-emacs@gnu.org; Thu, 15 Jan 2009 03:44:58 -0500 Original-Received: from smtpde01.sap-ag.de ([155.56.68.171]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LNNqS-0003W9-ON for bug-gnu-emacs@gnu.org; Thu, 15 Jan 2009 03:44:57 -0500 Original-Received: from mail.sap.corp by smtpde01.sap-ag.de (26) with ESMTP id n0F8iWat016486 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 15 Jan 2009 09:44:32 +0100 (MET) In-Reply-To: X-Mailer: Gnus/5.11 (Gnus v5.11) Emacs/22.3 X-Scanner: Virus Scanner virwal05 X-SAP: out X-detected-kernel: by mx20.gnu.org: Solaris 10 (beta) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Thu, 15 Jan 2009 04:03:30 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:24145 Archived-At: Chong Yidong wrote: >> the function url-cookie-retrieve (defined in lisp/url/url-cookie.el) >> is not prepared for the case that the parameter localpart could be >> nil: (regexp-quote nil) is an error. This is especially problematic >> since the corresponding function for setting cookies, >> url-cookie-store, defines the parameter localpart as optional. > > I've checked in a fix. Thanks. Your fix changed the "string-match" to "equal" while keeping the "regexp-quote". This will not work for all cases where "localpart" is not empty. I am afraid that this mail might not be the right way to reopen the bug. I apologize for any inconvenience this might cause. -- Klaus Straubinger