From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#2151: 23.0.90; Building the 23.0.90 pretest recompiles Lisp files Date: Sat, 28 Feb 2009 00:18:37 +0200 Message-ID: References: Reply-To: Eli Zaretskii , 2151@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1235774663 1663 80.91.229.12 (27 Feb 2009 22:44:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 27 Feb 2009 22:44:23 +0000 (UTC) To: 2151@emacsbugs.donarmstrong.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Feb 27 23:45:40 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LdBSW-0004ki-Lt for geb-bug-gnu-emacs@m.gmane.org; Fri, 27 Feb 2009 23:45:32 +0100 Original-Received: from localhost ([127.0.0.1]:34895 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LdBRB-0002ZO-RD for geb-bug-gnu-emacs@m.gmane.org; Fri, 27 Feb 2009 17:44:09 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LdBQk-00026x-Je for bug-gnu-emacs@gnu.org; Fri, 27 Feb 2009 17:43:42 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LdBQi-00025C-Td for bug-gnu-emacs@gnu.org; Fri, 27 Feb 2009 17:43:42 -0500 Original-Received: from [199.232.76.173] (port=59990 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LdBQi-00024z-No for bug-gnu-emacs@gnu.org; Fri, 27 Feb 2009 17:43:40 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:37652) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LdBQi-0001QU-54 for bug-gnu-emacs@gnu.org; Fri, 27 Feb 2009 17:43:40 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1RMhc5H025274; Fri, 27 Feb 2009 14:43:38 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n1RMP4UW018832; Fri, 27 Feb 2009 14:25:04 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Eli Zaretskii Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Fri, 27 Feb 2009 22:25:04 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 2151 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 2151-submit@emacsbugs.donarmstrong.com id=B2151.123577312517298 (code B ref 2151); Fri, 27 Feb 2009 22:25:04 +0000 Original-Received: (at 2151) by emacsbugs.donarmstrong.com; 27 Feb 2009 22:18:45 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from mtaout2.012.net.il (mtaout2.012.net.il [84.95.2.4]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1RMIfZI017292 for <2151@emacsbugs.donarmstrong.com>; Fri, 27 Feb 2009 14:18:42 -0800 Original-Received: from conversion-daemon.i_mtaout2.012.net.il by i_mtaout2.012.net.il (HyperSendmail v2004.12) id <0KFQ00200WK82M00@i_mtaout2.012.net.il> for 2151@emacsbugs.donarmstrong.com; Sat, 28 Feb 2009 00:19:12 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([77.127.167.119]) by i_mtaout2.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0KFQ002LMWNY7811@i_mtaout2.012.net.il>; Sat, 28 Feb 2009 00:19:11 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Fri, 27 Feb 2009 17:43:42 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:25811 Archived-At: > Date: Fri, 27 Feb 2009 17:02:38 +0200 > From: Eli Zaretskii > Cc: > > There's one other reason for compiling Lisp files during the build, it > is this fragment from the top-level Makefile.in: > > # Subdirectories to make recursively. `lisp' is not included > # because the compiled lisp files are part of the distribution. > # leim is not included because it needs special handling. > # > # Actually, we now include `lisp' as well, since the compiled files > # are not included any more in case of bootstrap or in case Emacs was > # checked out from a VCS. > SUBDIR = lib-src src lisp The reason that recursing into `lisp' causes more recompilation is that `make-dist' does this: echo "Recompiling Lisp files" $EMACS -batch -f batch-byte-recompile-directory lisp leim while the top-level Makefile.in does this: ${SUBDIR}: Makefile FRC boot=bootstrap-emacs$(EXEEXT); \ if [ -x "src/$$boot" ]; then boot=""; fi; \ cd $@; $(MAKE) all $(MFLAGS) \ CC='${CC}' CFLAGS='${CFLAGS}' CPPFLAGS='${CPPFLAGS}' \ LDFLAGS='${LDFLAGS}' MAKE='${MAKE}' BOOTSTRAPEMACS="$$boot" IOW, Makefile.in runs "make all" in `lisp'. Recompilation happens because "make all" observes dependencies between some *.elc files, while batch-byte-recompile-directory does not. So among the *.elc files generated by make-dist it could well happen that a .elc file that is prerequisite for some other .elc file ends up being newer, which will cause "make all" to want to recompile that particular dependency. I think we should replace batch-byte-recompile-directory in make-dist with a call to "make -C lisp all". Any objections?