unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Francis Litterio <flitterio@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>, 720@emacsbugs.donarmstrong.com
Subject: bug#720: Patch to fix CVS Emacs compilation error on Windows XP SP2.
Date: Fri, 15 Aug 2008 09:22:31 -0400	[thread overview]
Message-ID: <ubpzu76f9.fsf@gmail.com> (raw)
In-Reply-To: <mailman.16768.1218790062.18990.bug-gnu-emacs@gnu.org> (Eli Zaretskii's message of "Fri\, 15 Aug 2008 11\:22\:07 +0300")

Eli Zaretskii wrote:

>> From: Francis Litterio
>> 
>> 	w32.c(3820) : error C2520: conversion from unsigned __int64 to double not implemented, use signed __int64
>
> "Not implemented"?  I'm not sure we want to support such a deficient
> compiler.

I would happily use a newer compiler.  The file emacs/nt/INSTALL says
this:

   To compile Emacs, you will need either Microsoft Visual C++ 2.0, or
   later up to 7.0, and nmake

I didn't realize that I could use a version of VC++ newer than 6.0.  I
would be happy to abandon 6.0 for building Emacs on Windows.  Is VC++
7.0 the compiler that comes with Visual Studio 2003?

What compiler do the Emacs developers use to build on Windows?

> How about this:
>
>   DWORD tot_hi = memstex.ullTotalPhys >> 32;
>   DWORD tot_md = (memstex.ullTotalPhys & 0x00000000ffffffffLL) >> 10;
>   DWORD tot_lo = memstex.ullTotalPhys % 1024LL;
>   totphys = tot_hi * 4194304.0 + tot_md + tot_lo / 1024.0;
>
> Does this work?

Nope:

  w32.c(3823) : error C2059: syntax error : 'bad suffix on number'
  w32.c(3823) : error C2146: syntax error : missing ')' before identifier 'L'
  w32.c(3823) : error C2059: syntax error : ')'
  w32.c(3824) : error C2059: syntax error : 'bad suffix on number'
  w32.c(3824) : error C2146: syntax error : missing ';' before identifier 'L'
  w32.c(3824) : error C2065: 'L' : undeclared identifier

Here's the relevant code with line numbers:

  3819	  if (global_memory_status_ex (&memstex))
  3820	#if 1
  3821	  {
  3822	    DWORD tot_hi = memstex.ullTotalPhys >> 32;
  3823	    DWORD tot_md = (memstex.ullTotalPhys & 0x00000000ffffffffLL) >> 10;
  3824	    DWORD tot_lo = memstex.ullTotalPhys % 1024LL;
  3825	    totphys = tot_hi * 4194304.0 + tot_md + tot_lo / 1024.0;
  3826	  }
  3827	#else
  3828	    totphys = (signed __int64)memstex.ullTotalPhys / 1024.0;
  3829	#endif

--
Fran






  parent reply	other threads:[~2008-08-15 13:22 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <uskt6dvo2.fsf@gnu.org>
2008-08-14 16:57 ` bug#720: Patch to fix CVS Emacs compilation error on Windows XP SP2 Francis Litterio
2008-08-14 19:24   ` Eli Zaretskii
2008-08-14 19:54   ` Stefan Monnier
2008-08-14 20:20     ` Eli Zaretskii
2008-08-15 19:31       ` Stefan Monnier
     [not found]   ` <mailman.16704.1218743250.18990.bug-gnu-emacs@gnu.org>
2008-08-14 20:15     ` Francis Litterio
2008-08-15  8:22       ` Eli Zaretskii
2008-08-15 19:34         ` Stefan Monnier
     [not found]       ` <mailman.16768.1218790062.18990.bug-gnu-emacs@gnu.org>
2008-08-15 13:22         ` Francis Litterio [this message]
2008-08-15 16:15           ` Eli Zaretskii
2008-08-15 17:11             ` Fran Litterio
2008-08-15 17:37               ` Eli Zaretskii
2008-08-15 17:45   ` bug#720: marked as done (Patch to fix CVS Emacs compilation error on Windows XP SP2.) Emacs bug Tracking System

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ubpzu76f9.fsf@gmail.com \
    --to=flitterio@gmail.com \
    --cc=720@emacsbugs.donarmstrong.com \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).