From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#2607: 23.0.90; `system-type' test in `shell-quote-wildcard-pattern' Date: Tue, 10 Mar 2009 22:02:04 +0200 Message-ID: References: <005601c9a07f$96946c50$0200a8c0@us.oracle.com> Reply-To: Eli Zaretskii , 2607@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1236716720 21391 80.91.229.12 (10 Mar 2009 20:25:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 10 Mar 2009 20:25:20 +0000 (UTC) Cc: 2607@emacsbugs.donarmstrong.com To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Mar 10 21:26:33 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Lh8Wr-0007Fe-Hy for geb-bug-gnu-emacs@m.gmane.org; Tue, 10 Mar 2009 21:26:21 +0100 Original-Received: from localhost ([127.0.0.1]:33542 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lh8VV-0006Nl-Kw for geb-bug-gnu-emacs@m.gmane.org; Tue, 10 Mar 2009 16:24:57 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lh8UN-0005BC-Ld for bug-gnu-emacs@gnu.org; Tue, 10 Mar 2009 16:23:47 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lh8UK-00057O-Bx for bug-gnu-emacs@gnu.org; Tue, 10 Mar 2009 16:23:46 -0400 Original-Received: from [199.232.76.173] (port=42916 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lh8UJ-00056r-Q8 for bug-gnu-emacs@gnu.org; Tue, 10 Mar 2009 16:23:43 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:39337) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Lh8UJ-000277-5c for bug-gnu-emacs@gnu.org; Tue, 10 Mar 2009 16:23:43 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n2AKNfe6030448; Tue, 10 Mar 2009 13:23:41 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n2AKA5oD027050; Tue, 10 Mar 2009 13:10:05 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Eli Zaretskii Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Tue, 10 Mar 2009 20:10:05 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 2607 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 2607-submit@emacsbugs.donarmstrong.com id=B2607.123671533824801 (code B ref 2607); Tue, 10 Mar 2009 20:10:05 +0000 Original-Received: (at 2607) by emacsbugs.donarmstrong.com; 10 Mar 2009 20:02:18 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from mtaout2.012.net.il (mtaout2.012.net.il [84.95.2.4]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n2AK2ExR024794 for <2607@emacsbugs.donarmstrong.com>; Tue, 10 Mar 2009 13:02:15 -0700 Original-Received: from conversion-daemon.i_mtaout2.012.net.il by i_mtaout2.012.net.il (HyperSendmail v2004.12) id <0KGB008003JPHX00@i_mtaout2.012.net.il> for 2607@emacsbugs.donarmstrong.com; Tue, 10 Mar 2009 22:02:52 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([84.228.183.217]) by i_mtaout2.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0KGB003RA3OPGOI0@i_mtaout2.012.net.il>; Tue, 10 Mar 2009 22:02:50 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Tue, 10 Mar 2009 16:23:46 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:26214 Archived-At: > From: Stefan Monnier > Cc: 2607@emacsbugs.donarmstrong.com, Drew Adams > Date: Mon, 09 Mar 2009 21:14:30 -0400 > > BTW, Reading the docstring makes me wonder what this function is really > intended to do. Especially the last sentence: > > Existing quote characters in PATTERN are left alone, so you can pass > PATTERN that already quotes some of the special characters. > > I see what it corresponds to in the DOS part of the code, but I don't > see anything equivalent in the Unix side. Wonderful, isn't it? code that solves a non-trivial problem by doing absolutely nothing? Seriously, though: that function does do what the doc string promises, on Unix as well as on DOS/Windows. It does that by not quoting the Unix quote character: the backslash itself. Thus (shell-quote-wildcard-pattern "'foo*") => "\\'foo*" but (shell-quote-wildcard-pattern "foo\\*") => "foo\\*" Perhaps we should make the doc string less of a riddle by saying explicitly that "quote characters" in this context means " on Windows and backslash on Unix. > And furthermore, even seeing the code, I don't understand what is > this special case supposed to be used for. Sorry, I don't understand: what special case did you have in mind?