From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Christopher Dimech Newsgroups: gmane.emacs.bugs Subject: bug#57424: Perceptibility of display-fill-column-indicator-mode Date: Fri, 26 Aug 2022 08:43:38 +0200 Message-ID: References: <877d2vh638.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26539"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 57424@debbugs.gnu.org To: Protesilaos Stavrou Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 26 08:44:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oRT4f-0006iY-OQ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 26 Aug 2022 08:44:13 +0200 Original-Received: from localhost ([::1]:38130 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oRT4e-0005LF-G4 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 26 Aug 2022 02:44:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54152) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRT4V-0005L6-D8 for bug-gnu-emacs@gnu.org; Fri, 26 Aug 2022 02:44:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33886) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oRT4U-0002KB-W7 for bug-gnu-emacs@gnu.org; Fri, 26 Aug 2022 02:44:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oRT4U-00049K-Ge for bug-gnu-emacs@gnu.org; Fri, 26 Aug 2022 02:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Christopher Dimech Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 Aug 2022 06:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57424 X-GNU-PR-Package: emacs Original-Received: via spool by 57424-submit@debbugs.gnu.org id=B57424.166149622815919 (code B ref 57424); Fri, 26 Aug 2022 06:44:02 +0000 Original-Received: (at 57424) by debbugs.gnu.org; 26 Aug 2022 06:43:48 +0000 Original-Received: from localhost ([127.0.0.1]:51868 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRT4F-00048h-Hi for submit@debbugs.gnu.org; Fri, 26 Aug 2022 02:43:47 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:37249) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRT4C-00048S-Ok for 57424@debbugs.gnu.org; Fri, 26 Aug 2022 02:43:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1661496218; bh=puI1ma4yrDmUOvTUQFLZBazOvCK7+ZRxpedQKe+IQzQ=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References; b=cDVTfJD+m5b6pe83q4ig1nqzUjsZMVEaymTuGkqz4i8JaLV8lSB8im3khVxtmDmf+ 6qzmvEqJ4XqHOJISC4O3naMRwpOY8IY5zKuZ9U3YFkr+1Gf3z/96o46GpXHPCQrqKa lHSVqaXBQVRcQE1s6kVUyEIQCYTAddcyBH45ENSA= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [92.251.127.164] ([92.251.127.164]) by web-mail.gmx.net (3c-app-mailcom-bs07.server.lan [172.19.170.175]) (via HTTP); Fri, 26 Aug 2022 08:43:38 +0200 Importance: normal Sensitivity: Normal In-Reply-To: <877d2vh638.fsf@protesilaos.com> X-UI-Message-Type: mail X-Priority: 3 X-Provags-ID: V03:K1:ayeqVf2/onIzKe/OwMxBs9q2YyRWPxMFw0YeCdzRKXyrG1BlKDNmKNgzpEdVmeUyAgo2R 6Bd3SMPAX/W1XJCwAWFvqc4lhu0+DPAISpucb03s9mOz01BTkgaR0guv1B+ZVrrssyaRobvDthbY ccuKV6MphVc70jx7ZUFNvmfugA5s1t9HrwWbXrYZXqG1Xpujx47SREEiv3cxcqpgvN4ijT8CaOCq mxHtljBoJLCvudnDHlo1DXUgYDykYtY3jnTxC62g1VPgG7tu2EsIa0Ki9cSbtw38e2AaQ0DPNvV2 XI= X-UI-Out-Filterresults: notjunk:1;V03:K0:qWzZfpS0d1w=:qf9ZeWB6g0gh+scWa6DNS1 ri3MRYDarYDCU/+dEcZpsOxhygEUChQ0WsPzCMEI7jRxrFGT8wZ6Y0oXl32//hvFPuDxxDMY3 p18vTY//xixzWCRCEtQv9JNT6Fzk2AjFRzV17Lbbcy+czz+GeXNDg1oTV5+Q0AF83paYtIcgF WuQiO9yi027H27znwkmYjtjiYeant8wBoNxs62wmD8jaRXaAvs4zOqHmF4+bKIO/V0AI6Zx1u uzg/ZMkHgZZZGTCPUZnHciD4r3lWrZ9K8RsRKjhNGCMJnUbhFWUGeVSnVf7U6/OYIsfYJOQ/I NmyZWqJ9xOWWIBzy6AvoXZsZp/bwvDTl+UexKhNqSf+MS3AtHFtcNeqGtGSHo7+0O7Gm5OjC6 oRjLbP8WGl/aAEcOZ/gk+XdvG5rGZQftGGw0k0Ym2VJIjCoLyWyBhG0SpC+RIS/bCU9HBJVxV Ko2ucHx4TlFvl4kXEsThpkG3Uqqf/xT5P2iDXAwAUgR4H7wf3aVZycv0V8Cz8cdHPW3+mPTE6 itomXXEJPuD2BJ+tslx7hhyTi+hrLMD65tiFUa40g/dCQ9qX9NutdEn7LnTHp87WZv7GrtwUN 2yvM7upNFncsmyWszZ+GCAhjr0Z83jBkvTcdVqXVtOm89U4wHBFr/CYmDrzm4AsNKhPSf7Hp7 WjLEQCWJpOBDNy5s2o0idprxLDOVMPfxPAxZ21Elz5qzs4E5MoE409AeXmxF0SI/YnRc1AutO 8qP4a5Q4leH00R8S7qSnr6HPUHBiu2dlIb769HssHWllFJGnDejbs700KbctqXd3hZeB4oNk X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:240776 Archived-At: > Sent: Friday, August 26, 2022 at 6:27 PM > From: "Protesilaos Stavrou" > To: "Christopher Dimech" , 57424@debbugs.gnu.org > Subject: Re: bug#57424: Perceptibility of display-fill-column-indicator-= mode > > > From: Christopher Dimech > > Date: Fri, 26 Aug 2022 07:44:23 +0200 > > > > Have followed the customisation discussion about > > display-fill-column-indicator-mode > > > > Have consulted with Protesilaos Stavrou, author of > > modus-themes. I agree that the default indicator character is > > too thin. Changing the character to something wider does not > > change things much. A solution that works is that of setting a > > background colour, rather than changing the foreground colour . > > Christopher, please don't take words out of context. State what you > think the bug is without involving me or other people. Was not meant to involve you. But mentioned changes you suggested as context of what one can try and see how things look like. > My involvement in this only concerns the modus-themes. I explained via > a private channel why the modus-themes style the fill-column-indicator > like this: > > ;; Not actual code, but true to form: > (set-face-attribute 'fill-column-indicator nil :height 1 :background= "gray50" :foreground "gray50") > > The default face of fill-column-indicator creates a dashed line when (i) > the user applies a default font with a tall line height, (ii) increases > the value of 'line-spacing', (iii) applies an increased height to > certain elements, such as scaling the faces of Org headings. > > Because of these common scenaria, users would tell me that the visuals > looked broken. Changing the face, as shown above, produces a contiguous > line. This is a compromise, so that I stop getting the same issue over > and over that the themes are broken. The report is not about modus-themes, so you can do the compromise for the themes, and I can change that should I want, following your comments. > > [... 15 lines elided] > > > The only way to ensure a contiguous vertical line is to > > explicitly set the :height of the face to a small value. This > > brings out the perceptibility problem. > > > > Studying carefully WCAG 2.1, Section 1.4.3 Contrast (Minimum), > > the contrast ratio is also subject to change according to the > > thinness of the characters. For instance, With larger thicker > > text, the contrast ratio of at least 4.5:1 can be modified to to > > at least 3:1. > > > > I see the requirement of a contiguous indicator line is mainly about > > aesthetics. But practical usability should be of higher concern. > > I shared code with you on how to change the face to the effect that it > widens the width of the line. Please use it. I also stated in clear > terms why this decision was made. You insist on dismissing it as > "aesthetics". There is nothing more I can do about it. > > -- > Protesilaos Stavrou > https://protesilaos.com >