From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Christopher Dimech Newsgroups: gmane.emacs.bugs Subject: bug#45068: Patch for Modus themes 1.1.1? (was: bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible)) Date: Mon, 25 Jan 2021 13:51:35 +0100 Message-ID: References: <87im9fgm27.fsf@protesilaos.com> <87zh2ldgtf.fsf@protesilaos.com> <87k0toof83.fsf@mail.linkov.net> <83wnxo1mcr.fsf@gnu.org> <83v9d81khh.fsf@gnu.org> <83mtyk1hq3.fsf@gnu.org> <87czzgbapt.fsf@protesilaos.com> <83lfe4192f.fsf@gnu.org> <83im9814oh.fsf@gnu.org> <87sg6po0yd.fsf_-_@protesilaos.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26663"; mail-complaints-to="usenet@ciao.gmane.io" Cc: info@protesilaos.com, juri@linkov.net, contovob@tcd.ie, Stefan Kangas , 45068@debbugs.gnu.org To: Protesilaos Stavrou Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 25 13:52:25 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l41M1-0006sK-14 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 25 Jan 2021 13:52:25 +0100 Original-Received: from localhost ([::1]:41334 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l41M0-0000R9-0W for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 25 Jan 2021 07:52:24 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59376) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l41Le-0000Ho-Oi for bug-gnu-emacs@gnu.org; Mon, 25 Jan 2021 07:52:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54901) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l41Le-0003b3-GC for bug-gnu-emacs@gnu.org; Mon, 25 Jan 2021 07:52:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l41Le-0000Yy-FL for bug-gnu-emacs@gnu.org; Mon, 25 Jan 2021 07:52:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Christopher Dimech Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 25 Jan 2021 12:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45068 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 45068-submit@debbugs.gnu.org id=B45068.16115791062133 (code B ref 45068); Mon, 25 Jan 2021 12:52:02 +0000 Original-Received: (at 45068) by debbugs.gnu.org; 25 Jan 2021 12:51:46 +0000 Original-Received: from localhost ([127.0.0.1]:38214 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l41LN-0000YL-Ok for submit@debbugs.gnu.org; Mon, 25 Jan 2021 07:51:46 -0500 Original-Received: from mout.gmx.net ([212.227.15.15]:34801) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l41LL-0000Y3-NH for 45068@debbugs.gnu.org; Mon, 25 Jan 2021 07:51:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1611579095; bh=AAzgMEj+NI+bn6wlkJoRt+UgG+2VkWQrOgAXqUig8Cs=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References; b=IHsWX2HNjsLGVFzXpSWnQGnVez5vsI5IvzT82WzMWpof/oznfC9bzaPc9N022mrbA wTLPa+Am7qT32UsyST+chUzK/NV3KSyQcwjhSgLZlEb3lpIJD1LdhIfRtrdHdV0Iui JGndSHF2YORvEH0/1G6ibedxaR5wtbiWavE3QgM0= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [213.165.168.94] ([213.165.168.94]) by web-mail.gmx.net (3c-app-mailcom-bs12.server.lan [172.19.170.180]) (via HTTP); Mon, 25 Jan 2021 13:51:35 +0100 Importance: normal Sensitivity: Normal In-Reply-To: <87sg6po0yd.fsf_-_@protesilaos.com> X-UI-Message-Type: mail X-Priority: 3 X-Provags-ID: V03:K1:TqjhPyCMQ0lIvK/Ub548+bmRxKHfzTjQNcqDlho04wtR4zem/i20bV+Dt1kCKcxiDcWe8 GbnE3WXoZamNH1d44C0W63FwsNdZGyppIsw/rKrHoGZSzD/bi9JxSejL2wUWblysXZ0GU3Bg8Qy5 P1kU9gAa76Y2KgSoz7qh1+U2SEhsl1Yr5pBqahFP+X8ZhbQmLYqaH+KrK6c3c2xFQ13WGy7iQqsD ddXfllXr7imBD8eeqiV7PCQ7WwuNTXNULu5gkg71Z+Iob8mUxPPAvhdx0LtCiKso2g3qp+uAHvQh d4= X-UI-Out-Filterresults: notjunk:1;V03:K0:h550mUy7uV0=:DotCe2KvNHVXgsh2MFxnum IG6fR5ilJS7MOGT1Ol1V/HvgZbRlUwidHPyg6R1xdENJ80CgZhe1dwn5Gkpglg01u+/xcT7p3 QC12O2DtqWPbUXslglovW5BT33yWNzcngf7nvVgEzF9Fxi1pZx/lytwTcHIPXhQTlKTVjT9km BdDU8Cflu+A39uImuQgBFaGzW3Mybc9/1H++Uvj8tUfZLgRxBxmcD4R1obO5EEfxK4ZhewI8w /rGGKnWceM2v54QkFzJ0y2H3i+LmZzqRVc1VwUpN/sf2O7kyVTgBlY72PcYOLa7dZItLnabaR T8p0Wc/PPJ+mcDVHVp9LNoD6wurwovO1NFzDOMhN3WVdq7ej+3uV3qlGvm9Cuy/ikvonIwDX1 5Eb2uGK2QFDeCE39HOknMiupjFU49YZZEBZHiRTTRKMaGhBKIAySJj6Pf9mGT1JvIsivqeiHC put6QAEpJmyfFrxELidEufnbeHURMDdUVhIvC4CRBDFtanGCbFv6SNNZEahdP0ipmNYVQiE4w Gfd3vj4LQBNZC5t85dNf4C9lE4GM+ggufYWvx+/FToQ54aVjUEhb96YAGsY/+4f08ZRcVbcq2 psyjKUTwTDN2s= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:198564 Archived-At: > Sent: Monday, January 25, 2021 at 8:49 PM > From: "Protesilaos Stavrou" > To: "Eli Zaretskii" > Cc: contovob@tcd.ie, info@protesilaos.com, 45068@debbugs.gnu.org, "Stefa= n Kangas" , juri@linkov.net > Subject: bug#45068: Patch for Modus themes 1.1.1? (was: bug#45068: [PATC= H] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible)) > > On 2020-12-11, 22:14 +0200, Eli Zaretskii wrote: > > >> From: Stefan Kangas > >> Date: Fri, 11 Dec 2020 13:08:19 -0600 > >> Cc: juri@linkov.net, contovob@tcd.ie, 45068@debbugs.gnu.org > >> > >> Eli Zaretskii writes: > >> > >> > . don't consider this a "theme", but a normal Lisp package (since= it > >> > basically violates the conventions for writing a theme) > >> > >> I guess such violations of our old conventions are getting increasing= ly > >> common in (third-party) Emacs theme development. > > > > Then maybe the best way is to provide that require-theme function I > > proposed. > > Hello again! > > I have produced a newer version in the meantime. Though I understand > that a patch would not be able to be merged under the present > conditions. Should I prepare it regardless? This would also fix > bug#45141 pertaining to some formatting issues in modus-themes.texi. > > To recapitulate for your convenience: > > + The current etc/themes/modus-{operandi,vivendi}-theme.el are old-style > themes in that they look like the rest of that directory's contents. > > - They exist as standalone files. They do not require any library. > - All their face declarations are furnished therein. > - Their version is 0.13.0. > > + As of version 1.0.0 (and now 1.1.1) of the Modus themes, those two > files merely expand a macro and declare their respective theme. They > thus depend on a shared library: currently that is modus-themes.el. > > - The library unifies the themes' defcustom declarations and, in > general, streamlines their development (before I would copy lines > from one to the other to ensure parity). > > - This approach of a library and concomitant macro expansion is not in > line with the current design of etc/themes/, though as Stefan Kangas > observed, such deviations from the established norms are becoming > increasingly common in third-party packages. The focus should not be on implementation but on functionality. As things flourish, people will find various ways to do it, with some being better because they yield to a different strategy. I suggest a more pragmatic app= roach. > A quick-and-dirty workaround would be to place the library in some other > path, such as lisp/modus-themes.el and keep the other two files were > they currently are: etc/themes/modus-{operandi,vivendi}-theme.el > > This could, however, make the source code more difficult to understand. > It would also set a bad precedent for any possible future themes, as > this thread revealed. So Eli Zaretskii proposed a new 'require-theme' > function. > > I believe this is how things stand. > > For my part, I am willing to do whatever you consider necessary and will > follow your lead. > > Thank you for your time and efforts! > Protesilaos or Prot > > -- > Protesilaos Stavrou > protesilaos.com > > > >